[{"id":13774,"web_url":"https://patchwork.libcamera.org/comment/13774/","msgid":"<20201118131204.tye3ykdiubpnovrs@uno.localdomain>","date":"2020-11-18T13:12:04","subject":"Re: [libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add\n\tisolation flag to proxy creation","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:52PM +0900, Paul Elder wrote:\n> When the IPA proxy is created, it needs to know whether to isolate or\n> not. Feed the flag at creation of the IPA proxy.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> No change in v2\n> ---\n> src/libcamera/ipa_manager.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 12cf3b0d..3a32573f 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -291,7 +291,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t\treturn nullptr;\n> \t}\n>\n> -\tstd::unique_ptr proxy = pf->create(m);\n> +\tstd::unique_ptr proxy =\n> +\t\tpf->create(m, !self_->isSignatureValid(m));\n> \tif (!proxy->isValid()) {\n> \t\tLOG(IPAManager, Error) << \"Failed to load proxy\";\n> \t\treturn nullptr;\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12A8FBE08A\n\tfor ;\n\tWed, 18 Nov 2020 13:12:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFF1261568;\n\tWed, 18 Nov 2020 14:12:02 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6494A61565\n\tfor ;\n\tWed, 18 Nov 2020 14:12:01 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id EF3ADE0006;\n\tWed, 18 Nov 2020 13:12:00 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 18 Nov 2020 14:12:04 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201118131204.tye3ykdiubpnovrs@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-23-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-23-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add\n\tisolation flag to proxy creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13886,"web_url":"https://patchwork.libcamera.org/comment/13886/","msgid":"<20201125193634.GH26606@pendragon.ideasonboard.com>","date":"2020-11-25T19:36:34","subject":"Re: [libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add\n\tisolation flag to proxy creation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:52PM +0900, Paul Elder wrote:\n> When the IPA proxy is created, it needs to know whether to isolate or\n> not. Feed the flag at creation of the IPA proxy.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\nBut you should really squash this with the patch that adds the flag to\nthe create function.\n\n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> src/libcamera/ipa_manager.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 12cf3b0d..3a32573f 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -291,7 +291,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t\treturn nullptr;\n> \t}\n> \n> -\tstd::unique_ptr proxy = pf->create(m);\n> +\tstd::unique_ptr proxy =\n> +\t\tpf->create(m, !self_->isSignatureValid(m));\n> \tif (!proxy->isValid()) {\n> \t\tLOG(IPAManager, Error) << \"Failed to load proxy\";\n> \t\treturn nullptr;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71566BE08A\n\tfor ;\n\tWed, 25 Nov 2020 19:36:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05A9A63412;\n\tWed, 25 Nov 2020 20:36:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D03663402\n\tfor ;\n\tWed, 25 Nov 2020 20:36:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D0F8292;\n\tWed, 25 Nov 2020 20:36:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qSZoUQ/F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606333003;\n\tbh=O2De22hYj9ZafZHQtKqsuycPFJIZKXbgKjo0QNoYi2E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qSZoUQ/FlQTX0Sf+AtQnhlCZgSpCjAO4TeO0chU7+9PonCAfB6wHLjqNHm2b02eMM\n\tSz0i6rRdBJ5DOwj8fTlMIP3Wra2uAqltrmpW33y2pdS/EVW7S0PAh4HZOV/ApTTItB\n\tXmx99xy6DqAsluDgjzR6VBOQiWMGSTzyaagak0AM=","Date":"Wed, 25 Nov 2020 21:36:34 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125193634.GH26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-23-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-23-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add\n\tisolation flag to proxy creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]