{"id":10370,"url":"https://patchwork.libcamera.org/api/patches/10370/?format=json","web_url":"https://patchwork.libcamera.org/patch/10370/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201106103707.49660-23-paul.elder@ideasonboard.com>","date":"2020-11-06T10:36:52","name":"[libcamera-devel,v4,22/37] libcamera: IPAManager: add isolation flag to proxy creation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"68c9d014b64dedd810e315af9a7b18a25ebde3da","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10370/mbox/","series":[{"id":1448,"url":"https://patchwork.libcamera.org/api/series/1448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1448","date":"2020-11-06T10:36:30","name":"IPA isolation implementation","version":4,"mbox":"https://patchwork.libcamera.org/series/1448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10370/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10370/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B97F1BDB89\n\tfor ;\n\tFri, 6 Nov 2020 10:38:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81F4562D22;\n\tFri, 6 Nov 2020 11:38:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3106C62D20\n\tfor ;\n\tFri, 6 Nov 2020 11:38:09 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6BEE8B16;\n\tFri, 6 Nov 2020 11:38:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TPs/3G6H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659088;\n\tbh=TSqLEUo/nKmhR/T5P9YixjkujXn6AvH3dO3ba6lc9Hs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TPs/3G6HgKylN1nXWHKEBXFvzOUfX+bMaVEXunLa+LBSEwX6qVE223/yon+aAo2jg\n\t0/IMdovpwccOi0SMEzfGjDk3SrwQkZFnBHwBXKNMt4PHDziAoelN8Bxb3ex17CLaUk\n\tGCvNnBf3PsgCnNigDal4VMzBXMN4Uc1k+MDJunAQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Nov 2020 19:36:52 +0900","Message-Id":"<20201106103707.49660-23-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 22/37] libcamera: IPAManager: add\n\tisolation flag to proxy creation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When the IPA proxy is created, it needs to know whether to isolate or\nnot. Feed the flag at creation of the IPA proxy.\n\nSigned-off-by: Paul Elder \nReviewed-by: Niklas Söderlund \n\n---\nNo change in v4\n\nNo change in v3\n\nNo change in v2\n---\n src/libcamera/ipa_manager.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\nindex 12cf3b0d..3a32573f 100644\n--- a/src/libcamera/ipa_manager.cpp\n+++ b/src/libcamera/ipa_manager.cpp\n@@ -291,7 +291,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n \t\treturn nullptr;\n \t}\n \n-\tstd::unique_ptr proxy = pf->create(m);\n+\tstd::unique_ptr proxy =\n+\t\tpf->create(m, !self_->isSignatureValid(m));\n \tif (!proxy->isValid()) {\n \t\tLOG(IPAManager, Error) << \"Failed to load proxy\";\n \t\treturn nullptr;\n","prefixes":["libcamera-devel","v4","22/37"]}