[{"id":13683,"web_url":"https://patchwork.libcamera.org/comment/13683/","msgid":"<20201112110930.GE1480295@oden.dyn.berto.se>","date":"2020-11-12T11:09:30","subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-11-06 19:36:51 +0900, Paul Elder wrote:\n> Now that each pipeline handler has its own IPAProxy implementation, make\n> the IPAManager fetch the IPAProxy based on the pipeline handler name.\n> Also, since the IPAProxy is used regardless of isolation or no\n> isolation, remove the isolation check from the proxy selection.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> src/libcamera/ipa_manager.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index ad05b9c9..12cf3b0d 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -275,8 +275,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t *\n> \t * \\todo Implement a better proxy selection\n> \t */\n> -\tconst char *proxyName = self_->isSignatureValid(m)\n> -\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n> +\tstd::string pipeName(pipe->name());\n> +\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n> \tIPAProxyFactory *pf = nullptr;\n> \n> \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D381BE082\n\tfor ;\n\tThu, 12 Nov 2020 11:09:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9B5F6305E;\n\tThu, 12 Nov 2020 12:09:33 +0100 (CET)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 784696305E\n\tfor ;\n\tThu, 12 Nov 2020 12:09:32 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id w15so405680lji.10\n\tfor ;\n\tThu, 12 Nov 2020 03:09:32 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tw13sm522650lfq.72.2020.11.12.03.09.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Nov 2020 03:09:31 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"BMZ0nGOS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=z7ftharsRbNjfdGuzCAKsBJGXumbqZIcMurjg4GkoKQ=;\n\tb=BMZ0nGOS1x9SntrZfq5t5Ia9adAWLiLe8aTJOQ2a3LNOt1lBjqslG4/Rar49EIfHPj\n\tKt7Mu2dq64Uoj/IkOF2nUQSchr+t8+DKXQEkzVEUWy+0J5Vp6A7BTKUSkzL9fHK4gKcj\n\t02j9tUIWLAaFuoVk017Lq+1wAz6yDBKo/pf5ov5+tVpvIx40EWB9zylHRSg/TfVOpm37\n\tMTt/GIs/HiE4ln2x9EB4EBJBWmdfR7vyozihVEzWbnu4U5VJ1TU5/h/Rr+UwhHuEpW0U\n\tW7R8R44WtlWX9VO6l1SG4KHXYNL6KJinOS3uZGZCakUqD8rfxs3XppIPYJavkiAus4O1\n\to+WA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=z7ftharsRbNjfdGuzCAKsBJGXumbqZIcMurjg4GkoKQ=;\n\tb=BJQHjJbBSg31WdOtFZTffdXPw9WFxzwjbFdTQFG0vkyvv+KiSP+8OwDllYa2ot8HQP\n\te9g4y3qpet16DHnQV6YDrIKs4fbjxgwlYhEteEshyQXxS4CRc2lBosMvWfEGus4jtZyh\n\tYwZ2k9Nl8Gn0gIgVfLQAwGrNKNGAbEyJytz3PMiw/dp3dksWKyJQwy4YwyG9SirWIWUz\n\tv+1QfJh5hAz9XgC1Y1kE6NrRNmp8PzAeRKC6h9sFF3jL947xRck9hW6Q0o0Z6qpa8UGR\n\tAVgQrDP7lQaXJVFcO+7xWq0E3VV7flWtizxxZxqiDJicAbWHdlU5G22hpCURnfS8RkDk\n\tgrUA==","X-Gm-Message-State":"AOAM532xPg8k86suBAP7PnCfuDuDfdiXEFeJZ5MfxdkqT5LtcmYE8fMr\n\t646dKCxA/au40wO0G2fnlGvhv7Pyfnxh8A==","X-Google-Smtp-Source":"ABdhPJwgPwRIZTFP30HgNJ6fNG50uDQfGFxrlw64c+cW+w5q10BEs/ym3pbcK5FaU/QKLBgOgxYgsA==","X-Received":"by 2002:a2e:8082:: with SMTP id\n\ti2mr12365119ljg.284.1605179371825; \n\tThu, 12 Nov 2020 03:09:31 -0800 (PST)","Date":"Thu, 12 Nov 2020 12:09:30 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20201112110930.GE1480295@oden.dyn.berto.se>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13764,"web_url":"https://patchwork.libcamera.org/comment/13764/","msgid":"<20201117164954.pwgrjxeicjeegrtj@uno.localdomain>","date":"2020-11-17T16:49:54","subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:51PM +0900, Paul Elder wrote:\n> Now that each pipeline handler has its own IPAProxy implementation, make\n> the IPAManager fetch the IPAProxy based on the pipeline handler name.\n> Also, since the IPAProxy is used regardless of isolation or no\n> isolation, remove the isolation check from the proxy selection.\n>\n> Signed-off-by: Paul Elder \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> No change in v2\n> ---\n> src/libcamera/ipa_manager.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index ad05b9c9..12cf3b0d 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -275,8 +275,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t *\n> \t * \\todo Implement a better proxy selection\n> \t */\n> -\tconst char *proxyName = self_->isSignatureValid(m)\n> -\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n> +\tstd::string pipeName(pipe->name());\n> +\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n> \tIPAProxyFactory *pf = nullptr;\n>\n> \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19618BE082\n\tfor ;\n\tTue, 17 Nov 2020 16:49:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E80C06331E;\n\tTue, 17 Nov 2020 17:49:52 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E08A26033B\n\tfor ;\n\tTue, 17 Nov 2020 17:49:51 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 86C0D240013;\n\tTue, 17 Nov 2020 16:49:51 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 17 Nov 2020 17:49:54 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117164954.pwgrjxeicjeegrtj@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13885,"web_url":"https://patchwork.libcamera.org/comment/13885/","msgid":"<20201125193434.GG26606@pendragon.ideasonboard.com>","date":"2020-11-25T19:34:34","subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:51PM +0900, Paul Elder wrote:\n> Now that each pipeline handler has its own IPAProxy implementation, make\n> the IPAManager fetch the IPAProxy based on the pipeline handler name.\n> Also, since the IPAProxy is used regardless of isolation or no\n> isolation, remove the isolation check from the proxy selection.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> src/libcamera/ipa_manager.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index ad05b9c9..12cf3b0d 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -275,8 +275,8 @@ std::unique_ptr IPAManager::createIPA(PipelineHandler *pipe,\n> \t *\n> \t * \\todo Implement a better proxy selection\n> \t */\n> -\tconst char *proxyName = self_->isSignatureValid(m)\n> -\t\t\t ? \"IPAProxyThread\" : \"IPAProxyLinux\";\n> +\tstd::string pipeName(pipe->name());\n> +\tconst char *proxyName = pipeName.replace(0, 15, \"IPAProxy\").c_str();\n\npipeName.replace() is a temporary object, .c_str() will return a pointer\nto memory that is then freed.\n\n> \tIPAProxyFactory *pf = nullptr;\n> \n> \tfor (IPAProxyFactory *factory : IPAProxyFactory::factories()) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 974CFBE08A\n\tfor ;\n\tWed, 25 Nov 2020 19:34:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F264E63414;\n\tWed, 25 Nov 2020 20:34:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2EC6363402\n\tfor ;\n\tWed, 25 Nov 2020 20:34:43 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1030292;\n\tWed, 25 Nov 2020 20:34:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wo9UItNZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606332882;\n\tbh=iEF4No1coAGSC17UPRCIcVQJ/RhxkwD1So5VPJQGAZg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wo9UItNZnWvL6Z60gAykrG2wcVYCbempHPNpFXCwdrEbUZZzuzxFPD6Coyb7CL3sd\n\t6IBztR/l8eMoihQgajo2YFor5hihKQOzxgR+vNA3Ec76xp++LO/9BDV6b1s83+YFWY\n\txfP1MP1YPTdQm05OdLPBtbBvzKEiGhGRQ3eaCgOE=","Date":"Wed, 25 Nov 2020 21:34:34 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125193434.GG26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-22-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-22-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 21/37] libcamera: IPAManager: Fetch\n\tIPAProxy corresponding to pipeline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]