[{"id":13759,"web_url":"https://patchwork.libcamera.org/comment/13759/","msgid":"<20201117162310.gpd4mspp3idrchaq@uno.localdomain>","date":"2020-11-17T16:23:10","subject":"Re: [libcamera-devel] [PATCH v4 19/37] libcamera: IPAInterface:\n\tmake ipaCreate return IPAInterface","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:49PM +0900, Paul Elder wrote:\n> With the new IPC infrastructure, we no longer need the C interface as\n> provided by struct ipa_context. Make ipaCreate return IPAinterface.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> No change in v2\n> ---\n> include/libcamera/ipa/ipa_interface.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 8d4264c3..f6c40dc6 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -50,4 +50,8 @@ public:\n>\n> } /* namespace libcamera */\n>\n> +extern \"C\" {\n\nIs this to protect against C++ names manglingl and be able to load the\nsymbol ?\n\nIn the case I got it right:\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> +libcamera::IPAInterface *ipaCreate();\n> +}\n> +\n> #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D691BE081\n\tfor ;\n\tTue, 17 Nov 2020 16:23:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EFC636331E;\n\tTue, 17 Nov 2020 17:23:14 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A35396033B\n\tfor ;\n\tTue, 17 Nov 2020 17:23:13 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 281A9100007;\n\tTue, 17 Nov 2020 16:23:12 +0000 (UTC)"],"Date":"Tue, 17 Nov 2020 17:23:10 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117162310.gpd4mspp3idrchaq@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-20-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-20-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 19/37] libcamera: IPAInterface:\n\tmake ipaCreate return IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13882,"web_url":"https://patchwork.libcamera.org/comment/13882/","msgid":"<20201125171037.GE26606@pendragon.ideasonboard.com>","date":"2020-11-25T17:10:37","subject":"Re: [libcamera-devel] [PATCH v4 19/37] libcamera: IPAInterface:\n\tmake ipaCreate return IPAInterface","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:49PM +0900, Paul Elder wrote:\n> With the new IPC infrastructure, we no longer need the C interface as\n> provided by struct ipa_context. Make ipaCreate return IPAinterface.\n> \n> Signed-off-by: Paul Elder \n\nI know it will all be squashed, but it would be easier to review the\npatches if the changes were not so fine-grained. Squashing this with the\nchange that removes ipaCreate(), as well as the corresponding\ndocumentation changes, would be more self-contained. As you'll need to\nsend a v5, *if* reworking this isn't too much work, it would be\nappreciated.\n\n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> include/libcamera/ipa/ipa_interface.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 8d4264c3..f6c40dc6 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -50,4 +50,8 @@ public:\n> \n> } /* namespace libcamera */\n> \n> +extern \"C\" {\n> +libcamera::IPAInterface *ipaCreate();\n> +}\n> +\n> #endif /* __LIBCAMERA_IPA_INTERFACE_H__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 397AABE176\n\tfor ;\n\tWed, 25 Nov 2020 17:10:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A83863412;\n\tWed, 25 Nov 2020 18:10:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25E6A63402\n\tfor ;\n\tWed, 25 Nov 2020 18:10:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93C91292;\n\tWed, 25 Nov 2020 18:10:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rxF6p4Xy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606324245;\n\tbh=mXZ0mio04rOIJHjpEvjHKRpsVk82TUKycygMokfomPU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rxF6p4Xy5bGn6jQ8AuZ6hxs8qLhQCEIaU50TpQNkKnXFflPIrRfqtsbjAxceqIsiG\n\t3JAZn3odJdH5cLOxvUpKfqoVSWXP68TacrSCL2w2MG7W+gtJSNhl9zU7RkcGNiALBx\n\tmkdAd8V200m8vZFm21yc6myPikevBiI+U5YI8x/o=","Date":"Wed, 25 Nov 2020 19:10:37 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125171037.GE26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-20-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-20-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 19/37] libcamera: IPAInterface:\n\tmake ipaCreate return IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]