[{"id":13681,"web_url":"https://patchwork.libcamera.org/comment/13681/","msgid":"<20201112105708.GC1480295@oden.dyn.berto.se>","date":"2020-11-12T10:57:08","subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2020-11-06 19:36:48 +0900, Paul Elder wrote:\n> Now that all the functions in the IPA interface are defined in the data\n> definition file and a specialized IPAInterface is generated per pipeline\n> handler, remove all the functions from the case IPAInterface.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> include/libcamera/ipa/ipa_interface.h | 16 ----------------\n> 1 file changed, 16 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 48766b22..8d4264c3 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -46,22 +46,6 @@ class IPAInterface\n> {\n> public:\n> \tvirtual ~IPAInterface() = default;\n> -\n> -\tvirtual int init(const IPASettings &settings) = 0;\n> -\tvirtual int start() = 0;\n> -\tvirtual void stop() = 0;\n> -\n> -\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n> -\t\t\t const std::map &streamConfig,\n> -\t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result) = 0;\n> -\n> -\tvirtual void mapBuffers(const std::vector &buffers) = 0;\n> -\tvirtual void unmapBuffers(const std::vector &ids) = 0;\n> -\n> -\tvirtual void processEvent(const IPAOperationData &data) = 0;\n> -\tSignal queueFrameAction;\n> };\n> \n> } /* namespace libcamera */\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11C25BDB89\n\tfor ;\n\tThu, 12 Nov 2020 10:57:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D401663162;\n\tThu, 12 Nov 2020 11:57:11 +0100 (CET)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1F9963137\n\tfor ;\n\tThu, 12 Nov 2020 11:57:10 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id s9so5553034ljo.11\n\tfor ;\n\tThu, 12 Nov 2020 02:57:10 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tm2sm521101lfo.194.2020.11.12.02.57.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Nov 2020 02:57:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"PQosA4my\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=RXe+g3mduscmBsOyNZTZwJc4hYCNXVL7guk+mXG00Zo=;\n\tb=PQosA4myXFS3qP4nhaGLOz84DVwWVCpfR0KeWklZyUDovsojkfW8i9VKjjTT7xFkix\n\twVsOrEsTLqIGuHuKcySBTwKDXtO5mPDsilmf5eLyDX6AHMwnx+1WkauqToHe2b7V3tcS\n\t6MYBtKJCiGUrlxmarilfeQaSmXblksJf27BXNdrggKzopx20dgsQu2dOr8jucnct6+Dy\n\tHMzjaSa7LdSBLBujl4oXjAdctqk+2GNyUksKhQ0U7FNO3p5+3l9pzgjzWZ/Mow4zck54\n\tJL8erqhuxD7WT1UQGXrYkv9A/l8GcGw32pme69EKfiVWREmJJUcxDa6oe0kE70fXH+xh\n\ttRAg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=RXe+g3mduscmBsOyNZTZwJc4hYCNXVL7guk+mXG00Zo=;\n\tb=UK0EM+2TiAsg+8V8ZjdUD/UOsxNYFm74xXYZrNN0Bv6QpZhIEVEHR28/1+KuS0+pJp\n\tiDhwB6DBieVjc9NAYDV61GguwEU208uzYJU7kgQ0KvICzYrcqBiPhV4j2gqilDXxnI13\n\tZVkl8H+RNlYUKSFdJr1WGSI+cO+LXmin4u/SS++bhXCc3Vki5aPn5pLd0SGS2OHPW4OD\n\trTc+h5m9KTIM7Swi5SjkyEHuaRQbjhLlDRW/ApAZeB6iyCHZrMQAXrpTl13b7SJ1JWr2\n\tRL2Qc8Twneg35qgO3oC2iNxW53Gu1Fc8c4RoW9QBdUxKBcFMCSQ1Pbqj6dwN73KNNink\n\tySbA==","X-Gm-Message-State":"AOAM532CzxD8AUMeqFUqHwDLctioSM6ySeVIr4Ck8jY80PuB7hYIpN9B\n\tzg6Rquzm+agzwpXr303UuxOTlQ==","X-Google-Smtp-Source":"ABdhPJy0QsNriQ8d0PWGk3uexEkwCvRpBxXpKOugLyvCqUdMamuAouVSJQxbFesLPyjcOF0u1gx1Zw==","X-Received":"by 2002:a2e:9dcd:: with SMTP id x13mr780193ljj.329.1605178630139;\n\tThu, 12 Nov 2020 02:57:10 -0800 (PST)","Date":"Thu, 12 Nov 2020 11:57:08 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"<20201112105708.GC1480295@oden.dyn.berto.se>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-19-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-19-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13758,"web_url":"https://patchwork.libcamera.org/comment/13758/","msgid":"<20201117161955.bz52uj7bgoedrpll@uno.localdomain>","date":"2020-11-17T16:19:55","subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:48PM +0900, Paul Elder wrote:\n> Now that all the functions in the IPA interface are defined in the data\n> definition file and a specialized IPAInterface is generated per pipeline\n> handler, remove all the functions from the case IPAInterface.\n>\n> Signed-off-by: Paul Elder \n>\n\nI wonder if all cleanups could be done at the end of the series after\nall pipelines/IPAs have been converted.\n\nAnyway\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> No change in v2\n> ---\n> include/libcamera/ipa/ipa_interface.h | 16 ----------------\n> 1 file changed, 16 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 48766b22..8d4264c3 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -46,22 +46,6 @@ class IPAInterface\n> {\n> public:\n> \tvirtual ~IPAInterface() = default;\n> -\n> -\tvirtual int init(const IPASettings &settings) = 0;\n> -\tvirtual int start() = 0;\n> -\tvirtual void stop() = 0;\n> -\n> -\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n> -\t\t\t const std::map &streamConfig,\n> -\t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result) = 0;\n> -\n> -\tvirtual void mapBuffers(const std::vector &buffers) = 0;\n> -\tvirtual void unmapBuffers(const std::vector &ids) = 0;\n> -\n> -\tvirtual void processEvent(const IPAOperationData &data) = 0;\n> -\tSignal queueFrameAction;\n> };\n>\n> } /* namespace libcamera */\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A0CCBE082\n\tfor ;\n\tTue, 17 Nov 2020 16:19:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73EE96331E;\n\tTue, 17 Nov 2020 17:19:55 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C33C26033B\n\tfor ;\n\tTue, 17 Nov 2020 17:19:54 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 4DE8F1C0005;\n\tTue, 17 Nov 2020 16:19:53 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 17 Nov 2020 17:19:55 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117161955.bz52uj7bgoedrpll@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-19-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-19-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13881,"web_url":"https://patchwork.libcamera.org/comment/13881/","msgid":"<20201125165928.GD26606@pendragon.ideasonboard.com>","date":"2020-11-25T16:59:28","subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:48PM +0900, Paul Elder wrote:\n> Now that all the functions in the IPA interface are defined in the data\n> definition file and a specialized IPAInterface is generated per pipeline\n> handler, remove all the functions from the case IPAInterface.\n\ns/case/base/\n\n> Signed-off-by: Paul Elder \n\nCan you squash this with the part of 20/37 that remove the documentation\nfor the IPAInterface functions ?\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> No change in v4\n> \n> No change in v3\n> \n> No change in v2\n> ---\n> include/libcamera/ipa/ipa_interface.h | 16 ----------------\n> 1 file changed, 16 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 48766b22..8d4264c3 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -46,22 +46,6 @@ class IPAInterface\n> {\n> public:\n> \tvirtual ~IPAInterface() = default;\n> -\n> -\tvirtual int init(const IPASettings &settings) = 0;\n> -\tvirtual int start() = 0;\n> -\tvirtual void stop() = 0;\n> -\n> -\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n> -\t\t\t const std::map &streamConfig,\n> -\t\t\t const std::map &entityControls,\n> -\t\t\t const IPAOperationData &ipaConfig,\n> -\t\t\t IPAOperationData *result) = 0;\n> -\n> -\tvirtual void mapBuffers(const std::vector &buffers) = 0;\n> -\tvirtual void unmapBuffers(const std::vector &ids) = 0;\n> -\n> -\tvirtual void processEvent(const IPAOperationData &data) = 0;\n> -\tSignal queueFrameAction;\n> };\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF596BE08A\n\tfor ;\n\tWed, 25 Nov 2020 16:59:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5907163412;\n\tWed, 25 Nov 2020 17:59:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8234463402\n\tfor ;\n\tWed, 25 Nov 2020 17:59:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE7D3292;\n\tWed, 25 Nov 2020 17:59:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CwXiOueo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606323577;\n\tbh=tTOyuY5gkj57lWCX0pwuxEIrPUSJ+i86eR05TgwqAqQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CwXiOueoYzbBA7fnNZK8FJaJpb2PBCGZeYKHBPqwJ3KDNFrCgDV5P5nUHz0cOJu4l\n\tCq9HSVgy69CsQwNYKLey6Y9cZNzOfG3LUE0h3ZWrHj6R5uHt4xCq+PI6SbPLAMIK9x\n\te8EQuYL+AGcTMt8Ohe0rXHBsJzLOlw1+COYyI8nM=","Date":"Wed, 25 Nov 2020 18:59:28 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125165928.GD26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-19-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-19-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface:\n\tRemove all functions from IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]