{"id":10366,"url":"https://patchwork.libcamera.org/api/patches/10366/?format=json","web_url":"https://patchwork.libcamera.org/patch/10366/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201106103707.49660-19-paul.elder@ideasonboard.com>","date":"2020-11-06T10:36:48","name":"[libcamera-devel,v4,18/37] libcamera: IPAInterface: Remove all functions from IPAInterface","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1b8a2baf02b06cab64401f126e6c9ecef66a4ba1","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10366/mbox/","series":[{"id":1448,"url":"https://patchwork.libcamera.org/api/series/1448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1448","date":"2020-11-06T10:36:30","name":"IPA isolation implementation","version":4,"mbox":"https://patchwork.libcamera.org/series/1448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10366/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10366/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19ABDBE084\n\tfor ;\n\tFri, 6 Nov 2020 10:38:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D71AD62D3B;\n\tFri, 6 Nov 2020 11:38:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4003662D20\n\tfor ;\n\tFri, 6 Nov 2020 11:38:01 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFC91B16;\n\tFri, 6 Nov 2020 11:37:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eEYPXTi5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659081;\n\tbh=sHaKSCmPjm/IALGbig4OG9yHaePov6ENnfjdG/TzO4I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=eEYPXTi5t8287lQ3E1cyvimHE2K1IXY0lL4b7p2W3f31mTXgLqkQnY6B8q0CViRyj\n\tN3IeqYmjzG12ZipI9dx1bFpY9rIrUt3I+jdcEDJZUaDVourXSGKRNB8Y6cj5RgQZCJ\n\t6GhjqHalOjmxw7n43fnDx8jsJBfNC61kV/ywx3gg=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Nov 2020 19:36:48 +0900","Message-Id":"<20201106103707.49660-19-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 18/37] libcamera: IPAInterface: Remove\n\tall functions from IPAInterface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that all the functions in the IPA interface are defined in the data\ndefinition file and a specialized IPAInterface is generated per pipeline\nhandler, remove all the functions from the case IPAInterface.\n\nSigned-off-by: Paul Elder \n\n---\nNo change in v4\n\nNo change in v3\n\nNo change in v2\n---\n include/libcamera/ipa/ipa_interface.h | 16 ----------------\n 1 file changed, 16 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 48766b22..8d4264c3 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -46,22 +46,6 @@ class IPAInterface\n {\n public:\n \tvirtual ~IPAInterface() = default;\n-\n-\tvirtual int init(const IPASettings &settings) = 0;\n-\tvirtual int start() = 0;\n-\tvirtual void stop() = 0;\n-\n-\tvirtual void configure(const CameraSensorInfo &sensorInfo,\n-\t\t\t const std::map &streamConfig,\n-\t\t\t const std::map &entityControls,\n-\t\t\t const IPAOperationData &ipaConfig,\n-\t\t\t IPAOperationData *result) = 0;\n-\n-\tvirtual void mapBuffers(const std::vector &buffers) = 0;\n-\tvirtual void unmapBuffers(const std::vector &ids) = 0;\n-\n-\tvirtual void processEvent(const IPAOperationData &data) = 0;\n-\tSignal queueFrameAction;\n };\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v4","18/37"]}