[{"id":13756,"web_url":"https://patchwork.libcamera.org/comment/13756/","msgid":"<20201117161207.mxrmsrl65uxem6rl@uno.localdomain>","date":"2020-11-17T16:12:07","subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:47PM +0900, Paul Elder wrote:\n> Since pipline handlers now have their own IPA interface types, it can no\n> longer be defined in the base class, and each pipline handler\n> implementation must declare it and its type themselves. Remove it from\n> the base class.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n\nnice!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> Changes in v2:\n> - remove documentation\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> src/libcamera/pipeline_handler.cpp | 8 --------\n> 2 files changed, 9 deletions(-)\n>\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index c12c8904..57ad3052 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -47,7 +47,6 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n>\n> private:\n> \tCameraData(const CameraData &) = delete;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 894200ee..b893b0e7 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -106,14 +106,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * when creating the camera, and shall not be modified afterwards.\n> */\n>\n> -/**\n> - * \\var CameraData::ipa_\n> - * \\brief The IPA module used by the camera\n> - *\n> - * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n> - * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n> - */\n> -\n> /**\n> * \\class PipelineHandler\n> * \\brief Create and manage cameras based on a set of media devices\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A7FFBE081\n\tfor ;\n\tTue, 17 Nov 2020 16:12:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 391D56331E;\n\tTue, 17 Nov 2020 17:12:12 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5356A6033B\n\tfor ;\n\tTue, 17 Nov 2020 17:12:11 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id CA1DA1BF209;\n\tTue, 17 Nov 2020 16:12:10 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 17 Nov 2020 17:12:07 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117161207.mxrmsrl65uxem6rl@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-18-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-18-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13757,"web_url":"https://patchwork.libcamera.org/comment/13757/","msgid":"<20201117161859.2gbol4dfyzmzzqid@uno.localdomain>","date":"2020-11-17T16:18:59","subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:47PM +0900, Paul Elder wrote:\n> Since pipline handlers now have their own IPA interface types, it can no\n> longer be defined in the base class, and each pipline handler\n> implementation must declare it and its type themselves. Remove it from\n> the base class.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n>\n\nThis patch in isolation will break compilation, but I don't think\nthere's many ways around it\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> Changes in v2:\n> - remove documentation\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> src/libcamera/pipeline_handler.cpp | 8 --------\n> 2 files changed, 9 deletions(-)\n>\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index c12c8904..57ad3052 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -47,7 +47,6 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n>\n> private:\n> \tCameraData(const CameraData &) = delete;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 894200ee..b893b0e7 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -106,14 +106,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * when creating the camera, and shall not be modified afterwards.\n> */\n>\n> -/**\n> - * \\var CameraData::ipa_\n> - * \\brief The IPA module used by the camera\n> - *\n> - * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n> - * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n> - */\n> -\n> /**\n> * \\class PipelineHandler\n> * \\brief Create and manage cameras based on a set of media devices\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6214BBE082\n\tfor ;\n\tTue, 17 Nov 2020 16:19:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D70496331E;\n\tTue, 17 Nov 2020 17:18:59 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FBCB6033B\n\tfor ;\n\tTue, 17 Nov 2020 17:18:58 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 95C20100017;\n\tTue, 17 Nov 2020 16:18:56 +0000 (UTC)"],"Date":"Tue, 17 Nov 2020 17:18:59 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117161859.2gbol4dfyzmzzqid@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-18-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-18-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13880,"web_url":"https://patchwork.libcamera.org/comment/13880/","msgid":"<20201125153623.GC26606@pendragon.ideasonboard.com>","date":"2020-11-25T15:36:23","subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:47PM +0900, Paul Elder wrote:\n> Since pipline handlers now have their own IPA interface types, it can no\n\ns/pipline/pipeline/\n\n> longer be defined in the base class, and each pipline handler\n\nHere too.\n\n> implementation must declare it and its type themselves. Remove it from\n> the base class.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> No change in v4\n> \n> No change in v3\n> \n> Changes in v2:\n> - remove documentation\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 -\n> src/libcamera/pipeline_handler.cpp | 8 --------\n> 2 files changed, 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index c12c8904..57ad3052 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -47,7 +47,6 @@ public:\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> \tControlList properties_;\n> -\tstd::unique_ptr ipa_;\n> \n> private:\n> \tCameraData(const CameraData &) = delete;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 894200ee..b893b0e7 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -106,14 +106,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n> * when creating the camera, and shall not be modified afterwards.\n> */\n> \n> -/**\n> - * \\var CameraData::ipa_\n> - * \\brief The IPA module used by the camera\n> - *\n> - * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n> - * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n> - */\n> -\n> /**\n> * \\class PipelineHandler\n> * \\brief Create and manage cameras based on a set of media devices","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BD9DBE176\n\tfor ;\n\tWed, 25 Nov 2020 15:36:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAC2063410;\n\tWed, 25 Nov 2020 16:36:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6189863402\n\tfor ;\n\tWed, 25 Nov 2020 16:36:31 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF626292;\n\tWed, 25 Nov 2020 16:36:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FGAc0QA0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606318591;\n\tbh=UajxIuKIRz3X5T78ytj6FCmLwPigtGv5qJJBUr8ewsw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FGAc0QA09oKk/nmHowxg4rJxkF6Joa8/PWm08WLljhif4F80cy1DrIYVXI490tvxx\n\tor8nFpd1oQPB/NiS3rb1GSwRneOwQTj1/Ui4LbuIpA2jU1onpR8KVlndBGY0QiXAh5\n\tQp2LmjU4eFl4XE7GcKFTBCJbNsxOEO/YmVo0f3vU=","Date":"Wed, 25 Nov 2020 17:36:23 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125153623.GC26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-18-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-18-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 17/37] libcamera: PipelineHandler:\n\tRemove IPA from base class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]