[{"id":13755,"web_url":"https://patchwork.libcamera.org/comment/13755/","msgid":"<20201117160939.cdj5nv55tefn4qmi@uno.localdomain>","date":"2020-11-17T16:09:39","subject":"Re: [libcamera-devel] [PATCH v4 15/37] libcamera: IPAProxy: Remove\n\tstop() override","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Fri, Nov 06, 2020 at 07:36:45PM +0900, Paul Elder wrote:\n> Since stop() is part of the IPA interface, and the IPA interface is now\n> generated based on the data definition file per pipeline, this no longer\n> needs to be overrided by the base IPAProxy. Remove it.\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> No change in v4\n>\n> No change in v3\n>\n> Changes in v2:\n> - remove documentation\n> ---\n> include/libcamera/internal/ipa_proxy.h | 2 --\n> src/libcamera/ipa_proxy.cpp | 10 ----------\n> 2 files changed, 12 deletions(-)\n>\n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index 49399f4e..59a5b841 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -27,8 +27,6 @@ public:\n>\n> \tstd::string configurationFile(const std::string &file) const;\n>\n> -\tvoid stop() override = 0;\n> -\n> protected:\n> \tstd::string resolvePath(const std::string &file) const;\n>\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index ff4d7fd1..23be24ad 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n> \treturn std::string();\n> }\n>\n> -/**\n> - * \\fn IPAProxy::stop()\n> - * \\brief Stop the IPA proxy\n> - *\n> - * This function stops the IPA and releases all the resources acquired by the\n> - * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n> - * has already been stopped is valid, the proxy shall treat this as a no-op and\n> - * shall not forward the call to the IPA.\n> - */\n> -\n> /**\n> * \\brief Find a valid full path for a proxy worker for a given executable name\n> * \\param[in] file File name of proxy worker executable\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8B29BE082\n\tfor ;\n\tTue, 17 Nov 2020 16:09:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C180463322;\n\tTue, 17 Nov 2020 17:09:38 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 926A16033B\n\tfor ;\n\tTue, 17 Nov 2020 17:09:37 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 214AAC0003;\n\tTue, 17 Nov 2020 16:09:36 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 17 Nov 2020 17:09:39 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20201117160939.cdj5nv55tefn4qmi@uno.localdomain>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-16-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-16-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 15/37] libcamera: IPAProxy: Remove\n\tstop() override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13878,"web_url":"https://patchwork.libcamera.org/comment/13878/","msgid":"<20201125144009.GA26606@pendragon.ideasonboard.com>","date":"2020-11-25T14:40:09","subject":"Re: [libcamera-devel] [PATCH v4 15/37] libcamera: IPAProxy: Remove\n\tstop() override","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Nov 06, 2020 at 07:36:45PM +0900, Paul Elder wrote:\n> Since stop() is part of the IPA interface, and the IPA interface is now\n> generated based on the data definition file per pipeline, this no longer\n> needs to be overrided by the base IPAProxy. Remove it.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> No change in v4\n> \n> No change in v3\n> \n> Changes in v2:\n> - remove documentation\n> ---\n> include/libcamera/internal/ipa_proxy.h | 2 --\n> src/libcamera/ipa_proxy.cpp | 10 ----------\n> 2 files changed, 12 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index 49399f4e..59a5b841 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -27,8 +27,6 @@ public:\n> \n> \tstd::string configurationFile(const std::string &file) const;\n> \n> -\tvoid stop() override = 0;\n> -\n> protected:\n> \tstd::string resolvePath(const std::string &file) const;\n> \n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index ff4d7fd1..23be24ad 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -145,16 +145,6 @@ std::string IPAProxy::configurationFile(const std::string &name) const\n> \treturn std::string();\n> }\n> \n> -/**\n> - * \\fn IPAProxy::stop()\n> - * \\brief Stop the IPA proxy\n> - *\n> - * This function stops the IPA and releases all the resources acquired by the\n> - * proxy in start(). Calling stop() when the IPA proxy hasn't been started or\n> - * has already been stopped is valid, the proxy shall treat this as a no-op and\n> - * shall not forward the call to the IPA.\n> - */\n> -\n> /**\n> * \\brief Find a valid full path for a proxy worker for a given executable name\n> * \\param[in] file File name of proxy worker executable","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A0FABE176\n\tfor ;\n\tWed, 25 Nov 2020 14:40:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2D3263412;\n\tWed, 25 Nov 2020 15:40:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C08563402\n\tfor ;\n\tWed, 25 Nov 2020 15:40:18 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A2D91292;\n\tWed, 25 Nov 2020 15:40:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ivr2bgc+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606315217;\n\tbh=f5dWTUrYoAem0GTVt7I1X+Rt/SKykjfYNxzz7Qrgl8A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ivr2bgc+3z2LGptXa0/z5H2grZanH23F4tARFfnv3uUo3BduaBATZH7S2qNZZGyOO\n\tzjAweAMex2TbvJ7a7HULTpHLUWrkFbUpWXCpj9frWNRQ1FwgB2bCy9MMdn4bePEUIC\n\tI5hCV4/xreibHuPMfeXsaYoWMg+DIyBY1tX1SBFA=","Date":"Wed, 25 Nov 2020 16:40:09 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201125144009.GA26606@pendragon.ideasonboard.com>","References":"<20201106103707.49660-1-paul.elder@ideasonboard.com>\n\t<20201106103707.49660-16-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201106103707.49660-16-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 15/37] libcamera: IPAProxy: Remove\n\tstop() override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]