[{"id":13612,"web_url":"https://patchwork.libcamera.org/comment/13612/","msgid":"<049a39e3-6a71-db0e-df64-7ee6a5b7c637@ideasonboard.com>","date":"2020-11-05T11:39:19","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 05/11/2020 00:15, Niklas Söderlund wrote:\n> Propagate the frameStart event whenever the CSI-2 receiver in the CIO2\n> pipeline generates one.\n> \n\nI kinda like how these signals are quite flexible.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 18 +++++++++++++++---\n> src/libcamera/pipeline/ipu3/cio2.h | 3 ++-\n> 2 files changed, 17 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 1c7b9676f52abdb6..1eca674da339b8e0 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -247,15 +247,27 @@ int CIO2Device::start()\n> \t\tavailableBuffers_.push(buffer.get());\n> \n> \tret = output_->streamOn();\n> -\tif (ret)\n> +\tif (ret) {\n> \t\tfreeBuffers();\n> +\t\treturn ret;\n> +\t}\n> \n> -\treturn ret;\n> +\tret = csi2_->setFrameStartEnabled(true);\n> +\tif (ret) {\n> +\t\tstop();\n> +\t\treturn ret;\n> +\t}\n> +\n> +\treturn 0;\n> }\n> \n> int CIO2Device::stop()\n> {\n> -\tint ret = output_->streamOff();\n> +\tint ret;\n> +\n> +\tcsi2_->setFrameStartEnabled(false);\n> +\n> +\tret = output_->streamOff();\n> \n> \tfreeBuffers();\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index e8b491a0c104a3e2..67fede4e3b4e9fb6 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -13,6 +13,7 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> namespace libcamera {\n> @@ -24,7 +25,6 @@ class PixelFormat;\n> class Request;\n> class Size;\n> class SizeRange;\n> -class V4L2Subdevice;\n> struct StreamConfiguration;\n> \n> class CIO2Device\n> @@ -56,6 +56,7 @@ public:\n> \tvoid tryReturnBuffer(FrameBuffer *buffer);\n> \tSignal &bufferReady() { return output_->bufferReady; }\n> \n> +\tSignal &frameStart() { return csi2_->frameStart; }\n> private:\n> \tvoid freeBuffers();\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A13D5BDB89\n\tfor ;\n\tThu, 5 Nov 2020 11:39:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32FFB62CAF;\n\tThu, 5 Nov 2020 12:39:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E31362C7D\n\tfor ;\n\tThu, 5 Nov 2020 12:39:22 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0779C51D;\n\tThu, 5 Nov 2020 12:39:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CXTvNmXv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604576362;\n\tbh=qtMJ0kjDWn9EoRFXZXf7OsxdJLsfQhkKS3oQ+gVRyQQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=CXTvNmXvrmR2+ZabtZwLg14LvY3y0nYmorrhoFwnQABNHLj77T9r5fExhweCKHkap\n\tAd3gzF8h33qkrAYrnJI2zHbKEJ7kDSpVNXY58NaDpRdxRJEKrM78BhM0BZG92aWP/3\n\tR4uLgHmm8Ys5kiXzLUelRd1dphWgzRECfvIyEpV0=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-7-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<049a39e3-6a71-db0e-df64-7ee6a5b7c637@ideasonboard.com>","Date":"Thu, 5 Nov 2020 11:39:19 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201105001546.1690179-7-niklas.soderlund@ragnatech.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13640,"web_url":"https://patchwork.libcamera.org/comment/13640/","msgid":"<20201109111302.d474oznnrsjmpkae@uno.localdomain>","date":"2020-11-09T11:13:02","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Nov 05, 2020 at 01:15:41AM +0100, Niklas Söderlund wrote:\n> Propagate the frameStart event whenever the CSI-2 receiver in the CIO2\n> pipeline generates one.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 18 +++++++++++++++---\n> src/libcamera/pipeline/ipu3/cio2.h | 3 ++-\n> 2 files changed, 17 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 1c7b9676f52abdb6..1eca674da339b8e0 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -247,15 +247,27 @@ int CIO2Device::start()\n> \t\tavailableBuffers_.push(buffer.get());\n>\n> \tret = output_->streamOn();\n> -\tif (ret)\n> +\tif (ret) {\n> \t\tfreeBuffers();\n> +\t\treturn ret;\n> +\t}\n\nI wonder if we shouldn't just call stop() everywhere, as it seems to\nme calling streamoff() and setFrameStartEnabled(false) is a no-op if\nthe subdevice is not started and the signal not enabled. Minor detail\nthough.\n\n>\n> -\treturn ret;\n> +\tret = csi2_->setFrameStartEnabled(true);\n> +\tif (ret) {\n> +\t\tstop();\n> +\t\treturn ret;\n> +\t}\n> +\n> +\treturn 0;\n> }\n>\n> int CIO2Device::stop()\n> {\n> -\tint ret = output_->streamOff();\n> +\tint ret;\n> +\n> +\tcsi2_->setFrameStartEnabled(false);\n> +\n> +\tret = output_->streamOff();\n>\n> \tfreeBuffers();\n>\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index e8b491a0c104a3e2..67fede4e3b4e9fb6 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -13,6 +13,7 @@\n>\n> #include \n>\n> +#include \"libcamera/internal/v4l2_subdevice.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n>\n> namespace libcamera {\n> @@ -24,7 +25,6 @@ class PixelFormat;\n> class Request;\n> class Size;\n> class SizeRange;\n> -class V4L2Subdevice;\n> struct StreamConfiguration;\n>\n> class CIO2Device\n> @@ -56,6 +56,7 @@ public:\n> \tvoid tryReturnBuffer(FrameBuffer *buffer);\n> \tSignal &bufferReady() { return output_->bufferReady; }\n>\n> +\tSignal &frameStart() { return csi2_->frameStart; }\n\nPlease move this one line up and keep one empty line before private:\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> private:\n> \tvoid freeBuffers();\n>\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66BE9BE082\n\tfor ;\n\tMon, 9 Nov 2020 11:13:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA76C6306B;\n\tMon, 9 Nov 2020 12:13:01 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96D9563066\n\tfor ;\n\tMon, 9 Nov 2020 12:13:00 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 250DC24001F;\n\tMon, 9 Nov 2020 11:12:59 +0000 (UTC)"],"Date":"Mon, 9 Nov 2020 12:13:02 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201109111302.d474oznnrsjmpkae@uno.localdomain>","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201105001546.1690179-7-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14114,"web_url":"https://patchwork.libcamera.org/comment/14114/","msgid":"","date":"2020-12-08T01:58:23","subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Nov 09, 2020 at 12:13:02PM +0100, Jacopo Mondi wrote:\n> On Thu, Nov 05, 2020 at 01:15:41AM +0100, Niklas Söderlund wrote:\n> > Propagate the frameStart event whenever the CSI-2 receiver in the CIO2\n> > pipeline generates one.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/ipu3/cio2.cpp | 18 +++++++++++++++---\n> > src/libcamera/pipeline/ipu3/cio2.h | 3 ++-\n> > 2 files changed, 17 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > index 1c7b9676f52abdb6..1eca674da339b8e0 100644\n> > --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> > @@ -247,15 +247,27 @@ int CIO2Device::start()\n> > \t\tavailableBuffers_.push(buffer.get());\n> >\n> > \tret = output_->streamOn();\n> > -\tif (ret)\n> > +\tif (ret) {\n> > \t\tfreeBuffers();\n> > +\t\treturn ret;\n> > +\t}\n> \n> I wonder if we shouldn't just call stop() everywhere, as it seems to\n> me calling streamoff() and setFrameStartEnabled(false) is a no-op if\n> the subdevice is not started and the signal not enabled. Minor detail\n> though.\n\nThat would be a bit cleaner indeed, if possible.\n\n> > -\treturn ret;\n> > +\tret = csi2_->setFrameStartEnabled(true);\n> > +\tif (ret) {\n> > +\t\tstop();\n> > +\t\treturn ret;\n> > +\t}\n> > +\n> > +\treturn 0;\n> > }\n> >\n> > int CIO2Device::stop()\n> > {\n> > -\tint ret = output_->streamOff();\n> > +\tint ret;\n> > +\n> > +\tcsi2_->setFrameStartEnabled(false);\n> > +\n> > +\tret = output_->streamOff();\n> >\n> > \tfreeBuffers();\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> > index e8b491a0c104a3e2..67fede4e3b4e9fb6 100644\n> > --- a/src/libcamera/pipeline/ipu3/cio2.h\n> > +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> > @@ -13,6 +13,7 @@\n> >\n> > #include \n> >\n> > +#include \"libcamera/internal/v4l2_subdevice.h\"\n> > #include \"libcamera/internal/v4l2_videodevice.h\"\n> >\n> > namespace libcamera {\n> > @@ -24,7 +25,6 @@ class PixelFormat;\n> > class Request;\n> > class Size;\n> > class SizeRange;\n> > -class V4L2Subdevice;\n> > struct StreamConfiguration;\n> >\n> > class CIO2Device\n> > @@ -56,6 +56,7 @@ public:\n> > \tvoid tryReturnBuffer(FrameBuffer *buffer);\n> > \tSignal &bufferReady() { return output_->bufferReady; }\n> >\n> > +\tSignal &frameStart() { return csi2_->frameStart; }\n> \n> Please move this one line up and keep one empty line before private:\n> \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> > private:\n> > \tvoid freeBuffers();\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBFEFBDB20\n\tfor ;\n\tTue, 8 Dec 2020 01:58:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CE9C67E6E;\n\tTue, 8 Dec 2020 02:58:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 656FF60323\n\tfor ;\n\tTue, 8 Dec 2020 02:58:27 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4F38DD;\n\tTue, 8 Dec 2020 02:58:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"syN8Wy/u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607392707;\n\tbh=KbgG8bYFk1DLt4ZvY3mcSeQcAxU3crWvYBk+cY+QVDk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=syN8Wy/ufID8dcTQG9i2/722xNtOC8A5QjMw8hr1MFn1ucrzD6UDVL+18d/XlO/Nr\n\ti967DmjTPHB0TmrpOZfeSFhOQC7zMw208xVj1iTJQb9rpcMd8YRdMwL2McFXJR6zzz\n\t0ezQ1jr75cGu7moNWkA6yijc9NmZ0yomZlS/G/w4=","Date":"Tue, 8 Dec 2020 03:58:23 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-7-niklas.soderlund@ragnatech.se>\n\t<20201109111302.d474oznnrsjmpkae@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201109111302.d474oznnrsjmpkae@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 06/11] libcamera: ipu3: cio2: Generate\n\tstart of frame event","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]