[{"id":13610,"web_url":"https://patchwork.libcamera.org/comment/13610/","msgid":"","date":"2020-11-05T11:30:25","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 05/11/2020 00:15, Niklas Söderlund wrote:\n> There is no reason to expose and call a separate configureStat() when\n> the statistics video device can be configured with the exact same\n> parameters as part of configure(). Move the configuration internally to\n> the ImgUDevice simplifying the interface, there is no functional change.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 7 +++++++\n> src/libcamera/pipeline/ipu3/imgu.h | 7 -------\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 11 -----------\n> 3 files changed, 7 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index a4d74a62f69a0c97..0a3bf62020fd23fb 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -477,6 +477,13 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n> \n> \tLOG(IPU3, Debug) << \"ImgU GDC format = \" << gdcFormat.toString();\n> \n> +\tStreamConfiguration statCfg = {};\n> +\tstatCfg.size = inputFormat->size;\n> +\tV4L2DeviceFormat statFormat;\n> +\tret = configureVideoDevice(stat_.get(), PAD_STAT, statCfg, &statFormat);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n\nShouldn't you do something with statCfg or statFormat?\nHrm ... maybe this happens later ...\n\n\n> \treturn 0;\n> }\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index c73ac5a5a37cfe0e..37f5ae77c99ff8fe 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -61,13 +61,6 @@ public:\n> \t\t\t\t\t outputFormat);\n> \t}\n> \n> -\tint configureStat(const StreamConfiguration &cfg,\n> -\t\t\t V4L2DeviceFormat *outputFormat)\n> -\t{\n> -\t\treturn configureVideoDevice(stat_.get(), PAD_STAT, cfg,\n> -\t\t\t\t\t outputFormat);> -\t}\n> -\n> \tint allocateBuffers(unsigned int bufferCount);\n> \tvoid freeBuffers();\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 3f0232bc1eaad048..c559d160084f87e7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -518,17 +518,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\treturn ret;\n> \t}\n> \n> -\t/*\n> -\t * Apply the largest available format to the stat node.\n> -\t * \\todo Revise this when we'll actually use the stat node.\n> -\t */\n> -\tStreamConfiguration statCfg = {};\n> -\tstatCfg.size = cio2Format.size;\n> -\n> -\tret = imgu->configureStat(statCfg, &outputFormat);\n\nwas outputFormat ignored/unused before ? perhaps it was...\n\nOk - Given that this is just about the code move, and I think this is\nunused here, that explains why this commit doesn't 'use' the statCfg or\nstatFormat above - so:\n\nReviewed-by: Kieran Bingham \n\n\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> \tControlList ctrls(imgu->imgu_->controls());\n> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 051EDBDB89\n\tfor ;\n\tThu, 5 Nov 2020 11:30:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C77B762C7D;\n\tThu, 5 Nov 2020 12:30:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3631D60353\n\tfor ;\n\tThu, 5 Nov 2020 12:30:28 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF0B83D;\n\tThu, 5 Nov 2020 12:30:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gs95nGw0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604575827;\n\tbh=QoACKmne69a3VFS2ysEXsUXmOFJcGQzcKq36Gg+jLJA=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=gs95nGw0tt0iGTBrmddscDg6AESwwXhC0h7S7+L/jysoURaCpqvJjcWhSmIo+iZ/N\n\trCwq5Fn8fCjCKDnVIx/EkLxfeaizX7mLur663SXeEgZwzml16ozSfcmmkoARIey/dQ\n\thjUtf5ac7IrhigWcTbkh26g/l5RJ16GekgFnclmk=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-4-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 5 Nov 2020 11:30:25 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201105001546.1690179-4-niklas.soderlund@ragnatech.se>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13636,"web_url":"https://patchwork.libcamera.org/comment/13636/","msgid":"<20201109101850.txsrpdl5co3ylbvb@uno.localdomain>","date":"2020-11-09T10:18:50","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Nov 05, 2020 at 01:15:38AM +0100, Niklas Söderlund wrote:\n> There is no reason to expose and call a separate configureStat() when\n> the statistics video device can be configured with the exact same\n> parameters as part of configure(). Move the configuration internally to\n> the ImgUDevice simplifying the interface, there is no functional change.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 7 +++++++\n> src/libcamera/pipeline/ipu3/imgu.h | 7 -------\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 11 -----------\n> 3 files changed, 7 insertions(+), 18 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index a4d74a62f69a0c97..0a3bf62020fd23fb 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -477,6 +477,13 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n>\n> \tLOG(IPU3, Debug) << \"ImgU GDC format = \" << gdcFormat.toString();\n>\n> +\tStreamConfiguration statCfg = {};\n> +\tstatCfg.size = inputFormat->size;\n> +\tV4L2DeviceFormat statFormat;\n> +\tret = configureVideoDevice(stat_.get(), PAD_STAT, statCfg, &statFormat);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n\nThis was in the same call path before, but just to make sure, I read\nin ImgUDevice::configureVideoDevice():\n\n\t/* No need to apply format to the stat node. */\n\tif (dev == stat_.get())\n\t\treturn 0;\n\nNo size need to be configured on the stat video device, but only on\nthe ImgU stat source pad ?\n\nThanks\n j\n\n> \treturn 0;\n> }\n>\n> diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> index c73ac5a5a37cfe0e..37f5ae77c99ff8fe 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.h\n> +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> @@ -61,13 +61,6 @@ public:\n> \t\t\t\t\t outputFormat);\n> \t}\n>\n> -\tint configureStat(const StreamConfiguration &cfg,\n> -\t\t\t V4L2DeviceFormat *outputFormat)\n> -\t{\n> -\t\treturn configureVideoDevice(stat_.get(), PAD_STAT, cfg,\n> -\t\t\t\t\t outputFormat);\n> -\t}\n> -\n> \tint allocateBuffers(unsigned int bufferCount);\n> \tvoid freeBuffers();\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 3f0232bc1eaad048..c559d160084f87e7 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -518,17 +518,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\treturn ret;\n> \t}\n>\n> -\t/*\n> -\t * Apply the largest available format to the stat node.\n> -\t * \\todo Revise this when we'll actually use the stat node.\n> -\t */\n> -\tStreamConfiguration statCfg = {};\n> -\tstatCfg.size = cio2Format.size;\n> -\n> -\tret = imgu->configureStat(statCfg, &outputFormat);\n> -\tif (ret)\n> -\t\treturn ret;\n> -\n> \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> \tControlList ctrls(imgu->imgu_->controls());\n> \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n> --\n> 2.29.2\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CEEDBDB89\n\tfor ;\n\tMon, 9 Nov 2020 10:18:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 244F56306B;\n\tMon, 9 Nov 2020 11:18:50 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40BE462D19\n\tfor ;\n\tMon, 9 Nov 2020 11:18:49 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B96D84000B;\n\tMon, 9 Nov 2020 10:18:48 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 9 Nov 2020 11:18:50 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20201109101850.txsrpdl5co3ylbvb@uno.localdomain>","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201105001546.1690179-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14112,"web_url":"https://patchwork.libcamera.org/comment/14112/","msgid":"","date":"2020-12-08T01:19:26","subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Nov 09, 2020 at 11:18:50AM +0100, Jacopo Mondi wrote:\n> On Thu, Nov 05, 2020 at 01:15:38AM +0100, Niklas Söderlund wrote:\n> > There is no reason to expose and call a separate configureStat() when\n> > the statistics video device can be configured with the exact same\n> > parameters as part of configure(). Move the configuration internally to\n> > the ImgUDevice simplifying the interface, there is no functional change.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/ipu3/imgu.cpp | 7 +++++++\n> > src/libcamera/pipeline/ipu3/imgu.h | 7 -------\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 11 -----------\n> > 3 files changed, 7 insertions(+), 18 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > index a4d74a62f69a0c97..0a3bf62020fd23fb 100644\n> > --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> > @@ -477,6 +477,13 @@ int ImgUDevice::configure(const PipeConfig &pipeConfig, V4L2DeviceFormat *inputF\n> >\n> > \tLOG(IPU3, Debug) << \"ImgU GDC format = \" << gdcFormat.toString();\n> >\n> > +\tStreamConfiguration statCfg = {};\n> > +\tstatCfg.size = inputFormat->size;\n> > +\tV4L2DeviceFormat statFormat;\n> > +\tret = configureVideoDevice(stat_.get(), PAD_STAT, statCfg, &statFormat);\n\nMaybe we should make the last parameter optional at some point, not\nsure.\n\n> > +\tif (ret)\n> > +\t\treturn ret;\n> > +\n> \n> This was in the same call path before, but just to make sure, I read\n> in ImgUDevice::configureVideoDevice():\n> \n> \t/* No need to apply format to the stat node. */\n> \tif (dev == stat_.get())\n> \t\treturn 0;\n> \n> No size need to be configured on the stat video device, but only on\n> the ImgU stat source pad ?\n\nThe ImgU driver sets .vidioc_s_fmt_meta_cap to imgu_vidioc_g_meta_fmt(),\nso there's indeed no need to set the format on the video node. We may\nwant to capture this in a comment in ImgUDevice::configureVideoDevice()\n(strictly speaking out of scope for this patch, but I wouldn't mind\nadding it here as a separate patch seems a bit overkill - I however know\nhow much Niklas likes to split patches :-)).\n\nI've had a quick look at the subdev configuration, and it seems to\nformat on the stats pad is completely ignored, so we could even simplify\nthe code further. This needs to be double-checked though, I'm not very\nfamiliar with the driver.\n\nReviewed-by: Laurent Pinchart \n\n> > \treturn 0;\n> > }\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\n> > index c73ac5a5a37cfe0e..37f5ae77c99ff8fe 100644\n> > --- a/src/libcamera/pipeline/ipu3/imgu.h\n> > +++ b/src/libcamera/pipeline/ipu3/imgu.h\n> > @@ -61,13 +61,6 @@ public:\n> > \t\t\t\t\t outputFormat);\n> > \t}\n> >\n> > -\tint configureStat(const StreamConfiguration &cfg,\n> > -\t\t\t V4L2DeviceFormat *outputFormat)\n> > -\t{\n> > -\t\treturn configureVideoDevice(stat_.get(), PAD_STAT, cfg,\n> > -\t\t\t\t\t outputFormat);\n> > -\t}\n> > -\n> > \tint allocateBuffers(unsigned int bufferCount);\n> > \tvoid freeBuffers();\n> >\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 3f0232bc1eaad048..c559d160084f87e7 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -518,17 +518,6 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> > \t\t\treturn ret;\n> > \t}\n> >\n> > -\t/*\n> > -\t * Apply the largest available format to the stat node.\n> > -\t * \\todo Revise this when we'll actually use the stat node.\n> > -\t */\n> > -\tStreamConfiguration statCfg = {};\n> > -\tstatCfg.size = cio2Format.size;\n> > -\n> > -\tret = imgu->configureStat(statCfg, &outputFormat);\n> > -\tif (ret)\n> > -\t\treturn ret;\n> > -\n> > \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> > \tControlList ctrls(imgu->imgu_->controls());\n> > \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30C2CBDB1F\n\tfor ;\n\tTue, 8 Dec 2020 01:19:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9CC267E6C;\n\tTue, 8 Dec 2020 02:19:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF2DD60323\n\tfor ;\n\tTue, 8 Dec 2020 02:19:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F913DD;\n\tTue, 8 Dec 2020 02:19:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U7zHLJln\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607390369;\n\tbh=K3/vXHf6/IdrfAbUjN5bfpjT2jpp5j7UmbxvNX8Yh9I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=U7zHLJlnNaf/09LO98bF7DxP8T6XnHaE1vjgRWgWTeI262UsQwAjso02t07suOpRp\n\tFm1BfyoLC/WG7jBwFDXLQe9g+dkChh1w6iBzwMiBv/8ryiCa3QsxTXopBBFa9N8zVO\n\t6ibLmTuAalbSNXFAsxyX4GkpoWiKgOssYm4mqnag=","Date":"Tue, 8 Dec 2020 03:19:26 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20201105001546.1690179-1-niklas.soderlund@ragnatech.se>\n\t<20201105001546.1690179-4-niklas.soderlund@ragnatech.se>\n\t<20201109101850.txsrpdl5co3ylbvb@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201109101850.txsrpdl5co3ylbvb@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 03/11] libcamera: ipu3: imgu:\n\tConfigure the stat video device as part of configure()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]