[{"id":13616,"web_url":"https://patchwork.libcamera.org/comment/13616/","msgid":"<20201106001609.GJ2008567@oden.dyn.berto.se>","date":"2020-11-06T00:16:09","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: Drop unnecessary\n\texplicit initialization of V4L2DeviceFormat","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-11-04 09:48:41 +0200, Laurent Pinchart wrote:\n> The V4L2DeviceFormat class now has default initializers for all members,\n> explicit initialization isn't needed anymore.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n> src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n> src/libcamera/pipeline/simple/converter.cpp | 2 +-\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n> src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n> 8 files changed, 15 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5a6ee1a83e45..4cedb32bc239 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -463,7 +463,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \t * adjusted format to be propagated to the ImgU output devices.\n> \t */\n> \tconst Size &sensorSize = config->cio2Format().size;\n> -\tV4L2DeviceFormat cio2Format = {};\n> +\tV4L2DeviceFormat cio2Format;\n> \tret = cio2->configure(sensorSize, &cio2Format);\n> \tif (ret)\n> \t\treturn ret;\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 0a60442cf570..7ad66f21ffa3 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -73,7 +73,7 @@ V4L2DeviceFormat findBestMode(V4L2VideoDevice::Formats &formatsMap,\n> \t\t\t const Size &req)\n> {\n> \tdouble bestScore = std::numeric_limits::max(), score;\n> -\tV4L2DeviceFormat bestMode = {};\n> +\tV4L2DeviceFormat bestMode;\n> \n> #define PENALTY_AR\t\t1500.0\n> #define PENALTY_8BIT\t\t2000.0\n> @@ -429,7 +429,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\t\tstatus = Adjusted;\n> \t\t}\n> \n> -\t\tV4L2DeviceFormat format = {};\n> +\t\tV4L2DeviceFormat format;\n> \t\tformat.fourcc = dev->toV4L2PixelFormat(cfg.pixelFormat);\n> \t\tformat.size = cfg.size;\n> \n> @@ -600,7 +600,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t * See which streams are requested, and route the user\n> \t * StreamConfiguration appropriately.\n> \t */\n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tfor (unsigned i = 0; i < config->size(); i++) {\n> \t\tStreamConfiguration &cfg = config->at(i);\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c74a2e9bd548..1b1922a9896c 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -720,13 +720,13 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\treturn ret;\n> \t}\n> \n> -\tV4L2DeviceFormat paramFormat = {};\n> +\tV4L2DeviceFormat paramFormat;\n> \tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n> \tret = param_->setFormat(¶mFormat);\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tV4L2DeviceFormat statFormat = {};\n> +\tV4L2DeviceFormat statFormat;\n> \tstatFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_STAT_3A);\n> \tret = stat_->setFormat(&statFormat);\n> \tif (ret)\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> index e98515c878aa..80e1818d7907 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n> @@ -85,7 +85,7 @@ CameraConfiguration::Status RkISP1Path::validate(StreamConfiguration *cfg)\n> \tcfg->size.expandTo(minResolution_);\n> \tcfg->bufferCount = RKISP1_BUFFER_COUNT;\n> \n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = video_->toV4L2PixelFormat(cfg->pixelFormat);\n> \tformat.size = cfg->size;\n> \n> @@ -146,7 +146,7 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n> \t\t<< ispFormat.toString();\n> \n> \tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n> -\tV4L2DeviceFormat outputFormat = {};\n> +\tV4L2DeviceFormat outputFormat;\n> \toutputFormat.fourcc = video_->toV4L2PixelFormat(config.pixelFormat);\n> \toutputFormat.size = config.size;\n> \toutputFormat.planesCount = info.numPlanes();\n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index c21479a191fe..57538ab08fcd 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -265,7 +265,7 @@ std::tuple\n> SimpleConverter::strideAndFrameSize(const Size &size,\n> \t\t\t\t const PixelFormat &pixelFormat)\n> {\n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = m2m_->capture()->toV4L2PixelFormat(pixelFormat);\n> \tformat.size = size;\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 3d2039f3f269..0d3078f770cf 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -482,7 +482,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \n> \t/* Set the stride and frameSize. */\n> \tif (!needConversion_) {\n> -\t\tV4L2DeviceFormat format = {};\n> +\t\tV4L2DeviceFormat format;\n> \t\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \t\tformat.size = cfg.size;\n> \n> @@ -587,7 +587,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t/* Configure the video node. */\n> \tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.pixelFormat);\n> \n> -\tV4L2DeviceFormat captureFormat = {};\n> +\tV4L2DeviceFormat captureFormat;\n> \tcaptureFormat.fourcc = videoFormat;\n> \tcaptureFormat.size = pipeConfig.captureSize;\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 3862631b7bed..0f3241cc873a 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -154,7 +154,7 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n> \n> \tcfg.bufferCount = 4;\n> \n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \tformat.size = cfg.size;\n> \n> @@ -210,7 +210,7 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n> \tStreamConfiguration &cfg = config->at(0);\n> \tint ret;\n> \n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \tformat.size = cfg.size;\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 7416c37c6f5a..914b6b54b0c4 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -172,7 +172,7 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n> \n> \tcfg.bufferCount = 4;\n> \n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \tformat.size = cfg.size;\n> \n> @@ -276,7 +276,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\tV4L2DeviceFormat format = {};\n> +\tV4L2DeviceFormat format;\n> \tformat.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat);\n> \tformat.size = cfg.size;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3307EBE082\n\tfor ;\n\tFri, 6 Nov 2020 00:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E54EF62D0E;\n\tFri, 6 Nov 2020 01:16:12 +0100 (CET)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC46362CAF\n\tfor ;\n\tFri, 6 Nov 2020 01:16:11 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id t13so3460943ljk.12\n\tfor ;\n\tThu, 05 Nov 2020 16:16:11 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tr80sm336106lff.77.2020.11.05.16.16.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Nov 2020 16:16:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"B8QN6BsF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=fiV3UhziyKXZUto4g2vON9Kzr6x0UcWTNksvVkc7RN8=;\n\tb=B8QN6BsFvIwHADAhNCihvUmgy+2IrS30+uuNY9i1kd8xglTyRY3XRPWYEj2GhwtoW6\n\tvUJrd+ZJbjN5VHEJqnsRnXyV3VepTnun2kmfOoJw9MiArLti8VPTiZZEul4rMEJOi1V0\n\t0gBM44yhFdNSJBfyhucA35AKnNM+Z20dsqhHJBzPfqTtkdSwdWddGyibCz8nazMaIF0a\n\tlKreNzsOu5OTN4tPCAs1OoCh5kiPBQ31LDSFK1rQdrlVQ6ATqd5iSPQDSP6exAQJBno3\n\tkH1jDHEh3d7Gc2xJwU2KwqgLU5MkCdQsLuVS6oaRwr9ODbpa8JSAx1tFfYHvptB7CuKQ\n\t3DAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=fiV3UhziyKXZUto4g2vON9Kzr6x0UcWTNksvVkc7RN8=;\n\tb=CtvrLe5LhG/bDfyku7tcaNElvUrFRCOrFd6R7yeEFVodx4S4jd9FmJvElJdSIYPQzj\n\tEMxhpLJlA36Y5rro1zyXJ311Ah4wEZA7mbKtjCD3eDZBqi1kHR+pS9Hb66ePElABUq3R\n\trLEjKENiWjAKKDibY5NpLcqbzK6+xaCuzn7hJiE/4NKYyhinF0QONVqLokEWcLmJwlby\n\tPhhAu1SN9DvVGu+E9ja9DZD8nncaFcaytqBUXAYT67bhkgbVhxjhHstUP0Bctcz1Zz7s\n\tohjX1kdHrZhf9sDB/7vbcj9bveGWmWcAxiJk36detzumw4lamGKYaaBfifftyairQ6CL\n\tOa9g==","X-Gm-Message-State":"AOAM5339YTyAkGC6K/d2rGrvhbHC4yjzTi5Ve3fbIxsxlf9ViHn46wx6\n\tr48N1WozKpxy2USHs0soFFJWkw==","X-Google-Smtp-Source":"ABdhPJw30ZVrgqQtBM3GTRFdcdy9K5RCpmAM+do1RT9XgySDzssoT0m5w+2EDLEjOlBoB3TxQjNBfg==","X-Received":"by 2002:a2e:5750:: with SMTP id r16mr1674254ljd.31.1604621771164;\n\tThu, 05 Nov 2020 16:16:11 -0800 (PST)","Date":"Fri, 6 Nov 2020 01:16:09 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201106001609.GJ2008567@oden.dyn.berto.se>","References":"<20201104074841.21676-1-laurent.pinchart@ideasonboard.com>\n\t<20201104074841.21676-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201104074841.21676-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: Drop unnecessary\n\texplicit initialization of V4L2DeviceFormat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]