[{"id":13584,"web_url":"https://patchwork.libcamera.org/comment/13584/","msgid":"<99ef4bf5-5e13-2264-de05-c550b20d3977@linaro.org>","date":"2020-11-03T19:23:46","subject":"Re: [libcamera-devel] [PATCH 6/7] qcam: viewfinder_gl: Store\n\ttextures in an array","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Laurent,\n\nThank you for the patch!\n\nOn 03.11.2020 18:50, Laurent Pinchart wrote:\n> In preparation for RGB formats support, store the three Y, U and V\n> textures in an array. This makes the code more generic, and will avoid\n> referring to an RGB texture as textureY_.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/viewfinder_gl.cpp | 37 +++++++++++++++++--------------------\n> src/qcam/viewfinder_gl.h | 5 ++---\n> 2 files changed, 19 insertions(+), 23 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index e6625cac9795..cbc1365500f5 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -33,10 +33,7 @@ static const QList supportedFormats{\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> \t: QOpenGLWidget(parent), buffer_(nullptr), data_(nullptr),\n> -\t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> -\t textureU_(QOpenGLTexture::Target2D),\n> -\t textureV_(QOpenGLTexture::Target2D),\n> -\t textureY_(QOpenGLTexture::Target2D)\n> +\t vertexBuffer_(QOpenGLBuffer::VertexBuffer)\n> {\n> }\n> \n> @@ -263,14 +260,14 @@ bool ViewFinderGL::createFragmentShader()\n> \ttextureUniformV_ = shaderProgram_.uniformLocation(\"tex_v\");\n> \ttextureUniformStepX_ = shaderProgram_.uniformLocation(\"tex_stepx\");\n> \n> -\tif (!textureY_.isCreated())\n> -\t\ttextureY_.create();\n> +\t/* Create the textures. */\n> +\tfor (std::unique_ptr &texture : textures_) {\n> +\t\tif (texture)\n> +\t\t\tcontinue;\n> \n> -\tif (!textureU_.isCreated())\n> -\t\ttextureU_.create();\n> -\n> -\tif (!textureV_.isCreated())\n> -\t\ttextureV_.create();\n> +\t\ttexture = std::make_unique(QOpenGLTexture::Target2D);\n> +\t\ttexture->create();\n> +\t}\n> \n> \treturn true;\n> }\n> @@ -337,7 +334,7 @@ void ViewFinderGL::doRender()\n> \tcase libcamera::formats::NV42:\n> \t\t/* Activate texture Y */\n> \t\tglActiveTexture(GL_TEXTURE0);\n> -\t\tconfigureTexture(textureY_);\n> +\t\tconfigureTexture(*textures_[0]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -351,7 +348,7 @@ void ViewFinderGL::doRender()\n> \n> \t\t/* Activate texture UV/VU */\n> \t\tglActiveTexture(GL_TEXTURE1);\n> -\t\tconfigureTexture(textureU_);\n> +\t\tconfigureTexture(*textures_[1]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> @@ -367,7 +364,7 @@ void ViewFinderGL::doRender()\n> \tcase libcamera::formats::YUV420:\n> \t\t/* Activate texture Y */\n> \t\tglActiveTexture(GL_TEXTURE0);\n> -\t\tconfigureTexture(textureY_);\n> +\t\tconfigureTexture(*textures_[0]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -381,7 +378,7 @@ void ViewFinderGL::doRender()\n> \n> \t\t/* Activate texture U */\n> \t\tglActiveTexture(GL_TEXTURE1);\n> -\t\tconfigureTexture(textureU_);\n> +\t\tconfigureTexture(*textures_[1]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -395,7 +392,7 @@ void ViewFinderGL::doRender()\n> \n> \t\t/* Activate texture V */\n> \t\tglActiveTexture(GL_TEXTURE2);\n> -\t\tconfigureTexture(textureV_);\n> +\t\tconfigureTexture(*textures_[2]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -411,7 +408,7 @@ void ViewFinderGL::doRender()\n> \tcase libcamera::formats::YVU420:\n> \t\t/* Activate texture Y */\n> \t\tglActiveTexture(GL_TEXTURE0);\n> -\t\tconfigureTexture(textureY_);\n> +\t\tconfigureTexture(*textures_[0]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -425,7 +422,7 @@ void ViewFinderGL::doRender()\n> \n> \t\t/* Activate texture V */\n> \t\tglActiveTexture(GL_TEXTURE2);\n> -\t\tconfigureTexture(textureV_);\n> +\t\tconfigureTexture(*textures_[2]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -439,7 +436,7 @@ void ViewFinderGL::doRender()\n> \n> \t\t/* Activate texture U */\n> \t\tglActiveTexture(GL_TEXTURE1);\n> -\t\tconfigureTexture(textureU_);\n> +\t\tconfigureTexture(*textures_[1]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> @@ -462,7 +459,7 @@ void ViewFinderGL::doRender()\n> \t\t * The texture width is thus half of the image with.\n> \t\t */\n> \t\tglActiveTexture(GL_TEXTURE0);\n> -\t\tconfigureTexture(textureY_);\n> +\t\tconfigureTexture(*textures_[0]);\n> \t\tglTexImage2D(GL_TEXTURE_2D,\n> \t\t\t 0,\n> \t\t\t GL_RGBA,\n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index b3e36514d3d4..17c824a69e39 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -8,6 +8,7 @@\n> #ifndef __VIEWFINDER_GL_H__\n> #define __VIEWFINDER_GL_H__\n> \n> +#include \n> #include \n> \n> #include \n> @@ -82,9 +83,7 @@ private:\n\nThese two lines are not visible in the diff:\n\n /* YUV texture planars and parameters */\n GLuint textureUniformU_;\n> \tGLuint textureUniformV_;\n> \tGLuint textureUniformY_;\n> \tGLuint textureUniformStepX_;\n> -\tQOpenGLTexture textureU_;\n> -\tQOpenGLTexture textureV_;\n> -\tQOpenGLTexture textureY_;\n> +\tstd::array, 3> textures_;\n\n- now the textures_ should be better moved outside the /* YUV texture planars and parameters */ block\n\nOther than that\n\nReviewed-by: Andrey Konovalov \n\nThanks,\nAndrey\n\n> \tunsigned int horzSubSample_;\n> \tunsigned int vertSubSample_;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0221DBDB89\n\tfor ;\n\tTue, 3 Nov 2020 19:23:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 869CF62B7E;\n\tTue, 3 Nov 2020 20:23:49 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9243762B7E\n\tfor ;\n\tTue, 3 Nov 2020 20:23:48 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id f9so23786902lfq.2\n\tfor ;\n\tTue, 03 Nov 2020 11:23:48 -0800 (PST)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\t27sm1571693lfy.195.2020.11.03.11.23.46\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 03 Nov 2020 11:23:47 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"YMHypeC7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=qB6Emb7X5HwcuwzbM3J1bCYQ1kjXznPFVxSFSykuOzo=;\n\tb=YMHypeC7B+yeJjiXLczmAarL+m1F+qCvOqCB9YBthGg59VyIQWpKhbbgyEFkktm9Dn\n\tdX4y/N7kzwK5g0G4YsMXWmeFSHoQ3tuS9d5yG6DURIDX+zIfhrVschjU0ykNb2YrHDx0\n\t+e1Gg3cl6+pgbq7+9F8H9/6qjYo5BdIL07F+iz44qMfdPd92TZlCot32Ij4X2M85S5Ql\n\tKfo/TW9QGT1Kn5ZQ/UQazJ75hDhKKJdVyArwpkbwMW+XEIf5Z+HkXapdXOn9gO7TqeA5\n\tM3Mp2bdLQ7Y7AOP7vIFrwM/Pn+WC18v7+DemkdIjzUN3sxgEmzm8MEiDLw4fYYVTmFsM\n\tZ++Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=qB6Emb7X5HwcuwzbM3J1bCYQ1kjXznPFVxSFSykuOzo=;\n\tb=so2WQAB8/YY76GZqtvaRkbtkDBTZJAY6kw9Oaox2ozZw9Gms19HvEL+ACs4o982uqA\n\tpFniFPAEFRt40XOi7Y2322aJgSq6XoRZwEsBAoSfy6qfWAjjrThiuyHPeEtq7vWLyDhS\n\t+G0q+yWFyeqlPqlfhteN6gx8HyNbIODZs44Wy5lT6sAHtnWWPCLq/n1nRtz9PtTD2Jzi\n\toDRHY7sasN17vSyKmoFjRk9dY0Pn0TjgP3xiXFY24cL1qvg6Mmz1pNP+J51GPCC/QGKM\n\tHwvWm97HTgEJdYu6XRoitEcZVoXcyg1MIdf8cATdDJ3xhe72FS0KeG9MWr8F51zRWtLO\n\tGIig==","X-Gm-Message-State":"AOAM530sveg3spaWptSf5Ix0gnbhh8R3Hfea2ezkBTpGAaJ5lxI7Wz1K\n\tA6R3j9B98z8Y92gMeohu6NbC2KsAXIufDQ==","X-Google-Smtp-Source":"ABdhPJwIH8jt/uj4a6vz+GpNoaxOCN81uo4HyLxkkrk03Nl5158faI+P4kBXd1vLNGypxS+dv87luw==","X-Received":"by 2002:a19:7102:: with SMTP id m2mr7713231lfc.461.1604431427949;\n\tTue, 03 Nov 2020 11:23:47 -0800 (PST)","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-7-laurent.pinchart@ideasonboard.com>","From":"Andrey Konovalov ","Message-ID":"<99ef4bf5-5e13-2264-de05-c550b20d3977@linaro.org>","Date":"Tue, 3 Nov 2020 22:23:46 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-7-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 6/7] qcam: viewfinder_gl: Store\n\ttextures in an array","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13600,"web_url":"https://patchwork.libcamera.org/comment/13600/","msgid":"","date":"2020-11-04T10:39:11","subject":"Re: [libcamera-devel] [PATCH 6/7] qcam: viewfinder_gl: Store\n\ttextures in an array","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/11/2020 19:23, Andrey Konovalov wrote:\n> Hi Laurent,\n> \n> Thank you for the patch!\n> \n> On 03.11.2020 18:50, Laurent Pinchart wrote:\n>> In preparation for RGB formats support, store the three Y, U and V\n>> textures in an array. This makes the code more generic, and will avoid\n>> referring to an RGB texture as textureY_.\n\nDefinitely helpful ;-)\n\n\n>>\n>> Signed-off-by: Laurent Pinchart \n>> ---\n>>   src/qcam/viewfinder_gl.cpp | 37 +++++++++++++++++--------------------\n>>   src/qcam/viewfinder_gl.h   |  5 ++---\n>>   2 files changed, 19 insertions(+), 23 deletions(-)\n>>\n>> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n>> index e6625cac9795..cbc1365500f5 100644\n>> --- a/src/qcam/viewfinder_gl.cpp\n>> +++ b/src/qcam/viewfinder_gl.cpp\n>> @@ -33,10 +33,7 @@ static const QList\n>> supportedFormats{\n>>     ViewFinderGL::ViewFinderGL(QWidget *parent)\n>>       : QOpenGLWidget(parent), buffer_(nullptr), data_(nullptr),\n>> -      vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n>> -      textureU_(QOpenGLTexture::Target2D),\n>> -      textureV_(QOpenGLTexture::Target2D),\n>> -      textureY_(QOpenGLTexture::Target2D)\n>> +      vertexBuffer_(QOpenGLBuffer::VertexBuffer)\n>>   {\n>>   }\n>>   @@ -263,14 +260,14 @@ bool ViewFinderGL::createFragmentShader()\n>>       textureUniformV_ = shaderProgram_.uniformLocation(\"tex_v\");\n>>       textureUniformStepX_ = shaderProgram_.uniformLocation(\"tex_stepx\");\n>>   -    if (!textureY_.isCreated())\n>> -        textureY_.create();\n>> +    /* Create the textures. */\n>> +    for (std::unique_ptr &texture : textures_) {\n>> +        if (texture)\n>> +            continue;\n>>   -    if (!textureU_.isCreated())\n>> -        textureU_.create();\n>> -\n>> -    if (!textureV_.isCreated())\n>> -        textureV_.create();\n>> +        texture =\n>> std::make_unique(QOpenGLTexture::Target2D);\n>> +        texture->create();\n>> +    }\n>>         return true;\n>>   }\n>> @@ -337,7 +334,7 @@ void ViewFinderGL::doRender()\n>>       case libcamera::formats::NV42:\n>>           /* Activate texture Y */\n>>           glActiveTexture(GL_TEXTURE0);\n>> -        configureTexture(textureY_);\n>> +        configureTexture(*textures_[0]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -351,7 +348,7 @@ void ViewFinderGL::doRender()\n>>             /* Activate texture UV/VU */\n>>           glActiveTexture(GL_TEXTURE1);\n>> -        configureTexture(textureU_);\n>> +        configureTexture(*textures_[1]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RG,\n>> @@ -367,7 +364,7 @@ void ViewFinderGL::doRender()\n>>       case libcamera::formats::YUV420:\n>>           /* Activate texture Y */\n>>           glActiveTexture(GL_TEXTURE0);\n>> -        configureTexture(textureY_);\n>> +        configureTexture(*textures_[0]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -381,7 +378,7 @@ void ViewFinderGL::doRender()\n>>             /* Activate texture U */\n>>           glActiveTexture(GL_TEXTURE1);\n>> -        configureTexture(textureU_);\n>> +        configureTexture(*textures_[1]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -395,7 +392,7 @@ void ViewFinderGL::doRender()\n>>             /* Activate texture V */\n>>           glActiveTexture(GL_TEXTURE2);\n>> -        configureTexture(textureV_);\n>> +        configureTexture(*textures_[2]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -411,7 +408,7 @@ void ViewFinderGL::doRender()\n>>       case libcamera::formats::YVU420:\n>>           /* Activate texture Y */\n>>           glActiveTexture(GL_TEXTURE0);\n>> -        configureTexture(textureY_);\n>> +        configureTexture(*textures_[0]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -425,7 +422,7 @@ void ViewFinderGL::doRender()\n>>             /* Activate texture V */\n>>           glActiveTexture(GL_TEXTURE2);\n>> -        configureTexture(textureV_);\n>> +        configureTexture(*textures_[2]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -439,7 +436,7 @@ void ViewFinderGL::doRender()\n>>             /* Activate texture U */\n>>           glActiveTexture(GL_TEXTURE1);\n>> -        configureTexture(textureU_);\n>> +        configureTexture(*textures_[1]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RED,\n>> @@ -462,7 +459,7 @@ void ViewFinderGL::doRender()\n>>            * The texture width is thus half of the image with.\n>>            */\n>>           glActiveTexture(GL_TEXTURE0);\n>> -        configureTexture(textureY_);\n>> +        configureTexture(*textures_[0]);\n>>           glTexImage2D(GL_TEXTURE_2D,\n>>                    0,\n>>                    GL_RGBA,\n>> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n>> index b3e36514d3d4..17c824a69e39 100644\n>> --- a/src/qcam/viewfinder_gl.h\n>> +++ b/src/qcam/viewfinder_gl.h\n>> @@ -8,6 +8,7 @@\n>>   #ifndef __VIEWFINDER_GL_H__\n>>   #define __VIEWFINDER_GL_H__\n>>   +#include \n>>   #include \n>>     #include \n>> @@ -82,9 +83,7 @@ private:\n> \n> These two lines are not visible in the diff:\n> \n>         /* YUV texture planars and parameters */\n>         GLuint textureUniformU_;\n>>       GLuint textureUniformV_;\n>>       GLuint textureUniformY_;\n>>       GLuint textureUniformStepX_;\n>> -    QOpenGLTexture textureU_;\n>> -    QOpenGLTexture textureV_;\n>> -    QOpenGLTexture textureY_;\n>> +    std::array, 3> textures_;\n> \n> - now the textures_ should be better moved outside the /* YUV texture\n> planars and parameters */ block\n> \n> Other than that\n> \n> Reviewed-by: Andrey Konovalov \n\nYup, organised however best fits - storing TEXTURE0 in textures_[0]\nmakes me quite happy ;-)\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Thanks,\n> Andrey\n> \n>>       unsigned int horzSubSample_;\n>>       unsigned int vertSubSample_;\n>>  \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC9D7BE080\n\tfor ;\n\tWed, 4 Nov 2020 10:39:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7639362C64;\n\tWed, 4 Nov 2020 11:39:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 419DA60344\n\tfor ;\n\tWed, 4 Nov 2020 11:39:14 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9EBAC563;\n\tWed, 4 Nov 2020 11:39:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UVpWi9Ie\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604486353;\n\tbh=cE9d7MqobB+OlDfOSkdN+H9df9YMMPSSefFQULZuWYw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=UVpWi9Ievid1iprBJFEvR4YLxgvCmPPON5kyRoNxFiJ7pGpolERPaELXL1UvzRUzp\n\t911OFU08f/tC2eq7RyF9pjbr1KRvQHVaokPkFVKCY3vvCWoqDvUsPv2C4OtHdHLgCV\n\tu3iMie4GqU5+L7m1x7W6MaO/FkQXoYK/xs2Qtvao=","To":"Andrey Konovalov ,\n\tLaurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-7-laurent.pinchart@ideasonboard.com>\n\t<99ef4bf5-5e13-2264-de05-c550b20d3977@linaro.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Wed, 4 Nov 2020 10:39:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<99ef4bf5-5e13-2264-de05-c550b20d3977@linaro.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 6/7] qcam: viewfinder_gl: Store\n\ttextures in an array","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]