[{"id":13580,"web_url":"https://patchwork.libcamera.org/comment/13580/","msgid":"<58317238-ab2e-b927-6956-25b9a4d16579@linaro.org>","date":"2020-11-03T16:43:57","subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Laurent,\n\nThanks you for the patch!\n\nI have a similar change in my local branch too -\n\nReviewed-by: Andrey Konovalov \n\nThanks,\nAndrey\n\nOn 03.11.2020 18:50, Laurent Pinchart wrote:\n> In preparation for RGB formats support, rename the pointer to image data\n> from yuvData_ to data_.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/viewfinder_gl.cpp | 24 ++++++++++++------------\n> src/qcam/viewfinder_gl.h | 2 +-\n> 2 files changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 110f0fa673df..e6625cac9795 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -32,7 +32,7 @@ static const QList supportedFormats{\n> };\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> -\t: QOpenGLWidget(parent), buffer_(nullptr), yuvData_(nullptr),\n> +\t: QOpenGLWidget(parent), buffer_(nullptr), data_(nullptr),\n> \t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> \t textureU_(QOpenGLTexture::Target2D),\n> \t textureV_(QOpenGLTexture::Target2D),\n> @@ -101,7 +101,7 @@ void ViewFinderGL::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n> \tif (buffer_)\n> \t\trenderComplete(buffer_);\n> \n> -\tyuvData_ = static_cast(map->memory);\n> +\tdata_ = static_cast(map->memory);\n> \tupdate();\n> \tbuffer_ = buffer;\n> }\n> @@ -346,7 +346,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture UV/VU */\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -376,7 +376,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture U */\n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -420,7 +420,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture V */\n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -471,7 +471,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RGBA,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/*\n> @@ -497,7 +497,7 @@ void ViewFinderGL::paintGL()\n> \t\t\t\t << \"create fragment shader failed.\";\n> \t\t}\n> \n> -\tif (yuvData_) {\n> +\tif (data_) {\n> \t\tglClearColor(0.0, 0.0, 0.0, 1.0);\n> \t\tglClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n> \n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index 40c04dc5f877..b3e36514d3d4 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -65,7 +65,7 @@ private:\n> \tlibcamera::FrameBuffer *buffer_;\n> \tlibcamera::PixelFormat format_;\n> \tQSize size_;\n> -\tunsigned char *yuvData_;\n> +\tunsigned char *data_;\n> \n> \t/* Shaders */\n> \tQOpenGLShaderProgram shaderProgram_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD2B3BDB89\n\tfor ;\n\tTue, 3 Nov 2020 16:44:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 576BD62BC9;\n\tTue, 3 Nov 2020 17:44:03 +0100 (CET)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51ABF62B7E\n\tfor ;\n\tTue, 3 Nov 2020 17:44:01 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id 23so19732811ljv.7\n\tfor ;\n\tTue, 03 Nov 2020 08:44:01 -0800 (PST)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\tf21sm3480559lfc.165.2020.11.03.08.43.59\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 03 Nov 2020 08:43:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WqYU8MpJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=jpm8bUbIqHQG2Yi9oQWDKs7OH+neQ2tiR3dIsAyegL0=;\n\tb=WqYU8MpJItrY/5pBn/16fuangxWcqsciV7rzbqJ0AElBAsC6Jzg4Co1XZc0kdcTCTO\n\tP5yxrPhLwotIZhaOqhxDeh9D11MOftKGdZTfG3tAJulConi6FTx6XrjPsqEaNHt/SnQM\n\tkm19j/Xty5I5cPy1iFJuoZoIZyWlKMO+iOVf8HG00a5AbuOKib7irEBqr2M/zltwSz/3\n\tTQ79NeRz7CTAR6IfzXAmlMsl7nY6J9R3MJLcotZaYH+eyjiFUPYXg1f+HetvH77d7N64\n\t+6lhQlY6k2dnnpb9IUqX4yioLkXMTbKgNJPB0zikwstiEPIMxEwsWSmIT+YQeNOfSLzr\n\tfzMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=jpm8bUbIqHQG2Yi9oQWDKs7OH+neQ2tiR3dIsAyegL0=;\n\tb=CUle/O8laE1/Qg9w7vKcLYqUxU6Fcg9R8L2emhaIhw/OEaA2Vd+G1mPa3HF2XFGECe\n\tk65dNlz5kAttrkc1S7QYkHebTRlfHg289OkzsRr/a97hTFZVd/oHNvJN0UzBzQXVKHB/\n\t97B/Zt1Rb9x5SkxvRnz6dbgOzU2RCiumg27X35Vuv60z7QtK7UQmwpoICzX3NmviAndK\n\tT1jpposAi6eN3AlWYdIFNu4ksP8DxouqFot4mNfWVSuEuCepj0TIoujs0uiiK8QnIF81\n\t3REdEivlHLE9/RaphkfHnS6vpxTjUdvaC6we1FRHWDEF56O9fIA/ytNjHyvE865UpLNp\n\tHPFg==","X-Gm-Message-State":"AOAM533wpqAczgIlQwGkuN86d1gCYbBueNTaYJgLzcbPbmoReLhT4Fmk\n\txqHWD3xtoJPu6JJKPx201xneiQ==","X-Google-Smtp-Source":"ABdhPJx/FNycrbvxDaHUBABJcFm4hdjacbMye8iWreGNVNs1gwsmStqMxPxYI3k7mTSy/oVz874udw==","X-Received":"by 2002:a2e:8096:: with SMTP id\n\ti22mr8326637ljg.176.1604421840455; \n\tTue, 03 Nov 2020 08:44:00 -0800 (PST)","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","From":"Andrey Konovalov ","Message-ID":"<58317238-ab2e-b927-6956-25b9a4d16579@linaro.org>","Date":"Tue, 3 Nov 2020 19:43:57 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13590,"web_url":"https://patchwork.libcamera.org/comment/13590/","msgid":"<53799eaf-6a69-edd7-6ca7-2644d9c3f5d6@ideasonboard.com>","date":"2020-11-03T23:01:19","subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 03/11/2020 15:50, Laurent Pinchart wrote:\n> In preparation for RGB formats support, rename the pointer to image data\n> from yuvData_ to data_.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/qcam/viewfinder_gl.cpp | 24 ++++++++++++------------\n> src/qcam/viewfinder_gl.h | 2 +-\n> 2 files changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 110f0fa673df..e6625cac9795 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -32,7 +32,7 @@ static const QList supportedFormats{\n> };\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> -\t: QOpenGLWidget(parent), buffer_(nullptr), yuvData_(nullptr),\n> +\t: QOpenGLWidget(parent), buffer_(nullptr), data_(nullptr),\n> \t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> \t textureU_(QOpenGLTexture::Target2D),\n> \t textureV_(QOpenGLTexture::Target2D),\n> @@ -101,7 +101,7 @@ void ViewFinderGL::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n> \tif (buffer_)\n> \t\trenderComplete(buffer_);\n> \n> -\tyuvData_ = static_cast(map->memory);\n> +\tdata_ = static_cast(map->memory);\n> \tupdate();\n> \tbuffer_ = buffer;\n> }\n> @@ -346,7 +346,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture UV/VU */\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -376,7 +376,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture U */\n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -420,7 +420,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture V */\n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -471,7 +471,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RGBA,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/*\n> @@ -497,7 +497,7 @@ void ViewFinderGL::paintGL()\n> \t\t\t\t << \"create fragment shader failed.\";\n> \t\t}\n> \n> -\tif (yuvData_) {\n> +\tif (data_) {\n> \t\tglClearColor(0.0, 0.0, 0.0, 1.0);\n> \t\tglClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n> \n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index 40c04dc5f877..b3e36514d3d4 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -65,7 +65,7 @@ private:\n> \tlibcamera::FrameBuffer *buffer_;\n> \tlibcamera::PixelFormat format_;\n> \tQSize size_;\n> -\tunsigned char *yuvData_;\n> +\tunsigned char *data_;\n> \n> \t/* Shaders */\n> \tQOpenGLShaderProgram shaderProgram_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07BA2BDB1E\n\tfor ;\n\tTue, 3 Nov 2020 23:01:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB7E262C09;\n\tWed, 4 Nov 2020 00:01:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BA67625AC\n\tfor ;\n\tWed, 4 Nov 2020 00:01:23 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B2FCF9E5;\n\tWed, 4 Nov 2020 00:01:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wSI/pviJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604444482;\n\tbh=UqbLf+Jxc32Y7OhE3bnelV5d6+HUSI110sAfyCh7zU4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=wSI/pviJz8tJE0PsH3t7d//uWMQ/6HyllN86G5HlQ6rTSL7zYV85+BGIa6/HveQ4f\n\ta5hNh6MqY4sxB/sg+KGdPKWOfp4hI5GbpzHgqWNpeDvGPERvKDsXxWNdyMLVF3ZPCG\n\tscZABEOwTtxymvMZVwwegwUhHCmTmp4zi+4b/3XM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<53799eaf-6a69-edd7-6ca7-2644d9c3f5d6@ideasonboard.com>","Date":"Tue, 3 Nov 2020 23:01:19 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13621,"web_url":"https://patchwork.libcamera.org/comment/13621/","msgid":"<20201106004820.GE3003904@oden.dyn.berto.se>","date":"2020-11-06T00:48:20","subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-11-03 17:50:23 +0200, Laurent Pinchart wrote:\n> In preparation for RGB formats support, rename the pointer to image data\n> from yuvData_ to data_.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/viewfinder_gl.cpp | 24 ++++++++++++------------\n> src/qcam/viewfinder_gl.h | 2 +-\n> 2 files changed, 13 insertions(+), 13 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 110f0fa673df..e6625cac9795 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -32,7 +32,7 @@ static const QList supportedFormats{\n> };\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> -\t: QOpenGLWidget(parent), buffer_(nullptr), yuvData_(nullptr),\n> +\t: QOpenGLWidget(parent), buffer_(nullptr), data_(nullptr),\n> \t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> \t textureU_(QOpenGLTexture::Target2D),\n> \t textureV_(QOpenGLTexture::Target2D),\n> @@ -101,7 +101,7 @@ void ViewFinderGL::render(libcamera::FrameBuffer *buffer, MappedBuffer *map)\n> \tif (buffer_)\n> \t\trenderComplete(buffer_);\n> \n> -\tyuvData_ = static_cast(map->memory);\n> +\tdata_ = static_cast(map->memory);\n> \tupdate();\n> \tbuffer_ = buffer;\n> }\n> @@ -346,7 +346,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture UV/VU */\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -376,7 +376,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture U */\n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -420,7 +420,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/* Activate texture V */\n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height());\n> +\t\t\t data_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t data_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -471,7 +471,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RGBA,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t yuvData_);\n> +\t\t\t data_);\n> \t\tshaderProgram_.setUniformValue(textureUniformY_, 0);\n> \n> \t\t/*\n> @@ -497,7 +497,7 @@ void ViewFinderGL::paintGL()\n> \t\t\t\t << \"create fragment shader failed.\";\n> \t\t}\n> \n> -\tif (yuvData_) {\n> +\tif (data_) {\n> \t\tglClearColor(0.0, 0.0, 0.0, 1.0);\n> \t\tglClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);\n> \n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index 40c04dc5f877..b3e36514d3d4 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -65,7 +65,7 @@ private:\n> \tlibcamera::FrameBuffer *buffer_;\n> \tlibcamera::PixelFormat format_;\n> \tQSize size_;\n> -\tunsigned char *yuvData_;\n> +\tunsigned char *data_;\n> \n> \t/* Shaders */\n> \tQOpenGLShaderProgram shaderProgram_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BACA7BE082\n\tfor ;\n\tFri, 6 Nov 2020 00:48:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 883D262D0E;\n\tFri, 6 Nov 2020 01:48:23 +0100 (CET)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7351262CAF\n\tfor ;\n\tFri, 6 Nov 2020 01:48:22 +0100 (CET)","by mail-lf1-x144.google.com with SMTP id i6so5019974lfd.1\n\tfor ;\n\tThu, 05 Nov 2020 16:48:22 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty26sm342128lfe.164.2020.11.05.16.48.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Nov 2020 16:48:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"YL4b2lk+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/MHQDleQZwClH3sCwThZKEJZm5Bam4t93yD5tfeRpcs=;\n\tb=YL4b2lk+9OluT+brupJGnHtiI0H46RlRQOaQlz90m9moCNZaM4s14gqQD+tppRPUKi\n\tTLDKeOoQrkNrS6+VcOG+FpJ17KhR6TV2AfQlmPQtsBJGnW0VI/2mEBPGnjXequFDdoo3\n\tcoT9paQJg7oUdCUpujDepwtt/b4tw7W9fvioLhiIjJtR8pH/qnBWBZ/DmjTpoi3CuCRf\n\tO4ShiDZoW0/oiTq4ShmRZsEmUFMSCcP/b/mCQLSrYHSk3Dd4WY3j49s4FlpWvmsXp746\n\tSgEcJ7k6GTEKqgsBNGwU/chQuQmJHtIwnxE+v+l5DEH+uid6ZYOVU323bK/FTwXf7xod\n\t5KWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/MHQDleQZwClH3sCwThZKEJZm5Bam4t93yD5tfeRpcs=;\n\tb=r2ntuSEWf3rm8LrsrYNfcmqoyqda73cv1A9SFyEVMBdOjyeFWEkOUGaKPEC8Ti82rO\n\tXc4CswaS8r6wPCHeh2MkfK+3MT31Qaz00sI/Qx7u3NAr4KWPnDuMmlMC6seUtrZOe7EK\n\tE4NYw/VaGc5XRCxyRpdgQimX3lbmJ4Sen56f/e/nSZQzcsTva9E2rGU2guSALxLJcWwr\n\tUMgDCSglsdDMn9due05yIsrzKRyElf0ExFWRK63NLOHOENbw/NrztJ+uHYj+ncFe/99h\n\tAOd/mxnR5SoeCcy2xbDgjUcBdTopfBUoqJ3noV4bfCxaFV3anbdlqeY0RSzMNNvPF0zr\n\tVeHQ==","X-Gm-Message-State":"AOAM531P3NaT1RZoVT8yw5gItxrL5rn8UK7F8rcsTNKhAEpt3EoWjdYw\n\tWID5OxKmB8S33CWdDsNmnfcCxwlnRbau+yR+","X-Google-Smtp-Source":"ABdhPJx+mlUOWlTBaWy5X+LWI+8vctGYjyZh6ckCT7YIFxpxl2W2SBKVovr/eCD5hFjaPQcdzlD7FA==","X-Received":"by 2002:ac2:46e3:: with SMTP id q3mr1834720lfo.213.1604623701909;\n\tThu, 05 Nov 2020 16:48:21 -0800 (PST)","Date":"Fri, 6 Nov 2020 01:48:20 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201106004820.GE3003904@oden.dyn.berto.se>","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201103155025.5948-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/7] qcam: viewfinder_gl: Rename\n\tyuvData_ to data_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]