[{"id":13583,"web_url":"https://patchwork.libcamera.org/comment/13583/","msgid":"<2691a2f3-b4cb-5c07-6349-8190aa2b7b7f@linaro.org>","date":"2020-11-03T18:32:39","subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Laurent,\n\nThank you for the patch!\n\nOn 03.11.2020 18:50, Laurent Pinchart wrote:\n> In preparation for RGB formats support, rename the identity vertex\n> shader from YUV.vert to identify.vert.\n\n- s/identify/identity in the above line\n\nYes, identity is a better name for this shader.\n\nReviewed-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n\nThanks,\nAndrey\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>   src/qcam/assets/shader/{YUV.vert => identity.vert} | 2 +-\n>   src/qcam/assets/shader/shaders.qrc                 | 2 +-\n>   src/qcam/viewfinder_gl.cpp                         | 2 +-\n>   3 files changed, 3 insertions(+), 3 deletions(-)\n>   rename src/qcam/assets/shader/{YUV.vert => identity.vert} (77%)\n> \n> diff --git a/src/qcam/assets/shader/YUV.vert b/src/qcam/assets/shader/identity.vert\n> similarity index 77%\n> rename from src/qcam/assets/shader/YUV.vert\n> rename to src/qcam/assets/shader/identity.vert\n> index f38e8045db89..6d6f7551017e 100644\n> --- a/src/qcam/assets/shader/YUV.vert\n> +++ b/src/qcam/assets/shader/identity.vert\n> @@ -2,7 +2,7 @@\n>   /*\n>    * Copyright (C) 2020, Linaro\n>    *\n> - * YUV.vert - Vertex shader for YUV to RGB conversion\n> + * identity.vert - Identity vertex shader for pixel format conversion\n>    */\n>   \n>   attribute vec4 vertexIn;\n> diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc\n> index 857ed9fd5cde..863109146281 100644\n> --- a/src/qcam/assets/shader/shaders.qrc\n> +++ b/src/qcam/assets/shader/shaders.qrc\n> @@ -1,9 +1,9 @@\n>   <!-- SPDX-License-Identifier: LGPL-2.1-or-later -->\n>   <!DOCTYPE RCC><RCC version=\"1.0\">\n>   <qresource>\n> -\t<file>YUV.vert</file>\n>   \t<file>YUV_2_planes.frag</file>\n>   \t<file>YUV_3_planes.frag</file>\n>   \t<file>YUV_packed.frag</file>\n> +\t<file>identity.vert</file>\n>   </qresource>\n>   </RCC>\n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index dc35d4fd8505..110f0fa673df 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -191,7 +191,7 @@ bool ViewFinderGL::createVertexShader()\n>   \tvertexShader_ = std::make_unique<QOpenGLShader>(QOpenGLShader::Vertex, this);\n>   \n>   \t/* Compile the vertex shader */\n> -\tif (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n> +\tif (!vertexShader_->compileSourceFile(\":identity.vert\")) {\n>   \t\tqWarning() << \"[ViewFinderGL]:\" << vertexShader_->log();\n>   \t\treturn false;\n>   \t}\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEB3FBDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  3 Nov 2020 18:32:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5369D62BFC;\n\tTue,  3 Nov 2020 19:32:44 +0100 (CET)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A45162B7E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  3 Nov 2020 19:32:42 +0100 (CET)","by mail-lj1-x244.google.com with SMTP id p15so20184974ljj.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Nov 2020 10:32:42 -0800 (PST)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\tf184sm4100129lfd.253.2020.11.03.10.32.40\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 03 Nov 2020 10:32:40 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RCfEBbEy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=z5uMpZ5Cbb/gwgANH8MUCbyKRt3oEtOTNa4jTkiK2DU=;\n\tb=RCfEBbEyuQafJHRhpq5VWzktm/Ly8XXNhmSvUik+9ScmXXm0cyiZeFqhegBSKk3iGD\n\taYY/iKtrxYv6BJFn3SBYAOLzekC3TduDs9936cY6bhZEgWsRkxw+NRVQb/xtyzwrA8tA\n\tkxhFxA/l/9fZlE+jdJCeBrYA40uBlCgGgfrN+KG+a8vnqJIJep2TRt5Qqi/FcuRxhdha\n\tclgtqsL9r0/+WwVPI09Ja39+gCyzy9MJ0Vp39WRHjcQ3PqWgdiJVHBdssbERZLSgvS4q\n\tINPYP7EfZRCHt+OAfn9dVCuA9z0VDWSJMZqiXCYr3RC9HZkvMaSU85EXG0XIgrTV+IlF\n\tUABw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=z5uMpZ5Cbb/gwgANH8MUCbyKRt3oEtOTNa4jTkiK2DU=;\n\tb=RcVj6PKdXCQ+OdQPteh88vxfN60Bm4EoHK3MS/979CLAQPs/3fTZdldHMvG0wgl4jz\n\tHtDK6EeoR2yogyLpZmohoEamVS6R4xkIfuurVI6veXabbcybr7Orwo/hY926F0Z7BWv8\n\tH8xYtJ21q4GzG3LNyKO1pSEGyrcU/+Nfnr9zJ4aMgJ6A8XSkFNWtGAmHZOrGA5OEhxMd\n\tDa3cSTSSh10W3ihtn8/kgY4YaYLfr06H0jVW47xDzLQB7h+y+dttfzpq8dA2fB88I7+n\n\ti+H1wJTrWvqqJ+jOFhp1x04huCDgq/PdIhTL0aq5m8Ky2K51gPb+/TrblSEuOJRBocGK\n\tFQFw==","X-Gm-Message-State":"AOAM530jEmZ5JDEfUG4sUlTfrevQ1hjyDzZChTvbUM0WbVe03z5gLDIA\n\tmrf+kq+s+ZSqSyhsQEzFYvyTynpXcddIOg==","X-Google-Smtp-Source":"ABdhPJxxM/jPEZYceU1dUjTfblgdz01SzBy+oGjGDpjbQXM8Fueld72NPQwQRG7IZ2BDZLZRigrLQA==","X-Received":"by 2002:a2e:81cf:: with SMTP id\n\ts15mr8845016ljg.147.1604428361574; \n\tTue, 03 Nov 2020 10:32:41 -0800 (PST)","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>","From":"Andrey Konovalov <andrey.konovalov@linaro.org>","Message-ID":"<2691a2f3-b4cb-5c07-6349-8190aa2b7b7f@linaro.org>","Date":"Tue, 3 Nov 2020 21:32:39 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13591,"web_url":"https://patchwork.libcamera.org/comment/13591/","msgid":"<7a6341f6-0393-20ee-c45a-9886ade825a5@ideasonboard.com>","date":"2020-11-03T23:02:11","subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 03/11/2020 18:32, Andrey Konovalov wrote:\n> Hi Laurent,\n> \n> Thank you for the patch!\n> \n> On 03.11.2020 18:50, Laurent Pinchart wrote:\n>> In preparation for RGB formats support, rename the identity vertex\n>> shader from YUV.vert to identify.vert.\n> \n> - s/identify/identity in the above line\n> \n> Yes, identity is a better name for this shader.\n> \n> Reviewed-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n\nand then\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> \n> Thanks,\n> Andrey\n> \n>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>> ---\n>>   src/qcam/assets/shader/{YUV.vert => identity.vert} | 2 +-\n>>   src/qcam/assets/shader/shaders.qrc                 | 2 +-\n>>   src/qcam/viewfinder_gl.cpp                         | 2 +-\n>>   3 files changed, 3 insertions(+), 3 deletions(-)\n>>   rename src/qcam/assets/shader/{YUV.vert => identity.vert} (77%)\n>>\n>> diff --git a/src/qcam/assets/shader/YUV.vert\n>> b/src/qcam/assets/shader/identity.vert\n>> similarity index 77%\n>> rename from src/qcam/assets/shader/YUV.vert\n>> rename to src/qcam/assets/shader/identity.vert\n>> index f38e8045db89..6d6f7551017e 100644\n>> --- a/src/qcam/assets/shader/YUV.vert\n>> +++ b/src/qcam/assets/shader/identity.vert\n>> @@ -2,7 +2,7 @@\n>>   /*\n>>    * Copyright (C) 2020, Linaro\n>>    *\n>> - * YUV.vert - Vertex shader for YUV to RGB conversion\n>> + * identity.vert - Identity vertex shader for pixel format conversion\n>>    */\n>>     attribute vec4 vertexIn;\n>> diff --git a/src/qcam/assets/shader/shaders.qrc\n>> b/src/qcam/assets/shader/shaders.qrc\n>> index 857ed9fd5cde..863109146281 100644\n>> --- a/src/qcam/assets/shader/shaders.qrc\n>> +++ b/src/qcam/assets/shader/shaders.qrc\n>> @@ -1,9 +1,9 @@\n>>   <!-- SPDX-License-Identifier: LGPL-2.1-or-later -->\n>>   <!DOCTYPE RCC><RCC version=\"1.0\">\n>>   <qresource>\n>> -    <file>YUV.vert</file>\n>>       <file>YUV_2_planes.frag</file>\n>>       <file>YUV_3_planes.frag</file>\n>>       <file>YUV_packed.frag</file>\n>> +    <file>identity.vert</file>\n>>   </qresource>\n>>   </RCC>\n>> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n>> index dc35d4fd8505..110f0fa673df 100644\n>> --- a/src/qcam/viewfinder_gl.cpp\n>> +++ b/src/qcam/viewfinder_gl.cpp\n>> @@ -191,7 +191,7 @@ bool ViewFinderGL::createVertexShader()\n>>       vertexShader_ =\n>> std::make_unique<QOpenGLShader>(QOpenGLShader::Vertex, this);\n>>         /* Compile the vertex shader */\n>> -    if (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n>> +    if (!vertexShader_->compileSourceFile(\":identity.vert\")) {\n>>           qWarning() << \"[ViewFinderGL]:\" << vertexShader_->log();\n>>           return false;\n>>       }\n>>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6780EBDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  3 Nov 2020 23:02:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3432662C32;\n\tWed,  4 Nov 2020 00:02:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BD1A625AC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  4 Nov 2020 00:02:13 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00AF79E5;\n\tWed,  4 Nov 2020 00:02:12 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r6XY3HPM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604444533;\n\tbh=3jknuhxsA3jXkYpql/Kb5p2BCf5mcDJVBpukBsQM8CE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=r6XY3HPMeQTnQbXYYKkivs9F/NHan7rmIRCPBkGllEgXnscpYiOwl6jYpMgmAvVgx\n\te91uLw89N7sFSCozLT6cZbcFrD1lblmUHjLSlBTS86nk6bg4rXSZxPYD4UEdu4BdG4\n\t+pFYnZT6hsp2toqMr7EmcXtefaXoBSXL5GKhRM0c=","To":"Andrey Konovalov <andrey.konovalov@linaro.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>\n\t<2691a2f3-b4cb-5c07-6349-8190aa2b7b7f@linaro.org>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7a6341f6-0393-20ee-c45a-9886ade825a5@ideasonboard.com>","Date":"Tue, 3 Nov 2020 23:02:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<2691a2f3-b4cb-5c07-6349-8190aa2b7b7f@linaro.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13620,"web_url":"https://patchwork.libcamera.org/comment/13620/","msgid":"<20201106004744.GD3003904@oden.dyn.berto.se>","date":"2020-11-06T00:47:44","subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-11-03 23:02:11 +0000, Kieran Bingham wrote:\n> \n> \n> On 03/11/2020 18:32, Andrey Konovalov wrote:\n> > Hi Laurent,\n> > \n> > Thank you for the patch!\n> > \n> > On 03.11.2020 18:50, Laurent Pinchart wrote:\n> >> In preparation for RGB formats support, rename the identity vertex\n> >> shader from YUV.vert to identify.vert.\n> > \n> > - s/identify/identity in the above line\n> > \n> > Yes, identity is a better name for this shader.\n> > \n> > Reviewed-by: Andrey Konovalov <andrey.konovalov@linaro.org>\n> \n> and then\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nand then and then\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n> \n> > \n> > Thanks,\n> > Andrey\n> > \n> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >> ---\n> >>   src/qcam/assets/shader/{YUV.vert => identity.vert} | 2 +-\n> >>   src/qcam/assets/shader/shaders.qrc                 | 2 +-\n> >>   src/qcam/viewfinder_gl.cpp                         | 2 +-\n> >>   3 files changed, 3 insertions(+), 3 deletions(-)\n> >>   rename src/qcam/assets/shader/{YUV.vert => identity.vert} (77%)\n> >>\n> >> diff --git a/src/qcam/assets/shader/YUV.vert\n> >> b/src/qcam/assets/shader/identity.vert\n> >> similarity index 77%\n> >> rename from src/qcam/assets/shader/YUV.vert\n> >> rename to src/qcam/assets/shader/identity.vert\n> >> index f38e8045db89..6d6f7551017e 100644\n> >> --- a/src/qcam/assets/shader/YUV.vert\n> >> +++ b/src/qcam/assets/shader/identity.vert\n> >> @@ -2,7 +2,7 @@\n> >>   /*\n> >>    * Copyright (C) 2020, Linaro\n> >>    *\n> >> - * YUV.vert - Vertex shader for YUV to RGB conversion\n> >> + * identity.vert - Identity vertex shader for pixel format conversion\n> >>    */\n> >>     attribute vec4 vertexIn;\n> >> diff --git a/src/qcam/assets/shader/shaders.qrc\n> >> b/src/qcam/assets/shader/shaders.qrc\n> >> index 857ed9fd5cde..863109146281 100644\n> >> --- a/src/qcam/assets/shader/shaders.qrc\n> >> +++ b/src/qcam/assets/shader/shaders.qrc\n> >> @@ -1,9 +1,9 @@\n> >>   <!-- SPDX-License-Identifier: LGPL-2.1-or-later -->\n> >>   <!DOCTYPE RCC><RCC version=\"1.0\">\n> >>   <qresource>\n> >> -    <file>YUV.vert</file>\n> >>       <file>YUV_2_planes.frag</file>\n> >>       <file>YUV_3_planes.frag</file>\n> >>       <file>YUV_packed.frag</file>\n> >> +    <file>identity.vert</file>\n> >>   </qresource>\n> >>   </RCC>\n> >> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> >> index dc35d4fd8505..110f0fa673df 100644\n> >> --- a/src/qcam/viewfinder_gl.cpp\n> >> +++ b/src/qcam/viewfinder_gl.cpp\n> >> @@ -191,7 +191,7 @@ bool ViewFinderGL::createVertexShader()\n> >>       vertexShader_ =\n> >> std::make_unique<QOpenGLShader>(QOpenGLShader::Vertex, this);\n> >>         /* Compile the vertex shader */\n> >> -    if (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n> >> +    if (!vertexShader_->compileSourceFile(\":identity.vert\")) {\n> >>           qWarning() << \"[ViewFinderGL]:\" << vertexShader_->log();\n> >>           return false;\n> >>       }\n> >>\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> \n> -- \n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F8D2BE082\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  6 Nov 2020 00:47:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C8AD62D0E;\n\tFri,  6 Nov 2020 01:47:48 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04D5562CAF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  6 Nov 2020 01:47:47 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id i6so5018451lfd.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 05 Nov 2020 16:47:46 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc21sm340019lfm.308.2020.11.05.16.47.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Nov 2020 16:47:45 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"nojQOp7e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Lcn5SMQIhNowYjAN//U8C8u20Cosuj9KCibXhgrXjbY=;\n\tb=nojQOp7eikeLvC5Wn4fAk8tqooPl6Yj4ip/0P1vjF94s/Q7qzjoUue9FixydmCpVah\n\tGue7D0/09pOmoyx30/bMvUqiin70KmGm8lzgr5XilSmnxtAXp2pPLl8MQeVIGoawYDBv\n\tyjvpc6ZHMKPZKFP58AvBa3PXJaYJX3u5iZ6K+F1Nt0MKedc+5lEvbtJUU+p7tN+UpOXa\n\ta+KA2cVEzXh/zicf+9/H8CU6TZvfU1hU3HrvStqXnlbpAe/V8a9VJGFhxtxL6+AKj94y\n\tCRgQ1PtQay3SAU4o9Gx4jVA27zOqPwuQzGgCZl825kTdzgZJgnyi81Gtq3a0CoVKM3Zg\n\tNitA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Lcn5SMQIhNowYjAN//U8C8u20Cosuj9KCibXhgrXjbY=;\n\tb=qWnp0B2nimWPV+UNvUq4AmJoX8BgSIXuSRyMqO4TkkqFgqD6HItMQ7HP+DK+DQ8Knq\n\tFXXavKNCqaUPkgFgCd8yCmv+gf17bn2rqDWpPToYasCe33TvF2j8nYWzvcYPzZTe6osq\n\tfj8tYq/tV94YEIB17HucpkI8tx19V9OxlJ5YXtMbidGwtdPw61AJhqX4HhDgLqenNXkq\n\tHbQw0iNK3d2mntUPuHbTxy2cwEcW8oVoB6v/k0V/p6/TdKQVGS69Ldpj1O/NDmaCuss7\n\tDm0EqtAHpt0a/kdn/Tr+QFlufhUtA9PhZ0GfJqrVFRRBG982yOrOZcBNZRZ80995KBwt\n\tEHrw==","X-Gm-Message-State":"AOAM530YWS4BFugIYGvN7afIHj4kTVvKLj/b78WkNShZZR8mSomOM5Aa\n\trLRIN1dQNikR4BWXrBWm4GM6mw==","X-Google-Smtp-Source":"ABdhPJxv98PN8NgmiPZ716n65CJAoKtay9x7f2yrzmtGeCLoWCuaq7/srCiZyI0n8h5yQpHwOuep5A==","X-Received":"by 2002:ac2:442d:: with SMTP id\n\tw13mr1856187lfl.601.1604623666303; \n\tThu, 05 Nov 2020 16:47:46 -0800 (PST)","Date":"Fri, 6 Nov 2020 01:47:44 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20201106004744.GD3003904@oden.dyn.berto.se>","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>\n\t<2691a2f3-b4cb-5c07-6349-8190aa2b7b7f@linaro.org>\n\t<7a6341f6-0393-20ee-c45a-9886ade825a5@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<7a6341f6-0393-20ee-c45a-9886ade825a5@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename\n\tYUV.vert to identity.vert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]