[{"id":13582,"web_url":"https://patchwork.libcamera.org/comment/13582/","msgid":"","date":"2020-11-03T18:24:41","subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Laurent,\n\nThanks for your patch!\n\nReviewed-by: Andrey Konovalov \n\nThanks,\nAndrey\n\nOn 03.11.2020 18:50, Laurent Pinchart wrote:\n> There's no need to cast the yuvData_ unsigned char pointer to a char\n> pointer before performing pointer arithmetics. Drop the unneeded casts.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/qcam/viewfinder_gl.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index c07292523504..dc35d4fd8505 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB8CFBDB89\n\tfor ;\n\tTue, 3 Nov 2020 18:24:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 630F562BC9;\n\tTue, 3 Nov 2020 19:24:46 +0100 (CET)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC25162B7E\n\tfor ;\n\tTue, 3 Nov 2020 19:24:44 +0100 (CET)","by mail-lf1-x141.google.com with SMTP id e27so666009lfn.7\n\tfor ;\n\tTue, 03 Nov 2020 10:24:44 -0800 (PST)","from [192.168.118.216] ([85.249.41.73])\n\tby smtp.gmail.com with ESMTPSA id\n\t192sm4100239lfo.278.2020.11.03.10.24.42\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 03 Nov 2020 10:24:43 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Gpao0Gb+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=/TCXZYJcAn8LXXFom1BwHqiFTQZTYObr1C724UNkhc8=;\n\tb=Gpao0Gb+NoejvIx8YTcaUA6Clc9QKTCBnCjgNdN2PQnhAif1EyP+8s0hsqJ2p5TjiM\n\t2n5e+OUiMFltr45iSCEiLf/3a0i7FqbTeeryNuNN5yGGJY4VzsH9Gdgaiu5GJz55Wsax\n\tgxJuMQGTDSiffasaEyVREddYIzTffx85FT69F28AWG3zliMAbW80QpIUj7a4bEzGO3/e\n\tOW1FWKaRQazTLdHFseLkFsrHXiEwPMXa4I1V59Ql/UOQxpVfG79pNwam+DIlrzSfGJJj\n\tELNyyduqxujmMtvvtgwUwQEnQb6uLfICGxhShb3EG1WlDskQnAVpgUm75ugix16tEMKo\n\tZv6Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=/TCXZYJcAn8LXXFom1BwHqiFTQZTYObr1C724UNkhc8=;\n\tb=oEER2INRX/tDW5AmTEDAIhrDknTwIS4bHE5mTrIyaWarVutIOQGDW0C4Q4AfJoj6WD\n\tLrJ0loMg/mrBOLEst9Q8BQUq6uWeAvtbcqR/Rc0N7u2I9a5nlv+17dkPu1wGkFqosXvY\n\tHsXGpo7l514OKMAgQfr2Kf9jqTkn3y0dbIQx4U7+eFaO7/DJ9KQYcmFgC56qGG/0H+Ag\n\tlVyZtA/bVeXtVFHOWbzdewP/9DoW1a7Aa+amRScFgRF9wksx2SO58KMJeP4R1DKSmnyS\n\txRTcGM1chEVMV7UDwwwAJUZ1Q2euRfbzZkfTQxmO4x9z6kZkg3mM2QFEmyHAJdqqm0p0\n\tJ9Pw==","X-Gm-Message-State":"AOAM530lSpsmwGA7l5qwTi5FSD32jJJwts/i7ihVKt+T9FYokAPgbOgG\n\t3bcV3FEsFi1AImmJIVETpX+YFw==","X-Google-Smtp-Source":"ABdhPJw0822WWC/AREbALgTb6v/yGFK7IWyOJAIs3qyHy0rPBvTEicO5uWRh3ixzYjr5SaqrlxbZ+w==","X-Received":"by 2002:ac2:58f5:: with SMTP id\n\tv21mr6892447lfo.130.1604427883986; \n\tTue, 03 Nov 2020 10:24:43 -0800 (PST)","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","From":"Andrey Konovalov ","Message-ID":"","Date":"Tue, 3 Nov 2020 21:24:41 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13588,"web_url":"https://patchwork.libcamera.org/comment/13588/","msgid":"<6ac8b1e8-058d-1477-fc7b-94a55baf3f03@ideasonboard.com>","date":"2020-11-03T22:50:36","subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 03/11/2020 15:50, Laurent Pinchart wrote:\n> There's no need to cast the yuvData_ unsigned char pointer to a char\n> pointer before performing pointer arithmetics. Drop the unneeded casts.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/qcam/viewfinder_gl.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index c07292523504..dc35d4fd8505 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DB9BBDB89\n\tfor ;\n\tTue, 3 Nov 2020 22:50:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 381C862BC9;\n\tTue, 3 Nov 2020 23:50:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDE7062067\n\tfor ;\n\tTue, 3 Nov 2020 23:50:39 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 391BA124D;\n\tTue, 3 Nov 2020 23:50:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hEb2mRbS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604443839;\n\tbh=7zIdljh0cNlXv66CF6MM2ug9WPLFl3mf90n2vBaEJt4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=hEb2mRbSU15uCGgkO8mFaS8SH7zAEMkf7uES0C8YfmyGqdA1Y54UQ243bGCXE93eZ\n\t10IAiSko14EFq5pe+BnyHPXeEa8G5wZS0w8BXVmd+/qlVqaga5NeGc2SKb/SlxX40n\n\tZF1shqZMwcLn0BN3Yf9PNnLazxyI0lAPoEXvl3P8=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6ac8b1e8-058d-1477-fc7b-94a55baf3f03@ideasonboard.com>","Date":"Tue, 3 Nov 2020 22:50:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13619,"web_url":"https://patchwork.libcamera.org/comment/13619/","msgid":"<20201106004630.GC3003904@oden.dyn.berto.se>","date":"2020-11-06T00:46:30","subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-11-03 17:50:21 +0200, Laurent Pinchart wrote:\n> There's no need to cast the yuvData_ unsigned char pointer to a char\n> pointer before performing pointer arithmetics. Drop the unneeded casts.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/viewfinder_gl.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index c07292523504..dc35d4fd8505 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -360,7 +360,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RG,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> @@ -390,7 +390,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \n> \t\t/* Activate texture V */\n> @@ -404,7 +404,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \t\tbreak;\n> \n> @@ -434,7 +434,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height());\n> +\t\t\t yuvData_ + size_.width() * size_.height());\n> \t\tshaderProgram_.setUniformValue(textureUniformV_, 2);\n> \n> \t\t/* Activate texture U */\n> @@ -448,7 +448,7 @@ void ViewFinderGL::doRender()\n> \t\t\t 0,\n> \t\t\t GL_RED,\n> \t\t\t GL_UNSIGNED_BYTE,\n> -\t\t\t (char *)yuvData_ + size_.width() * size_.height() * 5 / 4);\n> +\t\t\t yuvData_ + size_.width() * size_.height() * 5 / 4);\n> \t\tshaderProgram_.setUniformValue(textureUniformU_, 1);\n> \t\tbreak;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D29FBDB89\n\tfor ;\n\tFri, 6 Nov 2020 00:46:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B482862CF4;\n\tFri, 6 Nov 2020 01:46:34 +0100 (CET)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27D9362CAF\n\tfor ;\n\tFri, 6 Nov 2020 01:46:33 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id k25so3520320lji.9\n\tfor ;\n\tThu, 05 Nov 2020 16:46:33 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ts13sm286513ljo.34.2020.11.05.16.46.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Nov 2020 16:46:31 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"KpkIRqZi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2Ug1TTeZT0h+Itt3XoefmeMn/x4dE6QGdSYPtA5C9hI=;\n\tb=KpkIRqZiHCKYiocugN8Aemcn2RVbWxfTpw/1tpAK4yl3QP7EZoiZutteaKKE+rEhuy\n\tUVp71A9DYaLjSgWzRe7/4Zi8WH/zTESQslTKPOl7I1sO1vlRTr5AiI8np4VghSrGyxEE\n\tIHY/p4SuDbds2XSfwlEyFEHTe7FgcRfccdjFMgP+2M3P2MWFXN165MxcEzt859zO2wdx\n\tsFXeR8ZeJGBGAxl+kYOOdMaj2NMIhIIJkc7sYV+RAiEeRMP9xnYHzQMCcKfPBoPh0dHO\n\tVwfmOnMo6RQmsOykL7zj9xNkeJc44RrvP9mgC/PsvNcACcOzbBsF8y0midSTk9PU4+0i\n\tCSYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2Ug1TTeZT0h+Itt3XoefmeMn/x4dE6QGdSYPtA5C9hI=;\n\tb=SGhz4ewLjGJB2e6wxO21nlF00pw8RfJt1RbNLx9CTCdX+aleFGzmN4O4HBhmhwYEmK\n\teHGY5KI2ef0wI4dLXr6CRawAlf+9k8qy490N82xbj/amjIFCBzstJqvlk5CfEtIZRHPR\n\t2+IqgZuasHTo8ybDARpErFTTZ0uGO1cgaA/7b85Txuk548L7Li7DYpBazo28LTjFwd8a\n\t4q2PiCRWjDW2bl4GH34x7JHiIp8QF+umZCNqyyTwSJANhr6uW6JlV8fWvyQF4N5Ix2bv\n\tEmBkGT3qYHL1wBMJ3usmCrfgPA9kDttJogLZkX0AFBzUCLL0rpk3qJa8B9DxxVjDhH2D\n\t7Rqw==","X-Gm-Message-State":"AOAM532MEd76c2wCyEQ2PK3I30Fn3dpnL47sEYjRYI1+uDDrvndymMtH\n\tsmcrT35H1xkzvQpm9lwWapknvOBmE1QGYCc5","X-Google-Smtp-Source":"ABdhPJwrjRYQtccdTYhE/U+WcOVFpw1qSPj1gt3LtY1jxBnOjg0w4ZiREcQcxM+1ndGRts4Qxgxd4Q==","X-Received":"by 2002:a2e:7216:: with SMTP id\n\tn22mr1951098ljc.187.1604623592516; \n\tThu, 05 Nov 2020 16:46:32 -0800 (PST)","Date":"Fri, 6 Nov 2020 01:46:30 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201106004630.GC3003904@oden.dyn.berto.se>","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201103155025.5948-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/7] qcam: viewfinder_gl: Remove\n\tunneeded casts","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]