[{"id":13587,"web_url":"https://patchwork.libcamera.org/comment/13587/","msgid":"","date":"2020-11-03T22:49:26","subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: viewfinder_gl: Fix fragment\n\tshader rebuild when setting format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 03/11/2020 15:50, Laurent Pinchart wrote:\n> When setting a new format, the existing fragment shader is deleted and a\n> new shader should be created. However, the shader pointer isn't set to\n> nullptr after deleting it, resulting in the deleter shader being reused.\n> Fix it by managing shader pointers with std::unique_ptr<> to prevent\n> similar bugs from happening in the future.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/qcam/viewfinder_gl.cpp | 19 ++++++-------------\n> src/qcam/viewfinder_gl.h | 6 ++++--\n> 2 files changed, 10 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 0b5c942658cd..03a576ba89d2 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -33,7 +33,6 @@ static const QList supportedFormats{\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> \t: QOpenGLWidget(parent), buffer_(nullptr), yuvData_(nullptr),\n> -\t vertexShader_(nullptr), fragmentShader_(nullptr),\n> \t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> \t textureU_(QOpenGLTexture::Target2D),\n> \t textureV_(QOpenGLTexture::Target2D),\n> @@ -58,8 +57,8 @@ int ViewFinderGL::setFormat(const libcamera::PixelFormat &format,\n> \tif (fragmentShader_) {\n> \t\tif (shaderProgram_.isLinked()) {\n> \t\t\tshaderProgram_.release();\n> -\t\t\tshaderProgram_.removeShader(fragmentShader_);\n> -\t\t\tdelete fragmentShader_;\n> +\t\t\tshaderProgram_.removeShader(fragmentShader_.get());\n> +\t\t\tfragmentShader_.reset();\n> \t\t}\n> \t}\n> \n> @@ -185,7 +184,7 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n> bool ViewFinderGL::createVertexShader()\n> {\n> \t/* Create Vertex Shader */\n> -\tvertexShader_ = new QOpenGLShader(QOpenGLShader::Vertex, this);\n> +\tvertexShader_ = std::make_unique(QOpenGLShader::Vertex, this);\n> \n> \t/* Compile the vertex shader */\n> \tif (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n> @@ -193,7 +192,7 @@ bool ViewFinderGL::createVertexShader()\n> \t\treturn false;\n> \t}\n> \n> -\tshaderProgram_.addShader(vertexShader_);\n> +\tshaderProgram_.addShader(vertexShader_.get());\n> \treturn true;\n> }\n> \n> @@ -207,7 +206,7 @@ bool ViewFinderGL::createFragmentShader()\n> \t * program. The #define macros stored in fragmentShaderDefines_, if\n> \t * any, are prepended to the source code.\n> \t */\n> -\tfragmentShader_ = new QOpenGLShader(QOpenGLShader::Fragment, this);\n> +\tfragmentShader_ = std::make_unique(QOpenGLShader::Fragment, this);\n> \n> \tQFile file(fragmentShaderFile_);\n> \tif (!file.open(QIODevice::ReadOnly | QIODevice::Text)) {\n> @@ -224,7 +223,7 @@ bool ViewFinderGL::createFragmentShader()\n> \t\treturn false;\n> \t}\n> \n> -\tshaderProgram_.addShader(fragmentShader_);\n> +\tshaderProgram_.addShader(fragmentShader_.get());\n> \n> \t/* Link shader pipeline */\n> \tif (!shaderProgram_.link()) {\n> @@ -287,12 +286,6 @@ void ViewFinderGL::removeShader()\n> \t\tshaderProgram_.release();\n> \t\tshaderProgram_.removeAllShaders();\n> \t}\n> -\n> -\tif (fragmentShader_)\n> -\t\tdelete fragmentShader_;\n> -\n> -\tif (vertexShader_)\n> -\t\tdelete vertexShader_;\n> }\n> \n> void ViewFinderGL::initializeGL()\n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index ad1e195e45c7..40c04dc5f877 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -8,6 +8,8 @@\n> #ifndef __VIEWFINDER_GL_H__\n> #define __VIEWFINDER_GL_H__\n> \n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -67,8 +69,8 @@ private:\n> \n> \t/* Shaders */\n> \tQOpenGLShaderProgram shaderProgram_;\n> -\tQOpenGLShader *vertexShader_;\n> -\tQOpenGLShader *fragmentShader_;\n> +\tstd::unique_ptr vertexShader_;\n> +\tstd::unique_ptr fragmentShader_;\n> \tQString fragmentShaderFile_;\n> \tQStringList fragmentShaderDefines_;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21F6DBDB89\n\tfor ;\n\tTue, 3 Nov 2020 22:49:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9929062BC9;\n\tTue, 3 Nov 2020 23:49:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDFD362067\n\tfor ;\n\tTue, 3 Nov 2020 23:49:29 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1E9AF124D;\n\tTue, 3 Nov 2020 23:49:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iI5LHp9I\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604443769;\n\tbh=/sTd07cv0qC/Kr4MmcBx7cMDmn2+UZ2B5n6kjrzg/fQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=iI5LHp9Io24uywYf/Jwvqgdu/paZWtIGtrE+V3OGdXUljiZh8h6hm/Xsk9NpCjydW\n\tiutLjNORb7fgIL6CERTCT/aVVeF86bPcgL3l1ufGhw0UUzEnxUEw5nhmByCfv54mLj\n\tcn5k8v/qex7cBw1R6Ef54JvK70/+LB7hE7vSz3EM=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 3 Nov 2020 22:49:26 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201103155025.5948-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: viewfinder_gl: Fix fragment\n\tshader rebuild when setting format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13617,"web_url":"https://patchwork.libcamera.org/comment/13617/","msgid":"<20201106002450.GA3003904@oden.dyn.berto.se>","date":"2020-11-06T00:24:50","subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: viewfinder_gl: Fix fragment\n\tshader rebuild when setting format","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-11-03 17:50:19 +0200, Laurent Pinchart wrote:\n> When setting a new format, the existing fragment shader is deleted and a\n> new shader should be created. However, the shader pointer isn't set to\n> nullptr after deleting it, resulting in the deleter shader being reused.\n> Fix it by managing shader pointers with std::unique_ptr<> to prevent\n> similar bugs from happening in the future.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/qcam/viewfinder_gl.cpp | 19 ++++++-------------\n> src/qcam/viewfinder_gl.h | 6 ++++--\n> 2 files changed, 10 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\n> index 0b5c942658cd..03a576ba89d2 100644\n> --- a/src/qcam/viewfinder_gl.cpp\n> +++ b/src/qcam/viewfinder_gl.cpp\n> @@ -33,7 +33,6 @@ static const QList supportedFormats{\n> \n> ViewFinderGL::ViewFinderGL(QWidget *parent)\n> \t: QOpenGLWidget(parent), buffer_(nullptr), yuvData_(nullptr),\n> -\t vertexShader_(nullptr), fragmentShader_(nullptr),\n> \t vertexBuffer_(QOpenGLBuffer::VertexBuffer),\n> \t textureU_(QOpenGLTexture::Target2D),\n> \t textureV_(QOpenGLTexture::Target2D),\n> @@ -58,8 +57,8 @@ int ViewFinderGL::setFormat(const libcamera::PixelFormat &format,\n> \tif (fragmentShader_) {\n> \t\tif (shaderProgram_.isLinked()) {\n> \t\t\tshaderProgram_.release();\n> -\t\t\tshaderProgram_.removeShader(fragmentShader_);\n> -\t\t\tdelete fragmentShader_;\n> +\t\t\tshaderProgram_.removeShader(fragmentShader_.get());\n> +\t\t\tfragmentShader_.reset();\n> \t\t}\n> \t}\n> \n> @@ -185,7 +184,7 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n> bool ViewFinderGL::createVertexShader()\n> {\n> \t/* Create Vertex Shader */\n> -\tvertexShader_ = new QOpenGLShader(QOpenGLShader::Vertex, this);\n> +\tvertexShader_ = std::make_unique(QOpenGLShader::Vertex, this);\n> \n> \t/* Compile the vertex shader */\n> \tif (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n> @@ -193,7 +192,7 @@ bool ViewFinderGL::createVertexShader()\n> \t\treturn false;\n> \t}\n> \n> -\tshaderProgram_.addShader(vertexShader_);\n> +\tshaderProgram_.addShader(vertexShader_.get());\n> \treturn true;\n> }\n> \n> @@ -207,7 +206,7 @@ bool ViewFinderGL::createFragmentShader()\n> \t * program. The #define macros stored in fragmentShaderDefines_, if\n> \t * any, are prepended to the source code.\n> \t */\n> -\tfragmentShader_ = new QOpenGLShader(QOpenGLShader::Fragment, this);\n> +\tfragmentShader_ = std::make_unique(QOpenGLShader::Fragment, this);\n> \n> \tQFile file(fragmentShaderFile_);\n> \tif (!file.open(QIODevice::ReadOnly | QIODevice::Text)) {\n> @@ -224,7 +223,7 @@ bool ViewFinderGL::createFragmentShader()\n> \t\treturn false;\n> \t}\n> \n> -\tshaderProgram_.addShader(fragmentShader_);\n> +\tshaderProgram_.addShader(fragmentShader_.get());\n> \n> \t/* Link shader pipeline */\n> \tif (!shaderProgram_.link()) {\n> @@ -287,12 +286,6 @@ void ViewFinderGL::removeShader()\n> \t\tshaderProgram_.release();\n> \t\tshaderProgram_.removeAllShaders();\n> \t}\n> -\n> -\tif (fragmentShader_)\n> -\t\tdelete fragmentShader_;\n> -\n> -\tif (vertexShader_)\n> -\t\tdelete vertexShader_;\n> }\n> \n> void ViewFinderGL::initializeGL()\n> diff --git a/src/qcam/viewfinder_gl.h b/src/qcam/viewfinder_gl.h\n> index ad1e195e45c7..40c04dc5f877 100644\n> --- a/src/qcam/viewfinder_gl.h\n> +++ b/src/qcam/viewfinder_gl.h\n> @@ -8,6 +8,8 @@\n> #ifndef __VIEWFINDER_GL_H__\n> #define __VIEWFINDER_GL_H__\n> \n> +#include \n> +\n> #include \n> #include \n> #include \n> @@ -67,8 +69,8 @@ private:\n> \n> \t/* Shaders */\n> \tQOpenGLShaderProgram shaderProgram_;\n> -\tQOpenGLShader *vertexShader_;\n> -\tQOpenGLShader *fragmentShader_;\n> +\tstd::unique_ptr vertexShader_;\n> +\tstd::unique_ptr fragmentShader_;\n> \tQString fragmentShaderFile_;\n> \tQStringList fragmentShaderDefines_;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B613EBDB89\n\tfor ;\n\tFri, 6 Nov 2020 00:24:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4343A62CF4;\n\tFri, 6 Nov 2020 01:24:54 +0100 (CET)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7337762CAF\n\tfor ;\n\tFri, 6 Nov 2020 01:24:52 +0100 (CET)","by mail-lj1-x241.google.com with SMTP id 11so3512363ljf.2\n\tfor ;\n\tThu, 05 Nov 2020 16:24:52 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tu18sm334260lfl.304.2020.11.05.16.24.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 05 Nov 2020 16:24:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"j+Lpzy53\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=nULkkttWASK6eHHEAouYWomA4EvXvDQ6uMMezcjiQCw=;\n\tb=j+Lpzy53Zav+DrECW1KCoadB+1OdT3/f7CxXM350cE2Q4FqA4OHl2OZZ+TMgK9iQ0R\n\t6yRSU8UiMGAuNGo4F2y95/6SYCyv0afs0kEN3l111Qe4UX8wMMIe0hjsn+ypt/J+gD2y\n\t+4btNwpXeGD7t+e8LYf4qyaQ1J5H83bSNh6JImv/lzFizDy3w5VIygrRM+w8zcK8c33F\n\tTZMz0fjVqu1e4pcgcNwtoz1OZKHhiKjljDicHBOL7Im1f0PC/Z0Oy4U6HonJspRrhTXn\n\ttL1V/ffHEH8CO7jd+yZ3Rq2Sgo6Ktz34tKK5O3Sy7bIgYDA0W8PmNTZfIW9rmuLTwTrG\n\tWj+Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=nULkkttWASK6eHHEAouYWomA4EvXvDQ6uMMezcjiQCw=;\n\tb=chp5GZFAE1blnmeQPilCf5PjVrSq4ZpLyB68duGlWCjDPz0LUcw9Xekka8wCFHZ+wd\n\t8R4z3R/2QpBUGSnIaHI9myFUUW7ytLPMJBNGFPwZD9PGwVtiJXDtPWCTnL8GWShuwbID\n\tyiQM2+E8H9wVyKudl2rurzSLtLgg/ef5xVlP/0en6TDAL7kNgVuOyX7lgdtFyJc/bN01\n\t9r4Pc/9rdnn4O0A1fY/YD+yUNkINjlYD9gnSnNmPQERezgJ3eTh7FtFg72Ubgmc1SN6F\n\t2me/JaI4UKltnxoZBdWQzNy2XO6PQAykzVAJx+57x2yF9BjTrD1Jg9s2bElx0DcCE07S\n\tLB5Q==","X-Gm-Message-State":"AOAM5331DoQyQc0nxTP+G8sLzjVQYAfMWwqJwDQUez0+dvCinuQTQOle\n\tPU1u6tMxvim5xBteGUMjvsUgSNAN3WFdBI1K","X-Google-Smtp-Source":"ABdhPJy9ZjYPVk0TUsfE8KqhiWdMZ+fQRqIlmCMVmmpVRtSL3tVHC9zSR8DznnTtBj//k5TXbldfuw==","X-Received":"by 2002:a2e:89cc:: with SMTP id\n\tc12mr1670564ljk.136.1604622291802; \n\tThu, 05 Nov 2020 16:24:51 -0800 (PST)","Date":"Fri, 6 Nov 2020 01:24:50 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201106002450.GA3003904@oden.dyn.berto.se>","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>\n\t<20201103155025.5948-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201103155025.5948-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/7] qcam: viewfinder_gl: Fix fragment\n\tshader rebuild when setting format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]