[{"id":13573,"web_url":"https://patchwork.libcamera.org/comment/13573/","msgid":"<20201103005658.GB4798@pendragon.ideasonboard.com>","date":"2020-11-03T00:56:58","subject":"Re: [libcamera-devel] [PATCH v4] pipeline: raspberrypi: Add IPA\n\tcall tracepoints","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Fri, Oct 30, 2020 at 06:00:42PM +0900, Paul Elder wrote:\n> Emit tracepoints for IPA calls in the raspberrypi pipeline handler, to\n> allow profiling of IPA calls.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> This patch has been broken out from the rest of the tracing patchset\n> because it depends on IPC, while the others don't. (Unless we want a\n> different pre-IPC version of this patch?)\n\nNo, I think that's fine.\n\n> No change in v4\n> \n> Changes in v3:\n> - rename the tracepoints to ipa_call_begin and ipa_call_end\n> - remove the char * casts for the strings passed to the tracepoints\n> - use the new ipa call tracepoint macros\n> \n> New in v2\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 0a5a7288..07c9c25a 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -31,6 +31,7 @@\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/tracepoints.h\"\n> #include \"libcamera/internal/utils.h\"\n> #include \"libcamera/internal/v4l2_controls.h\"\n> #include \"libcamera/internal/v4l2_videodevice.h\"\n> @@ -1240,6 +1241,8 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n> \n> void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &controls)\n> {\n> +\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalStatReady);\n> +\n> \tif (state_ == State::Stopped)\n> \t\thandleState();\n> \n> @@ -1273,6 +1276,8 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n> \n> void RPiCameraData::runIsp(uint32_t bufferId)\n> {\n> +\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalIspPrepare);\n> +\n> \tif (state_ == State::Stopped)\n> \t\thandleState();\n> \n> @@ -1406,6 +1411,7 @@ void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n> \t * application until after the IPA signals so.\n> \t */\n> \tif (stream == &isp_[Isp::Stats]) {\n> +\t\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalStatReady);\n> \t\tipa_->signalStatReady(RPi::BufferMask::STATS | static_cast(index));\n> \t} else {\n> \t\t/* Any other ISP output can be handed back to the application now. */\n> @@ -1658,7 +1664,9 @@ void RPiCameraData::tryRunPipeline()\n> \t * queue the ISP output buffer listed in the request to start the HW\n> \t * pipeline.\n> \t */\n> +\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalQueueRequest);\n> \tipa_->signalQueueRequest(request->controls());\n> +\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalQueueRequest);\n> \n> \t/* Ready to use the buffers, pop them off the queue. */\n> \tbayerQueue_.pop();\n> @@ -1677,6 +1685,7 @@ void RPiCameraData::tryRunPipeline()\n> \tipa::rpi::IspPreparePayload ispPrepare;\n> \tispPrepare.embeddedbufferId_ = RPi::BufferMask::EMBEDDED_DATA | embeddedId;\n> \tispPrepare.bayerbufferId_ = RPi::BufferMask::BAYER_DATA | bayerId;\n> +\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalIspPrepare);\n> \tipa_->signalIspPrepare(ispPrepare);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32297BDB89\n\tfor ;\n\tTue, 3 Nov 2020 00:57:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A065762B93;\n\tTue, 3 Nov 2020 01:57:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D94AE62B90\n\tfor ;\n\tTue, 3 Nov 2020 01:57:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51960332;\n\tTue, 3 Nov 2020 01:57:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GD6+Nwan\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604365066;\n\tbh=jyGKnuFJ/3wWuOYwKaU0FIIBjgBKTYfbawAMrTVR/X4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GD6+NwanFZkRj0w7a5GINDmLbS/tB3S+oympwtNC8RFyvTSLg1smWZH50CiiC3e2F\n\t0tIHxzFSqs5BYfoJr0lpLVLaIWlmxmHLI/Xsi1nouDTfNosHLsCHpxo4h5ojbwW62O\n\tnkSG/Sr/SAj0fzFIj250qxmdnfp4+tUevT3IKmXg=","Date":"Tue, 3 Nov 2020 02:56:58 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201103005658.GB4798@pendragon.ideasonboard.com>","References":"<20201030090042.79557-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201030090042.79557-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4] pipeline: raspberrypi: Add IPA\n\tcall tracepoints","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]