{"id":10311,"url":"https://patchwork.libcamera.org/api/patches/10311/?format=json","web_url":"https://patchwork.libcamera.org/patch/10311/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201030090042.79557-1-paul.elder@ideasonboard.com>","date":"2020-10-30T09:00:42","name":"[libcamera-devel,v4] pipeline: raspberrypi: Add IPA call tracepoints","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a301261f15cc376e7222b6e9a169c1f46cbde4fe","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10311/mbox/","series":[{"id":1436,"url":"https://patchwork.libcamera.org/api/series/1436/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1436","date":"2020-10-30T09:00:42","name":"[libcamera-devel,v4] pipeline: raspberrypi: Add IPA call tracepoints","version":4,"mbox":"https://patchwork.libcamera.org/series/1436/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10311/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10311/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E71F1BDB9B\n\tfor ;\n\tFri, 30 Oct 2020 09:00:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7306862979;\n\tFri, 30 Oct 2020 10:00:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D967662034\n\tfor ;\n\tFri, 30 Oct 2020 10:00:51 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0955A3D;\n\tFri, 30 Oct 2020 10:00:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q7pr6PM9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604048451;\n\tbh=VPxbW9nIzNNPXl5t6gWyTWv03DcKB83LDcSH4RAiLP0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Q7pr6PM9QNSgeJKr+3CqAQtJUkvdINXb3ObAw9w999amsIHJGyLsIjhUlrEJnqNB1\n\t2EUe62xygU5wvVPTBbGEtdlV+iBZhxgP80QKMqRH5KnEqw+8RztvjmHh3C8qs8mJtP\n\tWodij8JhRwVzC6sVZp2KlOkgOdE4OwBATW203kiE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Oct 2020 18:00:42 +0900","Message-Id":"<20201030090042.79557-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4] pipeline: raspberrypi: Add IPA call\n\ttracepoints","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Emit tracepoints for IPA calls in the raspberrypi pipeline handler, to\nallow profiling of IPA calls.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \n\n---\nThis patch has been broken out from the rest of the tracing patchset\nbecause it depends on IPC, while the others don't. (Unless we want a\ndifferent pre-IPC version of this patch?)\n\nNo change in v4\n\nChanges in v3:\n- rename the tracepoints to ipa_call_begin and ipa_call_end\n- remove the char * casts for the strings passed to the tracepoints\n- use the new ipa call tracepoint macros\n\nNew in v2\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0a5a7288..07c9c25a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -31,6 +31,7 @@\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/tracepoints.h\"\n #include \"libcamera/internal/utils.h\"\n #include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n@@ -1240,6 +1241,8 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \n void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &controls)\n {\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalStatReady);\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1273,6 +1276,8 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n \n void RPiCameraData::runIsp(uint32_t bufferId)\n {\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalIspPrepare);\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1406,6 +1411,7 @@ void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n \t * application until after the IPA signals so.\n \t */\n \tif (stream == &isp_[Isp::Stats]) {\n+\t\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalStatReady);\n \t\tipa_->signalStatReady(RPi::BufferMask::STATS | static_cast(index));\n \t} else {\n \t\t/* Any other ISP output can be handed back to the application now. */\n@@ -1658,7 +1664,9 @@ void RPiCameraData::tryRunPipeline()\n \t * queue the ISP output buffer listed in the request to start the HW\n \t * pipeline.\n \t */\n+\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalQueueRequest);\n \tipa_->signalQueueRequest(request->controls());\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalQueueRequest);\n \n \t/* Ready to use the buffers, pop them off the queue. */\n \tbayerQueue_.pop();\n@@ -1677,6 +1685,7 @@ void RPiCameraData::tryRunPipeline()\n \tipa::rpi::IspPreparePayload ispPrepare;\n \tispPrepare.embeddedbufferId_ = RPi::BufferMask::EMBEDDED_DATA | embeddedId;\n \tispPrepare.bayerbufferId_ = RPi::BufferMask::BAYER_DATA | bayerId;\n+\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalIspPrepare);\n \tipa_->signalIspPrepare(ispPrepare);\n }\n \n","prefixes":["libcamera-devel","v4"]}