[{"id":13565,"web_url":"https://patchwork.libcamera.org/comment/13565/","msgid":"<096ddfa5-e178-81cf-c454-e0820912b23b@uajain.com>","date":"2020-10-30T03:22:07","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nOn 10/30/20 7:11 AM, Laurent Pinchart wrote:\n> The JPEG post-processor is marked as licensed under GPL-2.0-or-later.\n> This is an oversight and unvoluntary. License it under the\n> LGPL-2.1-or-later as the rest of the camera HAL implementation.\n>\n> Signed-off-by: Laurent Pinchart \nOops!\n\nAcked-by: Umang Jain \n\n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> Umang, Hiro-san, as you've both authored commits that touch this file,\n> could you please explicitly reply with an Acked-by ?\n>\n> This is the second time this happens, I think we need a check in either\n> checkstyle.py or in the git pre-push hook.\nI think checking the license would indeed would be a good candidate for \ncheckstyle.py.\n>\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index b9b9dc0042c9..436a50f85664 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8FDABDB1E\n\tfor ;\n\tFri, 30 Oct 2020 03:22:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54C056294E;\n\tFri, 30 Oct 2020 04:22:13 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E0DE620BE\n\tfor ;\n\tFri, 30 Oct 2020 04:22:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"XMejqAB2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1604028130; bh=8ncZjDkTk8sCceEMBNdLO3NQuulhCihgti+nHbKgeU0=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=XMejqAB22nuTdinm/tpMe2tQrW4t7z0P+6KRxiBZHJ9KP3Y5y6j8iVW1GFTLikAIf\n\tuvANADRW9E5NQL69++NK5YTiv5s+mQ9hVajrWM6AorBuoYxM6LxpdVmiRfp1/iqqcg\n\toXddW0tAp/NTWFRFEMj/FEwOgcXbXN6I4spSL4azkRJpmfJWBq5mZ0csXq9nct2afo\n\t34wDPo3JHxtcnaPk6Fq3pRrshZShmOe+6GdeSaId3Kql5ozBw0PV9TBZ6NsjwcTLIi\n\t5bwRpcWdTwcQ5ulhfYjdx1C++TZpsUX5kVoGdAmAYHjyEWLFqFp9XvCoLIvpoBSzwV\n\tqMhmvRTgkEfIQ==","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<096ddfa5-e178-81cf-c454-e0820912b23b@uajain.com>","Date":"Fri, 30 Oct 2020 08:52:07 +0530","Mime-Version":"1.0","In-Reply-To":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13593,"web_url":"https://patchwork.libcamera.org/comment/13593/","msgid":"<20201104075031.GA10287@pendragon.ideasonboard.com>","date":"2020-11-04T07:50:31","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nCould you please ack this patch ?\n\nOn Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote:\n> The JPEG post-processor is marked as licensed under GPL-2.0-or-later.\n> This is an oversight and unvoluntary. License it under the\n> LGPL-2.1-or-later as the rest of the camera HAL implementation.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> Umang, Hiro-san, as you've both authored commits that touch this file,\n> could you please explicitly reply with an Acked-by ?\n> \n> This is the second time this happens, I think we need a check in either\n> checkstyle.py or in the git pre-push hook.\n> \n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index b9b9dc0042c9..436a50f85664 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -1,4 +1,4 @@\n> -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> /*\n> * Copyright (C) 2020, Google Inc.\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA1FCBE080\n\tfor ;\n\tWed, 4 Nov 2020 07:51:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E01562BC9;\n\tWed, 4 Nov 2020 08:51:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9202860344\n\tfor ;\n\tWed, 4 Nov 2020 08:51:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D3C5563;\n\tWed, 4 Nov 2020 08:51:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cPy9121H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604476279;\n\tbh=FJFZv3elhwxR9ZwQewv5GIDXyGKa+vGhu7xowmZfLK8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cPy9121HAW3PLNHz9wZJT/x1OSu0NpUGZsDuWYgaXLYf7lagpFyJ4czDgaY9i9UL9\n\tIrkxJMGXhp3l+p3sApZX4Cc/p9nn3tfuhMR/qDy98ci8lyRN71WuWH+FbjI/MMlD1P\n\t55T4EjOdSszzTzqAwxoKCiFz/hyefYCBs76dUSzA=","Date":"Wed, 4 Nov 2020 09:50:31 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201104075031.GA10287@pendragon.ideasonboard.com>","References":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13714,"web_url":"https://patchwork.libcamera.org/comment/13714/","msgid":"<20201115195910.GC7761@pendragon.ideasonboard.com>","date":"2020-11-15T19:59:10","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nOn Wed, Nov 04, 2020 at 09:50:31AM +0200, Laurent Pinchart wrote:\n> Hi Hiro,\n> \n> Could you please ack this patch ?\n\nPing ?\n\n> On Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote:\n> > The JPEG post-processor is marked as licensed under GPL-2.0-or-later.\n> > This is an oversight and unvoluntary. License it under the\n> > LGPL-2.1-or-later as the rest of the camera HAL implementation.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > Umang, Hiro-san, as you've both authored commits that touch this file,\n> > could you please explicitly reply with an Acked-by ?\n> > \n> > This is the second time this happens, I think we need a check in either\n> > checkstyle.py or in the git pre-push hook.\n> > \n> > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> > index b9b9dc0042c9..436a50f85664 100644\n> > --- a/src/android/jpeg/post_processor_jpeg.cpp\n> > +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> > @@ -1,4 +1,4 @@\n> > -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > /*\n> > * Copyright (C) 2020, Google Inc.\n> > *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E123BE081\n\tfor ;\n\tSun, 15 Nov 2020 19:59:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C53F631D7;\n\tSun, 15 Nov 2020 20:59:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7CB6A631D2\n\tfor ;\n\tSun, 15 Nov 2020 20:59:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29241AF7;\n\tSun, 15 Nov 2020 20:59:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TR8UD+m2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1605470355;\n\tbh=cv7v2L0GL2SD/SShWaJYd3Udar4DHiwfkRObCNj9O3I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TR8UD+m2kcspqcR/v+/ox2l4f/GLlpL1174MEhruqHF+wRPwyLu6IIqD+BRDNTX1s\n\tJO9fGEDTzHvBQwtAa0p0PZBPX0vBiWftZ54YVUiwQ+gRoC7mDUYGr7VnGeiyJ/pjrM\n\t34lz/TQqMw1xstUo6auQ5iZ4W+yZadqGTp9dVfFE=","Date":"Sun, 15 Nov 2020 21:59:10 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"<20201115195910.GC7761@pendragon.ideasonboard.com>","References":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>\n\t<20201104075031.GA10287@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201104075031.GA10287@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13729,"web_url":"https://patchwork.libcamera.org/comment/13729/","msgid":"","date":"2020-11-17T07:37:18","subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Oops, I missed this mail. Sorry for the delay.\n\nOn Mon, Nov 16, 2020 at 4:59 AM Laurent Pinchart\n wrote:\n>\n> Hi Hiro,\n>\n> On Wed, Nov 04, 2020 at 09:50:31AM +0200, Laurent Pinchart wrote:\n> > Hi Hiro,\n> >\n> > Could you please ack this patch ?\n>\n> Ping ?\n>\n> > On Fri, Oct 30, 2020 at 03:41:34AM +0200, Laurent Pinchart wrote:\n> > > The JPEG post-processor is marked as licensed under GPL-2.0-or-later.\n> > > This is an oversight and unvoluntary. License it under the\n> > > LGPL-2.1-or-later as the rest of the camera HAL implementation.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n\nAcked-by: Hirokazu Honda \n\n> > > ---\n> > > src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > Umang, Hiro-san, as you've both authored commits that touch this file,\n> > > could you please explicitly reply with an Acked-by ?\n> > >\n> > > This is the second time this happens, I think we need a check in either\n> > > checkstyle.py or in the git pre-push hook.\n> > >\n> > > diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> > > index b9b9dc0042c9..436a50f85664 100644\n> > > --- a/src/android/jpeg/post_processor_jpeg.cpp\n> > > +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> > > @@ -1,4 +1,4 @@\n> > > -/* SPDX-License-Identifier: GPL-2.0-or-later */\n> > > +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> > > /*\n> > > * Copyright (C) 2020, Google Inc.\n> > > *\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C61FBE081\n\tfor ;\n\tTue, 17 Nov 2020 07:37:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A91E1632E5;\n\tTue, 17 Nov 2020 08:37:30 +0100 (CET)","from mail-ed1-x543.google.com (mail-ed1-x543.google.com\n\t[IPv6:2a00:1450:4864:20::543])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1A8D60338\n\tfor ;\n\tTue, 17 Nov 2020 08:37:29 +0100 (CET)","by mail-ed1-x543.google.com with SMTP id d18so8492990edt.7\n\tfor ;\n\tMon, 16 Nov 2020 23:37:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bDYYbcoi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=eyA5YK54UqXyAfEaD679ma9G1N4HW/QkAIBz75LJUHk=;\n\tb=bDYYbcoid75nZUfvJuCHKtol92sCHrfzDizu5z8l/EwHRDu8E8k9UcEXeT024Kmiii\n\tM1mz90YEM0769EYDYF36H5/uI7fhU8GMkpigE0+dMi5PB5KTJRCeIM6+Wr3E4rm4/4ir\n\tOeyUapOisHnTgihhCtpF/wMVcybzCce/l2OJY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=eyA5YK54UqXyAfEaD679ma9G1N4HW/QkAIBz75LJUHk=;\n\tb=qensrSMESm+Br+/0elO0z84OG7NoN7Ho32oTyUI9/z/eQGdUoivFktgAqgOeTLRF3a\n\t8SO535kdlvUE2t6LgI7ZpwF0rO/jfew4cr5YY9MyK1krNTfMJK3DIjoh7zLJQRuz1E6e\n\t+lUENcIMoEu7kW8T9NRppKboqSeQkbQ09KWIsRkD9WT3b9g5/wR8TQuwmyRUc3qPsblt\n\tUps2QS1iw6Qr3xL/7UhARVF4XrOJdzMbdAIycyHG19Ic4fHKtNUDg05ia2J9CYO1QyGh\n\tHOKc15Qx1wHvIcbUrJxqhFSkhSVxxNyzz0BNEAcXaaLnw3CioxxsoA7X/thN8pOLjUhg\n\twF3w==","X-Gm-Message-State":"AOAM530+AUprUWu4oRpQkDv4cQxhaTxlNEJ2Uvu8SKBeirOW6REARv0T\n\t5lvGARxPRzE8CNoZ8oNu7oNSg9YtuJFKe4NUOsz7LA==","X-Google-Smtp-Source":"ABdhPJySk+iWkA+zF078H8qTXTjQVwKhqwLTKJimWJK4u4pB9sv1rwYVSpYoYZUTsRtva/FIU3004tHQE/XtiHpXfOA=","X-Received":"by 2002:a50:a689:: with SMTP id\n\te9mr19382026edc.233.1605598649423; \n\tMon, 16 Nov 2020 23:37:29 -0800 (PST)","MIME-Version":"1.0","References":"<20201030014134.15851-1-laurent.pinchart@ideasonboard.com>\n\t<20201104075031.GA10287@pendragon.ideasonboard.com>\n\t<20201115195910.GC7761@pendragon.ideasonboard.com>","In-Reply-To":"<20201115195910.GC7761@pendragon.ideasonboard.com>","From":"Hirokazu Honda ","Date":"Tue, 17 Nov 2020 16:37:18 +0900","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH] android: jpeg: Use LGPL-2.1 license\n\tfor post_processor_jpeg.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]