[{"id":13567,"web_url":"https://patchwork.libcamera.org/comment/13567/","msgid":"<8d00610b-75b3-23ef-9ed4-e5f251dd6073@ideasonboard.com>","date":"2020-10-30T09:29:01","subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 30/10/2020 01:37, Laurent Pinchart wrote:\n> We're not using gerrit, so let's prevent Change-Id tags creeping in\n> unadvertently.\n> \n\ns/unadvertently/inadvertently/\n\nHas this happened?\n\nIt /almost/ happened to me, as I committed some code while working in\nthe repository checked out in CrOS, which installs the gerrit hooks.\n\nI saw it and removed it, so to see this pop up 2 days later makes me\ndoubt myself - yet I can't see any Change-Id tags in our tree?\n\n> Signed-off-by: Laurent Pinchart \n\n\nAnyway, - certainly - these can be caught and stripped out.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> utils/hooks/pre-push | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\n> index 2417d379db4c..d13e2c3b506c 100755\n> --- a/utils/hooks/pre-push\n> +++ b/utils/hooks/pre-push\n> @@ -63,6 +63,13 @@ do\n> \t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n> \t\t\terrors=$((errors+1))\n> \t\tfi\n> +\n> +\t\t# 4. The commit message shall not contain a Change-Id.\n> +\t\tif echo \"$msg\" | grep -q '^Change-Id:'\n> +\t\tthen\n> +\t\t\techo >&2 \"Found Change-Id in commit $commit\"\n> +\t\t\terrors=$((errors+1))\n> +\t\tfi\n> \tdone\n> \n> \tif [ $errors != 0 ]\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2621BDB1E\n\tfor ;\n\tFri, 30 Oct 2020 09:29:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D64F762987;\n\tFri, 30 Oct 2020 10:29:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1E2161E4B\n\tfor ;\n\tFri, 30 Oct 2020 10:29:04 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 425BD9B7;\n\tFri, 30 Oct 2020 10:29:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AZ2QtV+a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604050144;\n\tbh=41oMS9JkKKlzD9V4jQdNQHomYtJm1DHPHNmvdLSElcU=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=AZ2QtV+avevqDNJtB1QzNxDOL2Bx3N6SIp1BTZL0fggaiPZMozXKiAmUuGnw871tj\n\t8JbdK3MHBVeTlJVCLmuziYfNjoNcoasrJcJuCu9y9q/PHN8pLs2vEXn879U5iEedoN\n\tkLgThIjxY9/WLSqiKbBhkskymawqAnxGxkAkcGlQ=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<8d00610b-75b3-23ef-9ed4-e5f251dd6073@ideasonboard.com>","Date":"Fri, 30 Oct 2020 09:29:01 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13568,"web_url":"https://patchwork.libcamera.org/comment/13568/","msgid":"<20201030095145.GA185390@oden.dyn.berto.se>","date":"2020-10-30T09:51:45","subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-10-30 03:37:35 +0200, Laurent Pinchart wrote:\n> We're not using gerrit, so let's prevent Change-Id tags creeping in\n> unadvertently.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> utils/hooks/pre-push | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\n> index 2417d379db4c..d13e2c3b506c 100755\n> --- a/utils/hooks/pre-push\n> +++ b/utils/hooks/pre-push\n> @@ -63,6 +63,13 @@ do\n> \t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n> \t\t\terrors=$((errors+1))\n> \t\tfi\n> +\n> +\t\t# 4. The commit message shall not contain a Change-Id.\n> +\t\tif echo \"$msg\" | grep -q '^Change-Id:'\n> +\t\tthen\n> +\t\t\techo >&2 \"Found Change-Id in commit $commit\"\n> +\t\t\terrors=$((errors+1))\n> +\t\tfi\n> \tdone\n> \n> \tif [ $errors != 0 ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F344BBDB9B\n\tfor ;\n\tFri, 30 Oct 2020 09:51:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7947162985;\n\tFri, 30 Oct 2020 10:51:49 +0100 (CET)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2AC8627D7\n\tfor ;\n\tFri, 30 Oct 2020 10:51:47 +0100 (CET)","by mail-lf1-x142.google.com with SMTP id b1so7036700lfp.11\n\tfor ;\n\tFri, 30 Oct 2020 02:51:47 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t73sm571155lff.118.2020.10.30.02.51.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Oct 2020 02:51:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"NgGXLzq1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=gbDqV5Q8lCsyRQ+I9UAuoRzN4FWhSkmMem64RE2ODaY=;\n\tb=NgGXLzq1zsYDu3PjlG5U5Ct5ZWNgVAJtr7KY56CLZRaLvO9MluPS6KHVNTaLwOKlIq\n\tv9HDO5vKNt3EiVpcSEy8OWvRG/BovyQ5L+d2t+mLc/NFlm+gVwwVmLB3XcIVwTILcleQ\n\tnUUAsgFpYWQ/ErFcWGjr6pZ7sVqoY7MiiD3EUmwiVtP4xvuw1chAMts34Nb+UIb36P+l\n\tWFwIK+Ox/wokFtGv8/TalISwYdg0CUYjHidtgJPoLx0fhf27KWvbSMgn0Uf0XeRGEhaS\n\txA5VynC9yciTL+knp3Qpryos47uxOjKhj4RpoUc+k+SdTbZ3xZdAeW3qGe2TtNnJZXIp\n\tuo0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=gbDqV5Q8lCsyRQ+I9UAuoRzN4FWhSkmMem64RE2ODaY=;\n\tb=PVpgvc562GuVWXTJApjhb6GxhrHWueOxbOgLQnWMegLsbtIh06VmOEKL+MWlJKoL3J\n\tYAA1uKDCHbYvPA1Lx8754yzfjw+A48pFyYnpUx6rMTAGVQhyYVo/qangUVedJ3mnCZWb\n\tnsIfPfzkatKa47lfzJMFH/6aKiJK+k+4Sjzzdm5v41UhuiLwH/vhBGqW+54aWE/vTSV1\n\tMuJRd+vbYw9Ac13p2VgBY2yIIrYqFr5SD+0CH/VmWvRFSZzGaxWMFp7cUnaaTUbBusNf\n\tD4s2ylP7BF+kUVBwS38FXhMnrVSgXe+lw8mclh8m7TybOis6uVWVhOnU4UMwTI5kC4/4\n\tWJvQ==","X-Gm-Message-State":"AOAM533ddQdvGtZkePkH5fj3jGT9Q+FPtiPqVzLgb+2IoSvwNLtgzNiG\n\t5mRijXol3RPV1QO6J0y/a7GQaQ==","X-Google-Smtp-Source":"ABdhPJxPHeyuhmvJ8WI3kPsRDbKTIGa2mcyWPiqekOZrjbWXEPnOKYW2AliRYKRRzc2j9nNRbj7ySA==","X-Received":"by 2002:a19:514:: with SMTP id 20mr555241lff.512.1604051507122; \n\tFri, 30 Oct 2020 02:51:47 -0700 (PDT)","Date":"Fri, 30 Oct 2020 10:51:45 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20201030095145.GA185390@oden.dyn.berto.se>","References":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13569,"web_url":"https://patchwork.libcamera.org/comment/13569/","msgid":"<20201030130311.GA4412@pendragon.ideasonboard.com>","date":"2020-10-30T13:03:11","subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Oct 30, 2020 at 09:29:01AM +0000, Kieran Bingham wrote:\n> On 30/10/2020 01:37, Laurent Pinchart wrote:\n> > We're not using gerrit, so let's prevent Change-Id tags creeping in\n> > unadvertently.\n> > \n> \n> s/unadvertently/inadvertently/\n> \n> Has this happened?\n\ngit log will answer that question :-) It has happened once, in\nb2b8c4dc941b979ddf5e9013530e76c67e6a12fe.\n\n> It /almost/ happened to me, as I committed some code while working in\n> the repository checked out in CrOS, which installs the gerrit hooks.\n> \n> I saw it and removed it, so to see this pop up 2 days later makes me\n> doubt myself - yet I can't see any Change-Id tags in our tree?\n> \n> > Signed-off-by: Laurent Pinchart \n> \n> Anyway, - certainly - these can be caught and stripped out.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > utils/hooks/pre-push | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\n> > index 2417d379db4c..d13e2c3b506c 100755\n> > --- a/utils/hooks/pre-push\n> > +++ b/utils/hooks/pre-push\n> > @@ -63,6 +63,13 @@ do\n> > \t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n> > \t\t\terrors=$((errors+1))\n> > \t\tfi\n> > +\n> > +\t\t# 4. The commit message shall not contain a Change-Id.\n> > +\t\tif echo \"$msg\" | grep -q '^Change-Id:'\n> > +\t\tthen\n> > +\t\t\techo >&2 \"Found Change-Id in commit $commit\"\n> > +\t\t\terrors=$((errors+1))\n> > +\t\tfi\n> > \tdone\n> > \n> > \tif [ $errors != 0 ]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E69BBDB1E\n\tfor ;\n\tFri, 30 Oct 2020 13:04:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92AFA6288A;\n\tFri, 30 Oct 2020 14:04:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1756E6034B\n\tfor ;\n\tFri, 30 Oct 2020 14:04:01 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7757F9B7;\n\tFri, 30 Oct 2020 14:04:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZXfnZ0If\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604063040;\n\tbh=bqCxOTfhBYHT7xeo+iUUI5Ukm78KG0tvn6oRAZtynAk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZXfnZ0IfhL7gHdvJeMg6VjBPDJWnYTc+VBpIzdTBmEqGHf56K60UkT59DbTVLF0z9\n\tEPsV/CGKy2UU3WctiluENx9WTjb2PoRW7fZ2xISX+CRtac1LBGy4f+bisHbzIalyKy\n\t2LoOh12aLYfGmItJJdHqZXA2XLYV4bKbkdKxUjq8=","Date":"Fri, 30 Oct 2020 15:03:11 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201030130311.GA4412@pendragon.ideasonboard.com>","References":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>\n\t<8d00610b-75b3-23ef-9ed4-e5f251dd6073@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<8d00610b-75b3-23ef-9ed4-e5f251dd6073@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13570,"web_url":"https://patchwork.libcamera.org/comment/13570/","msgid":"","date":"2020-10-30T13:27:41","subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 30/10/2020 13:03, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Fri, Oct 30, 2020 at 09:29:01AM +0000, Kieran Bingham wrote:\n>> On 30/10/2020 01:37, Laurent Pinchart wrote:\n>>> We're not using gerrit, so let's prevent Change-Id tags creeping in\n>>> unadvertently.\n>>>\n>>\n>> s/unadvertently/inadvertently/\n>>\n>> Has this happened?\n> \n> git log will answer that question :-) It has happened once, in\n> b2b8c4dc941b979ddf5e9013530e76c67e6a12fe.\n> \n>> It /almost/ happened to me, as I committed some code while working in\n>> the repository checked out in CrOS, which installs the gerrit hooks.\n>>\n>> I saw it and removed it, so to see this pop up 2 days later makes me\n>> doubt myself - yet I can't see any Change-Id tags in our tree?\n>>\n\nSee I knew it would be me ;-)\n\n--\nKieran\n\n\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> Anyway, - certainly - these can be caught and stripped out.\n>>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> ---\n>>> utils/hooks/pre-push | 7 +++++++\n>>> 1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push\n>>> index 2417d379db4c..d13e2c3b506c 100755\n>>> --- a/utils/hooks/pre-push\n>>> +++ b/utils/hooks/pre-push\n>>> @@ -63,6 +63,13 @@ do\n>>> \t\t\techo >&2 \"No Reviewed-by or Acked-by in commit $commit\"\n>>> \t\t\terrors=$((errors+1))\n>>> \t\tfi\n>>> +\n>>> +\t\t# 4. The commit message shall not contain a Change-Id.\n>>> +\t\tif echo \"$msg\" | grep -q '^Change-Id:'\n>>> +\t\tthen\n>>> +\t\t\techo >&2 \"Found Change-Id in commit $commit\"\n>>> +\t\t\terrors=$((errors+1))\n>>> +\t\tfi\n>>> \tdone\n>>> \n>>> \tif [ $errors != 0 ]\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 89B90BDB9B\n\tfor ;\n\tFri, 30 Oct 2020 13:27:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 020C26288A;\n\tFri, 30 Oct 2020 14:27:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A0396034B\n\tfor ;\n\tFri, 30 Oct 2020 14:27:47 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0D0B9B7;\n\tFri, 30 Oct 2020 14:27:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wDv3VZzk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604064466;\n\tbh=46/DgC8wx9fNk748y0xcoz50gPEDMfn4hH5M5raHkds=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=wDv3VZzkBxtozG5DhRox9s5BSrHfxuqnhZmOUQyf6QKjOPLRcJ3ckYCp/cbItHylB\n\tjXuRloTqnvAoTkdgH/6gPdeQF7TXTdXp086tdkzT/Am2k5pl+hJxeUrrreiI+c15pQ\n\tuBjLkPllA9yAsrOZzT56fEaa2GVFci9fyPLTU0gY=","To":"Laurent Pinchart ","References":"<20201030013735.15603-1-laurent.pinchart@ideasonboard.com>\n\t<8d00610b-75b3-23ef-9ed4-e5f251dd6073@ideasonboard.com>\n\t<20201030130311.GA4412@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 30 Oct 2020 13:27:41 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201030130311.GA4412@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] utils: hooks: pre-push: Reject\n\tcommits with a Change-Id","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]