[{"id":13557,"web_url":"https://patchwork.libcamera.org/comment/13557/","msgid":"<20201029185436.wpjaf5qapo4leava@uno.localdomain>","date":"2020-10-29T18:54:36","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix typo in\n\tdescription","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Sebastian,\n\nOn Thu, Oct 29, 2020 at 08:33:05AM +0100, Sebastian Fricke wrote:\n> The class IPAManager has no method ipaCreate, but the method createIPA.\n>\n> s/pipeline handlers call the IPAManager::ipaCreate()\n> /pipeline handlers call the IPAManager::createIPA()\n>\n> Signed-off-by: Sebastian Fricke \n\nThanks\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> src/libcamera/ipa_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 046fd5c..ad05b9c 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -43,7 +43,7 @@ LOG_DEFINE_CATEGORY(IPAManager)\n> * The isolation mechanism ensures that no code from a closed-source module is\n> * ever run in the libcamera process.\n> *\n> - * To create an IPA context, pipeline handlers call the IPAManager::ipaCreate()\n> + * To create an IPA context, pipeline handlers call the IPAManager::createIPA()\n> * method. For a directly loaded module, the manager calls the module's\n> * ipaCreate() function directly and wraps the returned context in an\n> * IPAContextWrapper that exposes an IPAInterface.\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12D42BDB9B\n\tfor ;\n\tThu, 29 Oct 2020 18:54:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0692628A5;\n\tThu, 29 Oct 2020 19:54:37 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DB5F600F6\n\tfor ;\n\tThu, 29 Oct 2020 19:54:37 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D7542C000A;\n\tThu, 29 Oct 2020 18:54:36 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 29 Oct 2020 19:54:36 +0100","From":"Jacopo Mondi ","To":"Sebastian Fricke ","Message-ID":"<20201029185436.wpjaf5qapo4leava@uno.localdomain>","References":"<20201029073305.12803-1-sebastian.fricke.linux@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201029073305.12803-1-sebastian.fricke.linux@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix typo in\n\tdescription","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13563,"web_url":"https://patchwork.libcamera.org/comment/13563/","msgid":"<20201030015727.GQ15024@pendragon.ideasonboard.com>","date":"2020-10-30T01:57:27","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix typo in\n\tdescription","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sebastian,\n\nThank you for the patch.\n\nOn Thu, Oct 29, 2020 at 08:33:05AM +0100, Sebastian Fricke wrote:\n> The class IPAManager has no method ipaCreate, but the method createIPA.\n> \n> s/pipeline handlers call the IPAManager::ipaCreate()\n> /pipeline handlers call the IPAManager::createIPA()\n> \n> Signed-off-by: Sebastian Fricke \n\nReviewed-by: Laurent Pinchart \n\nI'll push this in a moment.\n\n> ---\n> src/libcamera/ipa_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 046fd5c..ad05b9c 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -43,7 +43,7 @@ LOG_DEFINE_CATEGORY(IPAManager)\n> * The isolation mechanism ensures that no code from a closed-source module is\n> * ever run in the libcamera process.\n> *\n> - * To create an IPA context, pipeline handlers call the IPAManager::ipaCreate()\n> + * To create an IPA context, pipeline handlers call the IPAManager::createIPA()\n> * method. For a directly loaded module, the manager calls the module's\n> * ipaCreate() function directly and wraps the returned context in an\n> * IPAContextWrapper that exposes an IPAInterface.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2C07BDB1E\n\tfor ;\n\tFri, 30 Oct 2020 01:58:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54D47628F9;\n\tFri, 30 Oct 2020 02:58:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9298E60353\n\tfor ;\n\tFri, 30 Oct 2020 02:58:16 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CB1A9B7;\n\tFri, 30 Oct 2020 02:58:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y41dyxav\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604023096;\n\tbh=aJwMscmodsvx1kK/sKdsCgKoEPb82W/BblmRhoIqs1o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y41dyxavdC6pxj4Qya4tdrEHpNiYWj/ROhAo/JcQPXj7dEvRZp/agq5Bz3oT/DRHt\n\tcThGOobqR1mQ27VPkYJHhsEI+6tzNGemDnstYp16sPnJ8a01BEb9j8soyTyvzgB8V+\n\tSHSu+xOQUrNF1GJgsmtVd1ikTCZZWujBxS1ATT1A=","Date":"Fri, 30 Oct 2020 03:57:27 +0200","From":"Laurent Pinchart ","To":"Sebastian Fricke ","Message-ID":"<20201030015727.GQ15024@pendragon.ideasonboard.com>","References":"<20201029073305.12803-1-sebastian.fricke.linux@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201029073305.12803-1-sebastian.fricke.linux@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipa_manager: Fix typo in\n\tdescription","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]