{"id":10290,"url":"https://patchwork.libcamera.org/api/patches/10290/?format=json","web_url":"https://patchwork.libcamera.org/patch/10290/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201028103151.34575-4-paul.elder@ideasonboard.com>","date":"2020-10-28T10:31:49","name":"[libcamera-devel,v2,4/6] pipeline: raspberrypi: Add IPA call tracepoints","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"c9a61fa95dd501df424c2bf01c58acd875fbdaca","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10290/mbox/","series":[{"id":1428,"url":"https://patchwork.libcamera.org/api/series/1428/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1428","date":"2020-10-28T10:31:46","name":"[libcamera-devel,v2,1/6] libcamera: tracing: Implement tracing infrastructure","version":2,"mbox":"https://patchwork.libcamera.org/series/1428/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10290/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10290/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06E98BDB1E\n\tfor ;\n\tWed, 28 Oct 2020 10:32:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5146625F5;\n\tWed, 28 Oct 2020 11:32:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3E8B62067\n\tfor ;\n\tWed, 28 Oct 2020 11:32:07 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52F60B95;\n\tWed, 28 Oct 2020 11:32:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vramt9DL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603881127;\n\tbh=wwEgF6bKhjW005jowIXVR22ZTCtwzTyTBVkycKHI+eE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=vramt9DLeKeJn93hG8aTywhA/fG9Kq3FeV7/mwdAAhi+m/c2cg1w/NHKseRhdcJCH\n\tcws+6fxjge5d66hI/ypq1iNhWzX3r2RkQkMdsLuWigugQWzPNZmeosE1Dj/sv6OInk\n\t4qscig00d0E2Ybkf6nnVtFGvcQosZX09v8uhBzc4=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 28 Oct 2020 19:31:49 +0900","Message-Id":"<20201028103151.34575-4-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201028103151.34575-1-paul.elder@ideasonboard.com>","References":"<20201028103151.34575-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/6] pipeline: raspberrypi: Add IPA\n\tcall tracepoints","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Emit tracepoints for IPA calls in the raspberrypi pipeline handler, to\nallow profiling of IPA calls.\n\nSigned-off-by: Paul Elder \n\n---\nNew in v2\n\nI was getting compiler complaints when I passed direct strings to the\ntracepoint without casting... I wasn't getting it in tests...\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0a5a7288..2de60d3d 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -31,6 +31,7 @@\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/tracepoints.h\"\n #include \"libcamera/internal/utils.h\"\n #include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n@@ -1240,6 +1241,8 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \n void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &controls)\n {\n+\tLIBCAMERA_TRACEPOINT(ipa_call_finish, (char *)\"rpi\", (char *)\"signalStatReady\");\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1273,6 +1276,8 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n \n void RPiCameraData::runIsp(uint32_t bufferId)\n {\n+\tLIBCAMERA_TRACEPOINT(ipa_call_finish, (char *)\"rpi\", (char *)\"signalIspPrepare\");\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1406,6 +1411,7 @@ void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n \t * application until after the IPA signals so.\n \t */\n \tif (stream == &isp_[Isp::Stats]) {\n+\t\tLIBCAMERA_TRACEPOINT(ipa_call_start, (char *)\"rpi\", (char *)\"signalStatReady\");\n \t\tipa_->signalStatReady(RPi::BufferMask::STATS | static_cast(index));\n \t} else {\n \t\t/* Any other ISP output can be handed back to the application now. */\n@@ -1658,7 +1664,9 @@ void RPiCameraData::tryRunPipeline()\n \t * queue the ISP output buffer listed in the request to start the HW\n \t * pipeline.\n \t */\n+\tLIBCAMERA_TRACEPOINT(ipa_call_start, (char *)\"rpi\", (char *)\"signalQueueRequest\");\n \tipa_->signalQueueRequest(request->controls());\n+\tLIBCAMERA_TRACEPOINT(ipa_call_finish, (char *)\"rpi\", (char *)\"signalQueueRequest\");\n \n \t/* Ready to use the buffers, pop them off the queue. */\n \tbayerQueue_.pop();\n@@ -1677,6 +1685,7 @@ void RPiCameraData::tryRunPipeline()\n \tipa::rpi::IspPreparePayload ispPrepare;\n \tispPrepare.embeddedbufferId_ = RPi::BufferMask::EMBEDDED_DATA | embeddedId;\n \tispPrepare.bayerbufferId_ = RPi::BufferMask::BAYER_DATA | bayerId;\n+\tLIBCAMERA_TRACEPOINT(ipa_call_start, (char *)\"rpi\", (char *)\"signalIspPrepare\");\n \tipa_->signalIspPrepare(ispPrepare);\n }\n \n","prefixes":["libcamera-devel","v2","4/6"]}