[{"id":13543,"web_url":"https://patchwork.libcamera.org/comment/13543/","msgid":"<20201028235616.GD10030@pendragon.ideasonboard.com>","date":"2020-10-28T23:56:16","subject":"Re: [libcamera-devel] [PATCH v2 3/6] tracepoints: Add pipeline\n\ttracepoints for tracing IPA calls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul\n\nThank you for the patch.\n\nOn Wed, Oct 28, 2020 at 07:31:48PM +0900, Paul Elder wrote:\n> Add a pair of tracepoints to a general pipeline tracepoints file,\n> libcamera:ipa_call_start and libcamera:ipa_call_finish, to trace IPA\n> calls. This allows us to obtain the time taken for the IPA call.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v2\n> ---\n> .../internal/tracepoints/meson.build | 1 +\n> .../internal/tracepoints/pipeline.tp | 25 +++++++++++++++++++\n> 2 files changed, 26 insertions(+)\n> create mode 100644 include/libcamera/internal/tracepoints/pipeline.tp\n> \n> diff --git a/include/libcamera/internal/tracepoints/meson.build b/include/libcamera/internal/tracepoints/meson.build\n> index 8410c205..a34135ce 100644\n> --- a/include/libcamera/internal/tracepoints/meson.build\n> +++ b/include/libcamera/internal/tracepoints/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> tracepoint_files = files([\n> + 'pipeline.tp',\n> 'request.tp',\n> ])\n> diff --git a/include/libcamera/internal/tracepoints/pipeline.tp b/include/libcamera/internal/tracepoints/pipeline.tp\n> new file mode 100644\n> index 00000000..603f4a8c\n> --- /dev/null\n> +++ b/include/libcamera/internal/tracepoints/pipeline.tp\n> @@ -0,0 +1,25 @@\n> +TRACEPOINT_EVENT(\n> +\tlibcamera,\n> +\tipa_call_start,\n\nI would have called this ipa_call_begin and the next one ipa_call_end,\nbut I'm not sure why, so feel free to ignore :-)\n\n> +\tTP_ARGS(\n> +\t\tchar *, pipe,\n> +\t\tchar *, func\n\nMaybe const char * is all you need to fix the cast issue in your next\npatch ?\n\nReviewed-by: Laurent Pinchart \n\n> +\t),\n> +\tTP_FIELDS(\n> +\t\tctf_string(pipeline_name, pipe)\n> +\t\tctf_string(function_name, func)\n> +\t)\n> +)\n> +\n> +TRACEPOINT_EVENT(\n> +\tlibcamera,\n> +\tipa_call_finish,\n> +\tTP_ARGS(\n> +\t\tchar *, pipe,\n> +\t\tchar *, func\n> +\t),\n> +\tTP_FIELDS(\n> +\t\tctf_string(pipeline_name, pipe)\n> +\t\tctf_string(function_name, func)\n> +\t)\n> +)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1FF5BDB1E\n\tfor ;\n\tWed, 28 Oct 2020 23:57:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD20C62825;\n\tThu, 29 Oct 2020 00:57:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 26C19627A2\n\tfor ;\n\tThu, 29 Oct 2020 00:57:05 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC103576;\n\tThu, 29 Oct 2020 00:57:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ffo30Say\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603929424;\n\tbh=aMo95Nepj5liTOdDylPUysGEdG2MKQ4jj8JVgtlk5a8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ffo30SayU34JKLJYoaL9vZW8elbNzSCU344PCNwv5YOvKkLQQEmapJ5ajAqp1esx1\n\t0ahEGEI37I/SDNBqkSwfUisT8iyViCZfhI6vLbwv4/Flxq/aEgQRTfA2249RCioT6t\n\tirmotQEHUNg5CPAxyA2nBzJVSO3wD7nANGMb99DQ=","Date":"Thu, 29 Oct 2020 01:56:16 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201028235616.GD10030@pendragon.ideasonboard.com>","References":"<20201028103151.34575-1-paul.elder@ideasonboard.com>\n\t<20201028103151.34575-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201028103151.34575-3-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] tracepoints: Add pipeline\n\ttracepoints for tracing IPA calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]