[{"id":13530,"web_url":"https://patchwork.libcamera.org/comment/13530/","msgid":"<819d2de9-2d4b-8ca9-46b0-ca99be2fa6d8@ideasonboard.com>","date":"2020-10-28T10:18:49","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Mark\n\tToPixelFormat() a const function","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Hiro-san,\n\nOn 28/10/2020 09:50, Hirokazu Honda wrote:\n> CameraDevice::ToPixelFormat() doesn't change the state of the\n\ns/ToPixelFormat/toPixelFormat/\n\n> CameraDevice. Marks it a const function so that it can be called\n> in const functions.\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> src/android/camera_device.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index ca60f51..6369d49 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1188,7 +1188,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \treturn requestTemplate->get();\n> }\n> \n> -PixelFormat CameraDevice::toPixelFormat(int format)\n> +PixelFormat CameraDevice::toPixelFormat(int format) const\n> {\n> \t/* Translate Android format code to libcamera pixel format. */\n> \tauto it = formatsMap_.find(format);\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index fd08738..45efcf4 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -104,7 +104,7 @@ private:\n> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n> \tCameraMetadata *requestTemplatePreview();\n> -\tlibcamera::PixelFormat toPixelFormat(int format);\n> +\tlibcamera::PixelFormat toPixelFormat(int format) const;\n> \tstd::unique_ptr getResultMetadata(int frame_number,\n> \t\t\t\t\t\t\t int64_t timestamp);\n> \n> --\n> 2.29.0.rc2.309.g374f81d7ae-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D1F6C3B5C\n\tfor ;\n\tWed, 28 Oct 2020 10:18:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4C1162230;\n\tWed, 28 Oct 2020 11:18:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B89C562034\n\tfor ;\n\tWed, 28 Oct 2020 11:18:52 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CFD699A;\n\tWed, 28 Oct 2020 11:18:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ox5inXNI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603880332;\n\tbh=lHjLtRQmGvE9ROBkzCyjwEugum7G0j4wr8xx8vwBlSI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ox5inXNIpVb8yr8Oy69G/5CIo6rbMxfZci0/iXyyGp20YXxNabVsF6+C5wWnE/QmZ\n\tgpQoOBzJj55mFZjvlpvibDSwUUQNR4fQ85yAfrxRb4yOOhg0ZA6xpEALLCyf0TjtRt\n\txbnXvTfF+NluuDTPn66uR6yuYvfSnaC8dgba2HiA=","To":"Hirokazu Honda , libcamera-devel@lists.libcamera.org","References":"<20201028095023.3004701-1-hiroh@chromium.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<819d2de9-2d4b-8ca9-46b0-ca99be2fa6d8@ideasonboard.com>","Date":"Wed, 28 Oct 2020 10:18:49 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201028095023.3004701-1-hiroh@chromium.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Mark\n\tToPixelFormat() a const function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13535,"web_url":"https://patchwork.libcamera.org/comment/13535/","msgid":"<20201028130847.GA591661@oden.dyn.berto.se>","date":"2020-10-28T13:08:47","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Mark\n\tToPixelFormat() a const function","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Hirokazu-san,\n\nThanks for your work.\n\nOn 2020-10-28 18:50:23 +0900, Hirokazu Honda wrote:\n> CameraDevice::ToPixelFormat() doesn't change the state of the\n> CameraDevice. Marks it a const function so that it can be called\n> in const functions.\n> \n> Signed-off-by: Hirokazu Honda \n\nWith the typo pointed out by Kieran fixed,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> src/android/camera_device.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index ca60f51..6369d49 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1188,7 +1188,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n> \treturn requestTemplate->get();\n> }\n> \n> -PixelFormat CameraDevice::toPixelFormat(int format)\n> +PixelFormat CameraDevice::toPixelFormat(int format) const\n> {\n> \t/* Translate Android format code to libcamera pixel format. */\n> \tauto it = formatsMap_.find(format);\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index fd08738..45efcf4 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -104,7 +104,7 @@ private:\n> \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n> \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n> \tCameraMetadata *requestTemplatePreview();\n> -\tlibcamera::PixelFormat toPixelFormat(int format);\n> +\tlibcamera::PixelFormat toPixelFormat(int format) const;\n> \tstd::unique_ptr getResultMetadata(int frame_number,\n> \t\t\t\t\t\t\t int64_t timestamp);\n> \n> --\n> 2.29.0.rc2.309.g374f81d7ae-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBB92BDB1E\n\tfor ;\n\tWed, 28 Oct 2020 13:08:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 571AE62679;\n\tWed, 28 Oct 2020 14:08:53 +0100 (CET)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 164A76052D\n\tfor ;\n\tWed, 28 Oct 2020 14:08:52 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id x16so6269673ljh.2\n\tfor ;\n\tWed, 28 Oct 2020 06:08:52 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t127sm587787ljf.118.2020.10.28.06.08.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 28 Oct 2020 06:08:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"lA1VDZCz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xH0gNML/epSvrFJsRskmvlNN4AbFFjSL5WItkG64zdo=;\n\tb=lA1VDZCzMkgQlwi7bjVbnT6Bh+TBLsvtlQ6t+Tki2ocZ5ngVgBJ1I1TCp3RnetzPtC\n\t3iARZuMU/O82utwj82IlSMDuGgMhHRJ31pFgbNfspmfj6iYAqVKJTiLPqeXYqltpqwSr\n\t3VzxORw3qspoVCv77vHBUCJlUGe8K+4PlLhuKJU7TNGexOWB3J7RUENv9g98ptSNIJel\n\trY4Umdcef+rMONRnLUFL/nKZLSh01PlsoiAZkZiTYpnujuAfMIVE+suYVr7qWeqe9hSa\n\tvljRXDs1gOFfnNMRDomt5/s1KJulY31E3lMR8OIoRgGCVWYmElE0MlgkhuYzSvLvW2rw\n\t1ssg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xH0gNML/epSvrFJsRskmvlNN4AbFFjSL5WItkG64zdo=;\n\tb=lQBW3yWL1elZUrgX9ebhVx6FFDN6CkNBE/eLABmcC449KoXAhmw77wsd6w+9GoERtj\n\tWq3tqwZ2xl5/e8e/wJ20PAP1AW2GvvYJIaYtT24zLrr0Pe1BmEDABSjb68H4jAin1F8d\n\t4tOE2Zj40tsJDbbpR1kd2gf1csrbGeTeTR9e2LCEfSZwXn3oAHk4a194KMxSD0L9KTrv\n\t35uQUvsCKLjjTV4LYFwFZTVU5rNJZhzWJG3OgItoYWNX7mw7Bf3M/SRodwxr/OPnWBBU\n\tB+dVCeQFzqYYn/ZcL5YJe55d5mUHwiryWEQyRBAXjfPYF3FOCjXyUoBoK8+ay203Xhny\n\t0Zqw==","X-Gm-Message-State":"AOAM530E5zOmbOxwzom7TtW8K6zso0Ye2bbjQCszsr/nfWSJTQ7igYz1\n\tLuyze3UkAN8Eq+d+PUePifVbdTgHKdyalA==","X-Google-Smtp-Source":"ABdhPJy0XlGvsgAsbpVzluBnCbkWUAvDl2A5aywU5JtoCJGdZE791Nb6GV0LUa2jwUz2BWSB2V/YqA==","X-Received":"by 2002:a05:651c:105b:: with SMTP id\n\tx27mr3272232ljm.302.1603890531453; \n\tWed, 28 Oct 2020 06:08:51 -0700 (PDT)","Date":"Wed, 28 Oct 2020 14:08:47 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Hirokazu Honda ","Message-ID":"<20201028130847.GA591661@oden.dyn.berto.se>","References":"<20201028095023.3004701-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201028095023.3004701-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Mark\n\tToPixelFormat() a const function","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]