{"id":1028,"url":"https://patchwork.libcamera.org/api/patches/1028/?format=json","web_url":"https://patchwork.libcamera.org/patch/1028/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190417135858.23914-6-jacopo@jmondi.org>","date":"2019-04-17T13:58:55","name":"[libcamera-devel,v7,5/8] libcamera: request: Add hasPendingBuffers() method","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"26cf6e32eb76d727bc269486eb61f39c7033ae43","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1028/mbox/","series":[{"id":254,"url":"https://patchwork.libcamera.org/api/series/254/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=254","date":"2019-04-17T13:58:50","name":"libcamera: Framework changes to prepare for multiple streams support","version":7,"mbox":"https://patchwork.libcamera.org/series/254/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1028/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1028/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD59F60DBF\n\tfor ;\n\tWed, 17 Apr 2019 15:58:19 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D119D40002;\n\tWed, 17 Apr 2019 13:58:18 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Apr 2019 15:58:55 +0200","Message-Id":"<20190417135858.23914-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190417135858.23914-1-jacopo@jmondi.org>","References":"<20190417135858.23914-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v7 5/8] libcamera: request: Add\n\thasPendingBuffers() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 17 Apr 2019 13:58:19 -0000"},"content":"Add method to verify if a request has pending buffers yet to be\ncompleted.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/request.h | 2 ++\n src/libcamera/request.cpp | 12 ++++++++++--\n 2 files changed, 12 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 0dbd425115e8..0188bcab8383 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -37,6 +37,8 @@ public:\n \n \tStatus status() const { return status_; }\n \n+\tbool hasPendingBuffers() const { return !pending_.empty(); }\n+\n private:\n \tfriend class Camera;\n \tfriend class PipelineHandler;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex e0e77e972411..e5c25d2c6988 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -106,6 +106,14 @@ Buffer *Request::findBuffer(Stream *stream) const\n * \\return The request completion status\n */\n \n+/**\n+ * \\fn Request::hasPendingBuffers()\n+ * \\brief Check if a request has buffers yet to be completed\n+ *\n+ * \\return True if the request has buffers pending for completion, false\n+ * otherwise\n+ */\n+\n /**\n * \\brief Prepare the resources for the completion handler\n */\n@@ -127,7 +135,7 @@ int Request::prepare()\n */\n void Request::complete(Status status)\n {\n-\tASSERT(pending_.empty());\n+\tASSERT(!hasPendingBuffers());\n \tstatus_ = status;\n }\n \n@@ -149,7 +157,7 @@ bool Request::completeBuffer(Buffer *buffer)\n \tint ret = pending_.erase(buffer);\n \tASSERT(ret == 1);\n \n-\treturn pending_.empty();\n+\treturn !hasPendingBuffers();\n }\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","v7","5/8"]}