[{"id":13523,"web_url":"https://patchwork.libcamera.org/comment/13523/","msgid":"<20201028011523.GI3967@pendragon.ideasonboard.com>","date":"2020-10-28T01:15:23","subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: jpeg: Introduce a\n\tsimple image thumbnailer","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Wed, Oct 28, 2020 at 02:54:46AM +0530, Umang Jain wrote:\n> Add a basic image Thumbnailer class for the frames being captured.\n> Currently, the thumbnailer can scale NV12 frames. It shall be used\n> to generate a thumbnail image for EXIF metadata, in the subsequent\n> commit.\n> \n> Signed-off-by: Umang Jain <email@uajain.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/android/jpeg/thumbnailer.cpp | 113 +++++++++++++++++++++++++++++++\n>  src/android/jpeg/thumbnailer.h   |  36 ++++++++++\n>  src/android/meson.build          |   1 +\n>  3 files changed, 150 insertions(+)\n>  create mode 100644 src/android/jpeg/thumbnailer.cpp\n>  create mode 100644 src/android/jpeg/thumbnailer.h\n> \n> diff --git a/src/android/jpeg/thumbnailer.cpp b/src/android/jpeg/thumbnailer.cpp\n> new file mode 100644\n> index 0000000..2e3c478\n> --- /dev/null\n> +++ b/src/android/jpeg/thumbnailer.cpp\n> @@ -0,0 +1,113 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * thumbnailer.cpp - Simple image thumbnailer\n> + */\n> +\n> +#include \"thumbnailer.h\"\n> +\n> +#include <libcamera/formats.h>\n> +\n> +#include \"libcamera/internal/log.h\"\n> +\n> +using namespace libcamera;\n> +\n> +LOG_DEFINE_CATEGORY(Thumbnailer)\n> +\n> +Thumbnailer::Thumbnailer()\n> +\t: valid_(false)\n> +{\n> +}\n> +\n> +void Thumbnailer::configure(const Size &sourceSize, PixelFormat pixelFormat)\n> +{\n> +\tsourceSize_ = sourceSize;\n> +\tpixelFormat_ = pixelFormat;\n> +\n> +\tif (pixelFormat_ != formats::NV12) {\n> +\t\tLOG (Thumbnailer, Error)\n> +\t\t\t<< \"Failed to configure: Pixel Format \"\n> +\t\t\t<< pixelFormat_.toString() << \" unsupported.\";\n> +\t\treturn;\n> +\t}\n> +\n> +\ttargetSize_ = computeThumbnailSize();\n> +\n> +\tvalid_ = true;\n> +}\n> +\n> +/*\n> + * The Exif specification recommends the width of the thumbnail to be a\n> + * multiple of 16 (section 4.8.1). Hence, compute the corresponding height\n> + * keeping the aspect ratio same as of the source.\n> + */\n> +Size Thumbnailer::computeThumbnailSize() const\n> +{\n> +\tunsigned int targetHeight;\n> +\tconstexpr unsigned int kTargetWidth = 160;\n> +\n> +\ttargetHeight = kTargetWidth * sourceSize_.height / sourceSize_.width;\n> +\n> +\tif (targetHeight & 1)\n> +\t\ttargetHeight++;\n> +\n> +\treturn Size(kTargetWidth, targetHeight);\n> +}\n> +\n> +void\n> +Thumbnailer::createThumbnail(const FrameBuffer &source,\n> +\t\t\t     std::vector<unsigned char> *destination)\n> +{\n> +\tMappedFrameBuffer frame(&source, PROT_READ);\n> +\tif (!frame.isValid()) {\n> +\t\tLOG(Thumbnailer, Error)\n> +\t\t\t<< \"Failed to map FrameBuffer : \"\n> +\t\t\t<< strerror(frame.error());\n> +\t\treturn;\n> +\t}\n> +\n> +\tif (!valid_) {\n> +\t\tLOG(Thumbnailer, Error) << \"Config is unconfigured or invalid.\";\n> +\t\treturn;\n> +\t}\n> +\n> +\tconst unsigned int sw = sourceSize_.width;\n> +\tconst unsigned int sh = sourceSize_.height;\n> +\tconst unsigned int tw = targetSize_.width;\n> +\tconst unsigned int th = targetSize_.height;\n> +\n> +\tASSERT(tw % 2 == 0 && th % 2 == 0);\n> +\n> +\t/* Image scaling block implementing nearest-neighbour algorithm. */\n> +\tunsigned char *src = static_cast<unsigned char *>(frame.maps()[0].data());\n> +\tunsigned char *srcC = src + sh * sw;\n> +\tunsigned char *srcCb, *srcCr;\n> +\tunsigned char *dstY, *srcY;\n> +\n> +\tsize_t dstSize = (th * tw) + ((th / 2) * tw);\n> +\tdestination->resize(dstSize);\n> +\tunsigned char *dst = destination->data();\n> +\tunsigned char *dstC = dst + th * tw;\n> +\n> +\tfor (unsigned int y = 0; y < th; y += 2) {\n> +\t\tunsigned int sourceY = (sh * y + th / 2) / th;\n> +\n> +\t\tdstY = dst + y * tw;\n> +\t\tsrcY = src + sw * sourceY;\n> +\t\tsrcCb = srcC + (sourceY / 2) * sw + 0;\n> +\t\tsrcCr = srcC + (sourceY / 2) * sw + 1;\n> +\n> +\t\tfor (unsigned int x = 0; x < tw; x += 2) {\n> +\t\t\tunsigned int sourceX = (sw * x + tw / 2) / tw;\n> +\n> +\t\t\tdstY[x] = srcY[sourceX];\n> +\t\t\tdstY[tw + x] = srcY[sw + sourceX];\n> +\t\t\tdstY[x + 1] = srcY[sourceX + 1];\n> +\t\t\tdstY[tw + x + 1] = srcY[sw + sourceX + 1];\n> +\n> +\t\t\tdstC[(y / 2) * tw + x + 0] = srcCb[(sourceX / 2) * 2];\n> +\t\t\tdstC[(y / 2) * tw + x + 1] = srcCr[(sourceX / 2) * 2];\n> +\t\t}\n> +\t}\n> +}\n> diff --git a/src/android/jpeg/thumbnailer.h b/src/android/jpeg/thumbnailer.h\n> new file mode 100644\n> index 0000000..16e6951\n> --- /dev/null\n> +++ b/src/android/jpeg/thumbnailer.h\n> @@ -0,0 +1,36 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * thumbnailer.h - Simple image thumbnailer\n> + */\n> +#ifndef __ANDROID_JPEG_THUMBNAILER_H__\n> +#define __ANDROID_JPEG_THUMBNAILER_H__\n> +\n> +#include <libcamera/geometry.h>\n> +\n> +#include \"libcamera/internal/buffer.h\"\n> +#include \"libcamera/internal/formats.h\"\n> +\n> +class Thumbnailer\n> +{\n> +public:\n> +\tThumbnailer();\n> +\n> +\tvoid configure(const libcamera::Size &sourceSize,\n> +\t\t       libcamera::PixelFormat pixelFormat);\n> +\tvoid createThumbnail(const libcamera::FrameBuffer &source,\n> +\t\t\t     std::vector<unsigned char> *dest);\n> +\tconst libcamera::Size& size() const { return targetSize_; }\n> +\n> +private:\n> +\tlibcamera::Size computeThumbnailSize() const;\n> +\n> +\tlibcamera::PixelFormat pixelFormat_;\n> +\tlibcamera::Size sourceSize_;\n> +\tlibcamera::Size targetSize_;\n> +\n> +\tbool valid_;\n> +};\n> +\n> +#endif /* __ANDROID_JPEG_THUMBNAILER_H__ */\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index f72376a..3d4d3be 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -25,6 +25,7 @@ android_hal_sources = files([\n>      'jpeg/encoder_libjpeg.cpp',\n>      'jpeg/exif.cpp',\n>      'jpeg/post_processor_jpeg.cpp',\n> +    'jpeg/thumbnailer.cpp',\n>  ])\n>  \n>  android_camera_metadata_sources = files([","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB666BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Oct 2020 01:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5714A6223C;\n\tWed, 28 Oct 2020 02:16:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 076EF6034B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Oct 2020 02:16:12 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 711E599A;\n\tWed, 28 Oct 2020 02:16:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cyIiG2Ga\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603847771;\n\tbh=5bzI8uRZ72F+0zaUR1flDcRr+lCBBRRI94RMjf9kGxA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cyIiG2Ga5vrakisOynNcawE2XfNE+vtdtsrGlARH/ZXzvLf4MGgWkAieWm0lUDeDr\n\td18vZKjEBcbLarR/BXlkGa9QIQFjxn9cajeOA7LefUIgODbuggp5fM3TSdZUGfW3aS\n\tLkJkUYIHqe67FLrhFe1d2gusk2HJ5SzG6PafgehQ=","Date":"Wed, 28 Oct 2020 03:15:23 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Umang Jain <email@uajain.com>","Message-ID":"<20201028011523.GI3967@pendragon.ideasonboard.com>","References":"<20201027212447.131431-1-email@uajain.com>\n\t<20201027212447.131431-3-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201027212447.131431-3-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: jpeg: Introduce a\n\tsimple image thumbnailer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13538,"web_url":"https://patchwork.libcamera.org/comment/13538/","msgid":"<31ea3d16-d912-d75a-040f-a143fde47f71@ideasonboard.com>","date":"2020-10-28T14:36:09","subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: jpeg: Introduce a\n\tsimple image thumbnailer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Umang,\n\nOn 27/10/2020 21:24, Umang Jain wrote:\n> Add a basic image Thumbnailer class for the frames being captured.\n> Currently, the thumbnailer can scale NV12 frames. It shall be used\n> to generate a thumbnail image for EXIF metadata, in the subsequent\n> commit.\n> \n> Signed-off-by: Umang Jain <email@uajain.com>\n> ---\n>  src/android/jpeg/thumbnailer.cpp | 113 +++++++++++++++++++++++++++++++\n>  src/android/jpeg/thumbnailer.h   |  36 ++++++++++\n>  src/android/meson.build          |   1 +\n>  3 files changed, 150 insertions(+)\n>  create mode 100644 src/android/jpeg/thumbnailer.cpp\n>  create mode 100644 src/android/jpeg/thumbnailer.h\n> \n> diff --git a/src/android/jpeg/thumbnailer.cpp b/src/android/jpeg/thumbnailer.cpp\n> new file mode 100644\n> index 0000000..2e3c478\n> --- /dev/null\n> +++ b/src/android/jpeg/thumbnailer.cpp\n> @@ -0,0 +1,113 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * thumbnailer.cpp - Simple image thumbnailer\n> + */\n> +\n> +#include \"thumbnailer.h\"\n> +\n> +#include <libcamera/formats.h>\n> +\n> +#include \"libcamera/internal/log.h\"\n> +\n> +using namespace libcamera;\n> +\n> +LOG_DEFINE_CATEGORY(Thumbnailer)\n> +\n> +Thumbnailer::Thumbnailer()\n> +\t: valid_(false)\n> +{\n> +}\n> +\n> +void Thumbnailer::configure(const Size &sourceSize, PixelFormat pixelFormat)\n> +{\n> +\tsourceSize_ = sourceSize;\n> +\tpixelFormat_ = pixelFormat;\n> +\n> +\tif (pixelFormat_ != formats::NV12) {\n> +\t\tLOG (Thumbnailer, Error)\n> +\t\t\t<< \"Failed to configure: Pixel Format \"\n> +\t\t\t<< pixelFormat_.toString() << \" unsupported.\";\n> +\t\treturn;\n> +\t}\n> +\n> +\ttargetSize_ = computeThumbnailSize();\n> +\n> +\tvalid_ = true;\n> +}\n> +\n> +/*\n> + * The Exif specification recommends the width of the thumbnail to be a\n> + * multiple of 16 (section 4.8.1). Hence, compute the corresponding height\n> + * keeping the aspect ratio same as of the source.\n> + */\n> +Size Thumbnailer::computeThumbnailSize() const\n> +{\n> +\tunsigned int targetHeight;\n> +\tconstexpr unsigned int kTargetWidth = 160;\n> +\n> +\ttargetHeight = kTargetWidth * sourceSize_.height / sourceSize_.width;\n> +\n> +\tif (targetHeight & 1)\n> +\t\ttargetHeight++;\n> +\n> +\treturn Size(kTargetWidth, targetHeight);\n> +}\n> +\n> +void\n> +Thumbnailer::createThumbnail(const FrameBuffer &source,\n> +\t\t\t     std::vector<unsigned char> *destination)\n\nCheckstyle complains here.\n\nSeems your githook was disabled, but fixed now ;-)\n\nI'll fix up these small style warnings locally, as I think these patches\nare ready to push. Just testing and we'll see.\n\n\n> +{\n> +\tMappedFrameBuffer frame(&source, PROT_READ);\n> +\tif (!frame.isValid()) {\n> +\t\tLOG(Thumbnailer, Error)\n> +\t\t\t<< \"Failed to map FrameBuffer : \"\n> +\t\t\t<< strerror(frame.error());\n> +\t\treturn;\n> +\t}\n> +\n> +\tif (!valid_) {\n> +\t\tLOG(Thumbnailer, Error) << \"Config is unconfigured or invalid.\";\n> +\t\treturn;\n> +\t}\n> +\n> +\tconst unsigned int sw = sourceSize_.width;\n> +\tconst unsigned int sh = sourceSize_.height;\n> +\tconst unsigned int tw = targetSize_.width;\n> +\tconst unsigned int th = targetSize_.height;\n> +\n> +\tASSERT(tw % 2 == 0 && th % 2 == 0);\n> +\n> +\t/* Image scaling block implementing nearest-neighbour algorithm. */\n> +\tunsigned char *src = static_cast<unsigned char *>(frame.maps()[0].data());\n> +\tunsigned char *srcC = src + sh * sw;\n> +\tunsigned char *srcCb, *srcCr;\n> +\tunsigned char *dstY, *srcY;\n> +\n> +\tsize_t dstSize = (th * tw) + ((th / 2) * tw);\n> +\tdestination->resize(dstSize);\n> +\tunsigned char *dst = destination->data();\n> +\tunsigned char *dstC = dst + th * tw;\n> +\n> +\tfor (unsigned int y = 0; y < th; y += 2) {\n> +\t\tunsigned int sourceY = (sh * y + th / 2) / th;\n> +\n> +\t\tdstY = dst + y * tw;\n> +\t\tsrcY = src + sw * sourceY;\n> +\t\tsrcCb = srcC + (sourceY / 2) * sw + 0;\n> +\t\tsrcCr = srcC + (sourceY / 2) * sw + 1;\n> +\n> +\t\tfor (unsigned int x = 0; x < tw; x += 2) {\n> +\t\t\tunsigned int sourceX = (sw * x + tw / 2) / tw;\n> +\n> +\t\t\tdstY[x] = srcY[sourceX];\n> +\t\t\tdstY[tw + x] = srcY[sw + sourceX];\n> +\t\t\tdstY[x + 1] = srcY[sourceX + 1];\n> +\t\t\tdstY[tw + x + 1] = srcY[sw + sourceX + 1];\n> +\n> +\t\t\tdstC[(y / 2) * tw + x + 0] = srcCb[(sourceX / 2) * 2];\n> +\t\t\tdstC[(y / 2) * tw + x + 1] = srcCr[(sourceX / 2) * 2];\n> +\t\t}\n> +\t}\n> +}\n> diff --git a/src/android/jpeg/thumbnailer.h b/src/android/jpeg/thumbnailer.h\n> new file mode 100644\n> index 0000000..16e6951\n> --- /dev/null\n> +++ b/src/android/jpeg/thumbnailer.h\n> @@ -0,0 +1,36 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2020, Google Inc.\n> + *\n> + * thumbnailer.h - Simple image thumbnailer\n> + */\n> +#ifndef __ANDROID_JPEG_THUMBNAILER_H__\n> +#define __ANDROID_JPEG_THUMBNAILER_H__\n> +\n> +#include <libcamera/geometry.h>\n> +\n> +#include \"libcamera/internal/buffer.h\"\n> +#include \"libcamera/internal/formats.h\"\n> +\n> +class Thumbnailer\n> +{\n> +public:\n> +\tThumbnailer();\n> +\n> +\tvoid configure(const libcamera::Size &sourceSize,\n> +\t\t       libcamera::PixelFormat pixelFormat);\n> +\tvoid createThumbnail(const libcamera::FrameBuffer &source,\n> +\t\t\t     std::vector<unsigned char> *dest);\n> +\tconst libcamera::Size& size() const { return targetSize_; }\n\nAlso\n/Size& size/Size &size/\n\nBut I'll fix.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> +\n> +private:\n> +\tlibcamera::Size computeThumbnailSize() const;\n> +\n> +\tlibcamera::PixelFormat pixelFormat_;\n> +\tlibcamera::Size sourceSize_;\n> +\tlibcamera::Size targetSize_;\n> +\n> +\tbool valid_;\n> +};\n> +\n> +#endif /* __ANDROID_JPEG_THUMBNAILER_H__ */\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index f72376a..3d4d3be 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -25,6 +25,7 @@ android_hal_sources = files([\n>      'jpeg/encoder_libjpeg.cpp',\n>      'jpeg/exif.cpp',\n>      'jpeg/post_processor_jpeg.cpp',\n> +    'jpeg/thumbnailer.cpp',\n>  ])\n>  \n>  android_camera_metadata_sources = files([\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 433B4BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Oct 2020 14:36:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6383626E7;\n\tWed, 28 Oct 2020 15:36:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6E6162679\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Oct 2020 15:36:13 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D53899A;\n\tWed, 28 Oct 2020 15:36:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ao9trbnb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603895773;\n\tbh=EQeJ4nVw5SoxFe8zz8yA4eJwck+J+lufwXNW3LC1Hiw=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=Ao9trbnbqD7IOaZNeqDhXebQeAYlB/8HRXEYPOLk916DynFS7/gAIy4K1LY/R1a2X\n\tCIGK0SpEd/AySCmsmPhJ+iJwP2CzKRySPkJq7ciTWDgI4ykionROq/gWxtpfy1iGmB\n\tB5CKD2HTRhYC+4/6Hy+StZYLDy/aOeiojNd76l4c=","To":"Umang Jain <email@uajain.com>, libcamera-devel@lists.libcamera.org","References":"<20201027212447.131431-1-email@uajain.com>\n\t<20201027212447.131431-3-email@uajain.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<31ea3d16-d912-d75a-040f-a143fde47f71@ideasonboard.com>","Date":"Wed, 28 Oct 2020 14:36:09 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201027212447.131431-3-email@uajain.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] android: jpeg: Introduce a\n\tsimple image thumbnailer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]