[{"id":1439,"web_url":"https://patchwork.libcamera.org/comment/1439/","msgid":"<20190417153623.GN28515@bigcity.dyn.berto.se>","date":"2019-04-17T15:36:23","subject":"Re: [libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device:\n\tPropagate releaseBuffers() error","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-04-17 15:58:54 +0200, Jacopo Mondi wrote:\n> The error code returned by requestBuffers(0) was not propagated to the\n> caller. Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/v4l2_device.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 4cc4a6d656b1..d394632dad4c 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()\n> {\n> \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n> \n> -\trequestBuffers(0);\n> \tbufferPool_ = nullptr;\n> \n> -\treturn 0;\n> +\treturn requestBuffers(0);\n> }\n> \n> /**\n> -- \n> 2.21.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5738560DBF\n\tfor ;\n\tWed, 17 Apr 2019 17:36:25 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id y6so22843281ljd.12\n\tfor ;\n\tWed, 17 Apr 2019 08:36:25 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\th6sm2654833lfp.1.2019.04.17.08.36.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 17 Apr 2019 08:36:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=VEah222+/k24RiLs4Mrhwj76tDEWLT6yPXsYT/0fS5U=;\n\tb=tTeM2u70nMopTLRsa8KSbHeAOKAvTOCJc3yRpjmhbGFrHj7wzN9Zj7Pl/vH71UYfah\n\ts5qIKbSW9fR0LfWhnb2FiBAEdc4E+x4ACubAnE9MFA0zayNrz1lvqgV/W7+ghLKSW0sx\n\tW8NRzQRdN0aetZ5YXmDmv2iBOzl5W2VzNh0L8xzZmpmo/YFs2lBe57SwQacPWSCWffdA\n\tiVN/PjfauSiPtn6tjksVr0OgKsUgwUrQGmTkG1fuyBxp3X1hiht/X2vPNssmSr7QXAcF\n\tlZMbm8HkUp93agOIBaYl2FF29aZ0uukxKCTqavPBzyM0kYpPS+kLlMkvdBYCEiPAOqtN\n\tMlYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=VEah222+/k24RiLs4Mrhwj76tDEWLT6yPXsYT/0fS5U=;\n\tb=uYwSwkTYmtgk4dlztBeUvwjwoxC9Zw2gEOQ4aQr1fiNfyXGnColaO7ejK/hE3t15ai\n\ty8JyFBYZD/8/tguMZyOHl3AYJNn8klaB/yzEpgMjOWUWinM7mwPuefB5g0tEaUWF6Os0\n\txp3GT05Tvk8m4cs0r/Wkub43v/CDlsI+u4FAc2+uVpMvvYKBn9V1ZqT7257AAT/7F+Mt\n\tt/nto18iR5byBCgskR8x11W1P8sqBzTNbw+5KDMuKM23vbY1Cfg83/Dt+ISQMmFB36x/\n\t2eWxf8cnAOxZ5pBEJPPqJngm5u995mM+qf5Z1smpK+0iGBpMlyv0Wrq0+mR9uAIdJBi3\n\tpHPg==","X-Gm-Message-State":"APjAAAWbhN0E5ZCewLsTkqCHblwlhGx1IB//c+kh/kIRqNv+7S/XJZ6R\n\tRT2pWnRvvJs7CvBUhMph3518ZQ==","X-Google-Smtp-Source":"APXvYqxsSkEG0Z4gZFFVPFlxh8EMe++2Y5FPWWjVwB6SLaBzfNMdPzPcp6MDqUN1TugEFy72hEc/zw==","X-Received":"by 2002:a2e:219:: with SMTP id 25mr47325538ljc.34.1555515384704; \n\tWed, 17 Apr 2019 08:36:24 -0700 (PDT)","Date":"Wed, 17 Apr 2019 17:36:23 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190417153623.GN28515@bigcity.dyn.berto.se>","References":"<20190417135858.23914-1-jacopo@jmondi.org>\n\t<20190417135858.23914-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190417135858.23914-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device:\n\tPropagate releaseBuffers() error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 17 Apr 2019 15:36:25 -0000"}},{"id":1447,"web_url":"https://patchwork.libcamera.org/comment/1447/","msgid":"<20190418124935.GN4806@pendragon.ideasonboard.com>","date":"2019-04-18T12:49:35","subject":"Re: [libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device:\n\tPropagate releaseBuffers() error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Apr 17, 2019 at 03:58:54PM +0200, Jacopo Mondi wrote:\n> The error code returned by requestBuffers(0) was not propagated to the\n> caller. Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_device.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 4cc4a6d656b1..d394632dad4c 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()\n> {\n> \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n> \n> -\trequestBuffers(0);\n> \tbufferPool_ = nullptr;\n> \n> -\treturn 0;\n> +\treturn requestBuffers(0);\n> }\n> \n> /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E58B660DC0\n\tfor ;\n\tThu, 18 Apr 2019 14:49:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F2906333;\n\tThu, 18 Apr 2019 14:49:44 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555591785;\n\tbh=PkCC1FmeW67e8hnO+i1epj+XkzaoZglQeVXCJW3koAs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rZSP29OursGaDcL9wTtPKwELe15OgcZC5oXfTunEjfk5OcwNMNDG9SVy0q5HgbIfB\n\ttGYUsSb9dcIvgEszGBrczOJB5NY0AadaXGJJu9tfCTEXUl5Wcra1Cm/YXwE4BA4tJs\n\t3rS8Rnel4ikfn4a/1QS1XXHtMrmNn1SXt8CTtsw4=","Date":"Thu, 18 Apr 2019 15:49:35 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190418124935.GN4806@pendragon.ideasonboard.com>","References":"<20190417135858.23914-1-jacopo@jmondi.org>\n\t<20190417135858.23914-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190417135858.23914-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device:\n\tPropagate releaseBuffers() error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 18 Apr 2019 12:49:46 -0000"}}]