{"id":10264,"url":"https://patchwork.libcamera.org/api/patches/10264/?format=json","web_url":"https://patchwork.libcamera.org/patch/10264/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201026195209.16748-2-laurent.pinchart@ideasonboard.com>","date":"2020-10-26T19:52:09","name":"[libcamera-devel,2/2] libcamera: span: Provide and use helper variable templates for type traits","commit_ref":"8e42c2feb7ff7c350ffbbf97dd963dfd54e21faa","pull_url":null,"state":"accepted","archived":false,"hash":"e83ae54920f501d4b2cfb6ed7f4adcb7be998714","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10264/mbox/","series":[{"id":1418,"url":"https://patchwork.libcamera.org/api/series/1418/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1418","date":"2020-10-26T19:52:08","name":"[libcamera-devel,1/2] libcamera: Use helper variable template for type traits","version":1,"mbox":"https://patchwork.libcamera.org/series/1418/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10264/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10264/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E7D5C3B5C\n\tfor ;\n\tMon, 26 Oct 2020 19:53:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 699206206A;\n\tMon, 26 Oct 2020 20:53:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A29B862061\n\tfor ;\n\tMon, 26 Oct 2020 20:53:00 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3699C99A\n\tfor ;\n\tMon, 26 Oct 2020 20:53:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wfJPrqhs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603741980;\n\tbh=MrO6OGgCI+mXrOCH279xYT2MX2jADb78wPiScIMZZP4=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=wfJPrqhs/Rc1Ch+GKSOAX4lo4NpA9BwhCS0Uqx4qt45Ya0aaY6YxWrOCm/HCNrwd6\n\tn+VRgEtQQ3rUfy0ksMz5VoQQKhfjIxT28eXkMSLDTXGioIWmT9jIUWK9oAr5EWI81z\n\tV0b95+PJQbqLIGzv6eeOdnPPAUIfx0MKPzW06NFg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 26 Oct 2020 21:52:09 +0200","Message-Id":"<20201026195209.16748-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201026195209.16748-1-laurent.pinchart@ideasonboard.com>","References":"<20201026195209.16748-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: span: Provide and use\n\thelper variable templates for type traits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Following the C++17 practice, provide is_array_v and is_span_v\nhelper variable templates as shorter versions of is_array::value and\nis_span::value, and use them through the code.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/controls.h | 12 ++++++------\n include/libcamera/span.h | 22 ++++++++++++++--------\n 2 files changed, 20 insertions(+), 14 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex dc549a92f975..3634dc431618 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -96,7 +96,7 @@ public:\n \tControlValue();\n \n #ifndef __DOXYGEN__\n-\ttemplate::value &&\n+\ttemplate &&\n \t\t\t\t\t\t details::control_type::value &&\n \t\t\t\t\t\t !std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n@@ -107,7 +107,7 @@ public:\n \t\t &value, 1, sizeof(T));\n \t}\n \n-\ttemplate::value ||\n+\ttemplate ||\n \t\t\t\t\t\t std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\n@@ -141,7 +141,7 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate::value &&\n+\ttemplate &&\n \t\t\t\t\t\t !std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n \tT get() const\n@@ -152,7 +152,7 @@ public:\n \t\treturn *reinterpret_cast(data().data());\n \t}\n \n-\ttemplate::value ||\n+\ttemplate ||\n \t\t\t\t\t\t std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\n@@ -169,7 +169,7 @@ public:\n \t}\n \n #ifndef __DOXYGEN__\n-\ttemplate::value &&\n+\ttemplate &&\n \t\t\t\t\t\t !std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n \tvoid set(const T &value)\n@@ -178,7 +178,7 @@ public:\n \t\t reinterpret_cast(&value), 1, sizeof(T));\n \t}\n \n-\ttemplate::value ||\n+\ttemplate ||\n \t\t\t\t\t\t std::is_same_v>,\n \t\t\t\t\t\t std::nullptr_t> = nullptr>\n #else\ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex d720adb81f89..e7ffef1255d4 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -31,6 +31,9 @@ template\n struct is_array> : public std::true_type {\n };\n \n+template\n+inline constexpr bool is_array_v = is_array::value;\n+\n template\n struct is_span : public std::false_type {\n };\n@@ -39,6 +42,9 @@ template\n struct is_span> : public std::true_type {\n };\n \n+template\n+inline constexpr bool is_span_v = is_span::value;\n+\n } /* namespace details */\n \n namespace utils {\n@@ -155,8 +161,8 @@ public:\n \n \ttemplate\n \texplicit constexpr Span(Container &cont,\n-\t\t\t\tstd::enable_if_t::value &&\n-\t\t\t\t\t\t !details::is_array::value &&\n+\t\t\t\tstd::enable_if_t &&\n+\t\t\t\t\t\t !details::is_array_v &&\n \t\t\t\t\t\t !std::is_array_v &&\n \t\t\t\t\t\t std::is_convertible_v (*)[],\n \t\t\t\t\t\t\t\t element_type (*)[]>,\n@@ -167,8 +173,8 @@ public:\n \n \ttemplate\n \texplicit constexpr Span(const Container &cont,\n-\t\t\t\tstd::enable_if_t::value &&\n-\t\t\t\t\t\t !details::is_array::value &&\n+\t\t\t\tstd::enable_if_t &&\n+\t\t\t\t\t\t !details::is_array_v &&\n \t\t\t\t\t\t !std::is_array_v &&\n \t\t\t\t\t\t std::is_convertible_v (*)[],\n \t\t\t\t\t\t\t\t element_type (*)[]>,\n@@ -317,8 +323,8 @@ public:\n \n \ttemplate\n \tconstexpr Span(Container &cont,\n-\t\t std::enable_if_t::value &&\n-\t\t\t\t\t!details::is_array::value &&\n+\t\t std::enable_if_t &&\n+\t\t\t\t\t!details::is_array_v &&\n \t\t\t\t\t!std::is_array_v &&\n \t\t\t\t\tstd::is_convertible_v (*)[],\n \t\t\t\t\t\t\t element_type (*)[]>,\n@@ -329,8 +335,8 @@ public:\n \n \ttemplate\n \tconstexpr Span(const Container &cont,\n-\t\t std::enable_if_t::value &&\n-\t\t\t\t\t!details::is_array::value &&\n+\t\t std::enable_if_t &&\n+\t\t\t\t\t!details::is_array_v &&\n \t\t\t\t\t!std::is_array_v &&\n \t\t\t\t\tstd::is_convertible_v (*)[],\n \t\t\t\t\t\t\t element_type (*)[]>,\n","prefixes":["libcamera-devel","2/2"]}