{"id":10258,"url":"https://patchwork.libcamera.org/api/patches/10258/?format=json","web_url":"https://patchwork.libcamera.org/patch/10258/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201026171908.21463-4-david.plowman@raspberrypi.com>","date":"2020-10-26T17:19:05","name":"[libcamera-devel,v6,3/6] libcamera: raspberrypi: Initialise the SensorCropMaximum property","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f316365b75df552b86371c37d7288cf13228b060","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10258/mbox/","series":[{"id":1417,"url":"https://patchwork.libcamera.org/api/series/1417/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1417","date":"2020-10-26T17:19:02","name":"Digital zoom","version":6,"mbox":"https://patchwork.libcamera.org/series/1417/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10258/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10258/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A2F6BDB13\n\tfor ;\n\tMon, 26 Oct 2020 17:19:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 468CD62048;\n\tMon, 26 Oct 2020 18:19:21 +0100 (CET)","from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C80B62037\n\tfor ;\n\tMon, 26 Oct 2020 18:19:18 +0100 (CET)","by mail-wm1-x330.google.com with SMTP id c194so12464353wme.2\n\tfor ;\n\tMon, 26 Oct 2020 10:19:18 -0700 (PDT)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\to63sm20955295wmo.2.2020.10.26.10.19.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 26 Oct 2020 10:19:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"q0QvjBnK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=zoc4yH1tGrvtNaaXgulQvSPpAXt0a3cFREKS4h0ENaQ=;\n\tb=q0QvjBnKs1pbcSVvnpxQFeRdXm/i4LNaSrdbast+2I9/1blbSAPdDyMw+pGqSw6/Yu\n\t1+K/fwJSUYcz9inZ/+4qixsFzSiQti6KvmotLePUlUXIFkdgsrmBlCtOh4ZtOR4wPGHH\n\t03VLAsDaFBavme2HzUfiWK56C6iL7oKeCWl1OBPLGtdUl79QSwHX541RsFNcJ8YwmZUH\n\tSF4rQ0P/jzA8GSwcANMkyYjr+5mkphKdRFuSI8zUPsNOZUzBTU+y7VXlNpkv/J0KNzyh\n\tfDOc4PKZgNNQ81SqoDqczii93NIEGK4GTerri2t9ZvCnrUN1AfYPMlElqpjLSKGO0KSY\n\t0r9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=zoc4yH1tGrvtNaaXgulQvSPpAXt0a3cFREKS4h0ENaQ=;\n\tb=AQaIcKW/CIq7XKscMy6aSQY/nl+SM63MPzUem7fEX2LQYAugkhK3srJE5P1TrimkRb\n\tyLoa3WfPt048pKqgdF/JkkpTFkmbsOmvnu7MBI01TF4zq92GYHtuoSLBTD5gLwwR0ua3\n\tekG0TR+EOZ9lmHzdSfwHqd5JkIhk9cvwET4yvKShUIQkWg2u3mkcdG4sHoNZ3Gnssb/+\n\tbaXrg5fFT0IHTDu2j1L8eReyPTXcaevIynVoWiV+ye9++zwXdO5tKyK5dsqLRW6DXOda\n\tBTmXQd/CtNFqd8dQeUN5wFBVVfR6h0QhgQPK7O0uIFMlJ6pgq5rPsvzINTkrzDUv2SYi\n\tvOow==","X-Gm-Message-State":"AOAM531FdlW1cAhNYLIhi8uOFufwGKkETajp1n08xYYJI8XblQVl/JAX\n\t4pMHOiM8XLwu82fXxNfDGWsJdrhydCk28g==","X-Google-Smtp-Source":"ABdhPJzMzaCPNeX+P78W1O38Va/Pg8wbMEWYPch1aeZJoV9V5iivk0mErMljZtI78ivrVREShdgFvA==","X-Received":"by 2002:a1c:254:: with SMTP id 81mr12627092wmc.21.1603732757980; \n\tMon, 26 Oct 2020 10:19:17 -0700 (PDT)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 26 Oct 2020 17:19:05 +0000","Message-Id":"<20201026171908.21463-4-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201026171908.21463-1-david.plowman@raspberrypi.com>","References":"<20201026171908.21463-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v6 3/6] libcamera: raspberrypi: Initialise\n\tthe SensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialise it to show we support its use, however, set it to all\nzeroes to indicate that it's not meaningful yet.\n\nSigned-off-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex dd62dfc7..763451a8 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -926,6 +926,13 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n+\t/*\n+\t * Set a default value for the ScalerCropMaximum property to show\n+\t * that we support its use, however, initialise it to zero because\n+\t * it's not meaningful until a camera mode has been chosen.\n+\t */\n+\tdata->properties_.set(properties::ScalerCropMaximum, Rectangle{});\n+\n \t/*\n \t * We cache three things about the sensor in relation to transforms\n \t * (meaning horizontal and vertical flips).\n","prefixes":["libcamera-devel","v6","3/6"]}