[{"id":13494,"web_url":"https://patchwork.libcamera.org/comment/13494/","msgid":"<20201026223512.GH3756@pendragon.ideasonboard.com>","date":"2020-10-26T22:35:12","subject":"Re: [libcamera-devel] [PATCH v6 1/6] libcamera: Add ScalerCrop\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Oct 26, 2020 at 05:19:03PM +0000, David Plowman wrote:\n> The ScalerCrop control selects how much of the sensor's active pixel\n> area will be scaled to form the final output image. It can be used to\n> implement digital zoom.\n> \n> Signed-off-by: David Plowman \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/control_ids.yaml | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4c415545..b4f76570 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -284,4 +284,17 @@ controls:\n> order in an array of 9 floating point values.\n> \n> size: [3x3]\n> +\n> + - ScalerCrop:\n> + type: Rectangle\n> + description: |\n> + Sets the image portion that will be scaled to form the whole of\n> + the final output image. The (x,y) location of this rectangle is\n> + relative to the PixelArrayActiveArea that is being used. The units\n\nThe property is called PixelArrayActiveAreas. I'll fix this when\napplying.\n\n> + remain native sensor pixels, even if the sensor is being used in\n> + a binning or skipping mode.\n> +\n> + This control is only present when the pipeline supports scaling. Its\n> + maximum valid value is given by the properties::ScalerCropMaximum\n> + property, and the two can be used to implement digital zoom.\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34081C3B5C\n\tfor ;\n\tMon, 26 Oct 2020 22:36:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8DCFC62062;\n\tMon, 26 Oct 2020 23:36:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2F03C60350\n\tfor ;\n\tMon, 26 Oct 2020 23:36:00 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AECA8527;\n\tMon, 26 Oct 2020 23:35:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DMlP2eeJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603751759;\n\tbh=gBqFKBx5cEPcr3JPakrjNmyWPHlsajc3I5z7grVbAvc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DMlP2eeJHCinFTjiPgAKz+48IyYfNTzomk/0ANhcBLNPoxLJ2i6Wpk+0BR1eK6tF/\n\ta8xy1gpAbNfUj9TO26YAmar2QyPPKUl+AkUDFabZWfuIbvD7Q06qRoHNKQ7QdvxBxj\n\tvXO+Y4PwWf8uVJbi+szQeDtOe+4kHgrl/yMikIOw=","Date":"Tue, 27 Oct 2020 00:35:12 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201026223512.GH3756@pendragon.ideasonboard.com>","References":"<20201026171908.21463-1-david.plowman@raspberrypi.com>\n\t<20201026171908.21463-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201026171908.21463-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v6 1/6] libcamera: Add ScalerCrop\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]