{"id":10243,"url":"https://patchwork.libcamera.org/api/patches/10243/?format=json","web_url":"https://patchwork.libcamera.org/patch/10243/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201025160434.25664-9-jacopo@jmondi.org>","date":"2020-10-25T16:04:28","name":"[libcamera-devel,v5,08/14] ipa: raspberry: Initialize ControlInfo with values list","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"78b6ac95dfa9cc31133048ff5ef1e58c2086ad5a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10243/mbox/","series":[{"id":1414,"url":"https://patchwork.libcamera.org/api/series/1414/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1414","date":"2020-10-25T16:04:20","name":"libcamera: Introduce draft controls","version":5,"mbox":"https://patchwork.libcamera.org/series/1414/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10243/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10243/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B756C3B5F\n\tfor ;\n\tSun, 25 Oct 2020 16:04:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DAFCC61EB9;\n\tSun, 25 Oct 2020 17:04:51 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6176661D64\n\tfor ;\n\tSun, 25 Oct 2020 17:04:50 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 9F5B7240003;\n\tSun, 25 Oct 2020 16:04:48 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 25 Oct 2020 17:04:28 +0100","Message-Id":"<20201025160434.25664-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201025160434.25664-1-jacopo@jmondi.org>","References":"<20201025160434.25664-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 08/14] ipa: raspberry: Initialize\n\tControlInfo with values list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialize the ControlInfoMap of controls supported by the Raspberry\npipeline handler and IPA using the list of the enumerated values instead\nof specifying them manually.\n\nReviewed-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/ipa/raspberrypi.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex b23baf2f1330..4ca1528ad097 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -50,13 +50,13 @@ static const ControlInfoMap Controls = {\n \t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n-\t{ &controls::AeMeteringMode, ControlInfo(0, static_cast(controls::MeteringModeMax)) },\n-\t{ &controls::AeConstraintMode, ControlInfo(0, static_cast(controls::ConstraintModeMax)) },\n-\t{ &controls::AeExposureMode, ControlInfo(0, static_cast(controls::ExposureModeMax)) },\n+\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n+\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },\n+\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },\n \t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n-\t{ &controls::AwbMode, ControlInfo(0, static_cast(controls::AwbModeMax)) },\n+\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n","prefixes":["libcamera-devel","v5","08/14"]}