[{"id":13480,"web_url":"https://patchwork.libcamera.org/comment/13480/","msgid":"<20201025230127.GH4283@pendragon.ideasonboard.com>","date":"2020-10-25T23:01:27","subject":"Re: [libcamera-devel] [PATCH v5 07/14] libcamera: controls: Fix\n\trogue whitespace","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Oct 25, 2020 at 05:04:27PM +0100, Jacopo Mondi wrote:\n> Remove an extra whitespace in the declaration of a vocabulary entry in\n\nDid you mean s/vocabulary/dictionary/ ?\n\n> gen-controls.py script.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/gen-controls.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> index 8bdaf4bdf078..12a32eaaeee9 100755\n> --- a/utils/gen-controls.py\n> +++ b/utils/gen-controls.py\n> @@ -77,7 +77,7 @@ ${description}\n> num_entries = 0\n> for entry in enum:\n> value_info = {\n> - 'name' : name,\n> + 'name': name,\n> 'value': entry['name'],\n> 'description': format_description(entry['description']),\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC683BDB13\n\tfor ;\n\tSun, 25 Oct 2020 23:02:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E00A61E01;\n\tMon, 26 Oct 2020 00:02:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AA7761DA7\n\tfor ;\n\tMon, 26 Oct 2020 00:02:14 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9F2B2A4;\n\tMon, 26 Oct 2020 00:02:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kw3jk/Mk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603666934;\n\tbh=feA04TtmB8nJGMfCLGV1AoTjdnO8/dDdf+F/W5NgLfY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kw3jk/Mks3C0g9sZxbj+AfXYwroAuwS+HxjWQQ/mC64snJQK2fIvSRxKrBfqsKX4c\n\tTDujca0+GG5Ngtea6PHpW0SW7NMTeRYz1NALDQBsvjn+4jV0rl+jNKyUHMyTVXyg4G\n\tBbSYtloL2gbfgm3IDIk7qEkJQGMVCf9bpjW1/N6g=","Date":"Mon, 26 Oct 2020 01:01:27 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20201025230127.GH4283@pendragon.ideasonboard.com>","References":"<20201025160434.25664-1-jacopo@jmondi.org>\n\t<20201025160434.25664-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201025160434.25664-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 07/14] libcamera: controls: Fix\n\trogue whitespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13483,"web_url":"https://patchwork.libcamera.org/comment/13483/","msgid":"<20201026085056.ecp3wii3hc5a33kd@uno.localdomain>","date":"2020-10-26T08:50:56","subject":"Re: [libcamera-devel] [PATCH v5 07/14] libcamera: controls: Fix\n\trogue whitespace","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Mon, Oct 26, 2020 at 01:01:27AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Sun, Oct 25, 2020 at 05:04:27PM +0100, Jacopo Mondi wrote:\n> > Remove an extra whitespace in the declaration of a vocabulary entry in\n>\n> Did you mean s/vocabulary/dictionary/ ?\n\nIndeed :)\n\n>\n> > gen-controls.py script.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> Reviewed-by: Laurent Pinchart \n>\n> > ---\n> > utils/gen-controls.py | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> > index 8bdaf4bdf078..12a32eaaeee9 100755\n> > --- a/utils/gen-controls.py\n> > +++ b/utils/gen-controls.py\n> > @@ -77,7 +77,7 @@ ${description}\n> > num_entries = 0\n> > for entry in enum:\n> > value_info = {\n> > - 'name' : name,\n> > + 'name': name,\n> > 'value': entry['name'],\n> > 'description': format_description(entry['description']),\n> > }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E923BDB13\n\tfor ;\n\tMon, 26 Oct 2020 08:51:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90C5061E30;\n\tMon, 26 Oct 2020 09:50:59 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6803D6034D\n\tfor ;\n\tMon, 26 Oct 2020 09:50:58 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C34851BF209;\n\tMon, 26 Oct 2020 08:50:57 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 26 Oct 2020 09:50:56 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201026085056.ecp3wii3hc5a33kd@uno.localdomain>","References":"<20201025160434.25664-1-jacopo@jmondi.org>\n\t<20201025160434.25664-8-jacopo@jmondi.org>\n\t<20201025230127.GH4283@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201025230127.GH4283@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 07/14] libcamera: controls: Fix\n\trogue whitespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]