[{"id":13478,"web_url":"https://patchwork.libcamera.org/comment/13478/","msgid":"<20201025225140.GE4283@pendragon.ideasonboard.com>","date":"2020-10-25T22:51:40","subject":"Re: [libcamera-devel] [PATCH v5 03/14] libcamera: control_ids:\n\tDefine draft controls","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Sun, Oct 25, 2020 at 05:04:23PM +0100, Jacopo Mondi wrote:\n> libcamera is in the process of defining its own set of controls\n> to enable applications to control the image capture process and\n> return information on the captured frames.\n> \n> To temporarily close the gap in the Android camera HAL and support all\n> controls required in the LIMITED hardware level, define a set of Draft\n> controls whose values are taken from their Android definition, in order\n> to allow pipeline handlers to support Android.\n> \n> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> ---\n>  src/libcamera/control_ids.yaml | 257 +++++++++++++++++++++++++++++++++\n>  1 file changed, 257 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4c415545dcae..2fca88e36635 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -284,4 +284,261 @@ controls:\n>          order in an array of 9 floating point values.\n>  \n>        size: [3x3]\n> +\n> +  - AePrecaptureTrigger:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +        Control for AE metering trigger. Currently identical to\n> +        ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER.\n> +\n> +        Whether the camera device will trigger a precapture metering sequence\n> +        when it processes this request.\n> +      enum:\n> +        - name: AePrecaptureTriggerIdle\n> +          value: 0\n> +          description: The trigger is idle.\n> +        - name: AePrecaptureTriggerStart\n> +          value: 1\n> +          description: The pre-capture AE metering is started by the camera.\n> +        - name: AePrecaptureTriggerCancel\n> +          value: 2\n> +          description: |\n> +            The camera will cancel any active or completed metering sequence.\n> +            The AE algorithm is reset to its initial state.\n> +\n> +  - AfTrigger:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control for AF trigger. Currently identical to\n> +       ANDROID_CONTROL_AF_TRIGGER.\n> +\n> +        Whether the camera device will trigger autofocus for this request.\n> +      enum:\n> +        - name: AfTriggerIdle\n> +          value: 0\n> +          description: The trigger is idle.\n> +        - name: AfTriggerStart\n> +          value: 1\n> +          description: The AF routine is started by the camera.\n> +        - name: AfTriggerCancel\n> +          value: 2\n> +          description: |\n> +            The camera will cancel any active trigger and the AF routine is\n> +            reset to its initial state.\n> +\n> +  - NoiseReductionMode:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to select the noise reduction algorithm mode. Currently\n> +       identical to ANDROID_NOISE_REDUCTION_MODE.\n> +\n> +        Mode of operation for the noise reduction algorithm.\n> +      enum:\n> +        - name: NoiseReductionModeOff\n> +          value: 0\n> +          description: No noise reduction is applied\n> +        - name: NoiseReductionModeFast\n> +          value: 1\n> +          description: |\n> +            Noise reduction is applied without reducing the frame rate.\n> +        - name: NoiseReductionModeHighQuality\n> +          value: 2\n> +          description: |\n> +            High quality noise reduction at the expense of frame rate.\n> +        - name: NoiseReductionModeMinimal\n> +          value: 3\n> +          description: |\n> +            Minimal noise reduction is applied without reducing the frame rate.\n> +        - name: NoiseReductionModeZSL\n> +          value: 4\n> +          description: |\n> +            Noise reduction is applied at different levels to different streams.\n> +\n> +  - ColorCorrectionAberrationMode:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to select the color correction aberration mode. Currently\n> +       identical to ANDROID_COLOR_CORRECTION_ABERRATION_MODE.\n> +\n> +        Mode of operation for the chromatic aberration correction algorithm.\n> +      enum:\n> +        - name: ColorCorrectionAberrationOff\n> +          value: 0\n> +          description: No aberration correction is applied.\n> +        - name: ColorCorrectionAberrationFast\n> +          value: 1\n> +          description: Aberration correction will not slow down the frame rate.\n> +        - name: ColorCorrectionAberrationHighQuality\n> +          value: 2\n> +          description: |\n> +            High quality aberration correction which might reduce the frame\n> +            rate.\n> +\n> +  - AeState:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to report the current AE algorithm state. Currently identical to\n> +       ANDROID_CONTROL_AE_STATE.\n> +\n> +        Current state of the AE algorithm.\n> +      enum:\n> +        - name: AeStateInactive\n> +          value: 0\n> +          description: The AE algorithm is inactive.\n> +        - name: AeStateSearching\n> +          value: 1\n> +          description: The AE algorithm has not converged yet.\n> +        - name: AeStateConverged\n> +          value: 2\n> +          description: The AE algorithm has converged.\n> +        - name: AeStateLocked\n> +          value: 3\n> +          description: The AE algorithm is locked.\n> +        - name: AeStateFlashRequired\n> +          value: 4\n> +          description: The AE algorithm would need a flash for good results\n> +        - name: AeStatePrecapture\n> +          value: 5\n> +          description: |\n> +            The AE algorithm has started a pre-capture metering session.\n> +            \\sa AePrecaptureTrigger\n> +\n> +  - AfState:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to report the current AF algorithm state. Currently identical to\n> +       ANDROID_CONTROL_AF_STATE.\n> +\n> +        Current state of the AF algorithm.\n> +      enum:\n> +        - name: AfStateInactive\n> +          value: 0\n> +          description: The AF algorithm is inactive.\n> +        - name: AfStatePassiveScan\n> +          value: 1\n> +          description: |\n> +            AF is performing a passive scan of the scene in continuous\n> +            auto-focus mode.\n> +        - name: AfStatePassiveFocused\n> +          value: 2\n> +          description: |\n> +            AF believes the scene is in focus, but might restart scanning.\n> +        - name: AfStateActiveScan\n> +          value: 3\n> +          description: |\n> +            AF is performing a scan triggered by an AF trigger request.\n> +            \\sa AfTrigger\n> +        - name: AfStateFocusedLock\n> +          value: 4\n> +          description: |\n> +            AF believes has focused correctly and has locked focus.\n> +        - name: AfStateNotFocusedLock\n> +          value: 5\n> +          description: |\n> +            AF has not been able to focus and has locked.\n> +        - name: AfStatePassiveUnfocused\n> +          value: 6\n> +          description: |\n> +            AF has completed a passive scan without finding focus.\n> +\n> +  - AwbState:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to report the current AWB algorithm state. Currently identical\n> +       to ANDROID_CONTROL_AWB_STATE.\n> +\n> +        Current state of the AWB algorithm.\n> +      enum:\n> +        - name: AwbStateInactive\n> +          value: 0\n> +          description: The AWB algorithm is inactive.\n> +        - name: AwbStateSearching\n> +          value: 1\n> +          description: The AWB algorithm has not converged yet.\n> +        - name: AwbConverged\n> +          value: 2\n> +          description: The AWB algorithm has converged.\n> +        - name: AwbLocked\n> +          value: 3\n> +          description: The AWB algorithm is locked.\n> +\n> +  - ScalerCropRegion:\n> +      type: Rectangle\n> +      draft: true\n> +      description: |\n> +        Control to report the region of the sensor that has been read-out.\n> +        Currently identical to ANDROID_SCALER_CROP_REGION.\n> +\n> +        The area of the sensor that has been read out, defined relatively to\n> +        the active pixel array size.\n> +\n> +        \\sa properties::PixelArrayActiveAreas\n\nJust a quick note to mention that the zoom series is almost ready to be\nmerged. Should we drop this control for the meantime ?\n\n> +\n> +  - SensorTimestamp:\n> +      type: int64_t\n> +      draft: true\n> +      description: |\n> +       Control to report the start of exposure of the first row of the captured\n> +       image. Currently identical to ANDROID_SENSOR_TIMESTAMP.\n> +\n> +  - SensorRollingShutterSkew:\n> +      type: int64_t\n> +      draft: true\n> +      description: |\n> +       Control to report the time between the start of exposure of the first\n> +       row and the start of exposure of the last row. Currently identical to\n> +       ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n> +\n> +  - LensShadingMapMode:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to report if the lens shading map is available. Currently\n> +       identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n> +      enum:\n> +        - name: LensShadingMapModeOff\n> +          value: 0\n> +          description: No lens shading map mode is available.\n> +        - name: LensShadingMapModeOn\n> +          value: 1\n> +          description: The lens shading map mode is available.\n> +\n> +  - SceneFlicker:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +       Control to report the detected scene light frequency. Currently\n> +       identical to ANDROID_STATISTICS_SCENE_FLICKER.\n> +      enum:\n> +        - name: SceneFickerOff\n> +          value: 0\n> +          description: No flickering detected.\n> +        - name: SceneFicker50Hz\n> +          value: 1\n> +          description: 50Hz flickering detected.\n> +        - name: SceneFicker60Hz\n> +          value: 2\n> +          description: 60Hz flickering detected.\n> +\n> +  - PipelineDepth:\n> +      type: int32_t\n> +      draft: true\n> +      description: |\n> +        Specifies the number of pipeline stages the frame went through from when\n> +        it was exposed to when the final completed result was available to the\n> +        framework. Always less than or equal to PipelineMaxDepth. Currently\n> +        identical to ANDROID_REQUEST_PIPELINE_DEPTH.\n> +\n> +        The typical value for this control is 3 as a frame is first exposed,\n> +        captured and then processed in a single pass through the ISP. Any\n> +        additional processing step performed after the ISP pass (in example face\n> +        detection, additional format conversions etc) count as an additional\n> +        pipeline stage.\n>  ...","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47E02C3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 25 Oct 2020 22:52:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA63561DD3;\n\tSun, 25 Oct 2020 23:52:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9921761D25\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 25 Oct 2020 23:52:27 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B74D49B7;\n\tSun, 25 Oct 2020 23:52:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qIlaF5wV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603666346;\n\tbh=pBM4PD5/3ISsJOQofb8+0R8OWGZjazoa9r2pttYwgiw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qIlaF5wVJMp4RHhNgE2TZzCYkg2/GXCk7mKGKkEYX5ZGkIpcmcBb3I+SVierS6/7g\n\thE7KS1Fjn5BUSpWcYL4J9ma5FH1+UPodgHEHnUUEKIrWJ0Qq77jlsYWCt22CmzBrlD\n\tScYI5JYbTiWO+6zpQVDksaVkkg8mcnVe6bFPb/WQ=","Date":"Mon, 26 Oct 2020 00:51:40 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Message-ID":"<20201025225140.GE4283@pendragon.ideasonboard.com>","References":"<20201025160434.25664-1-jacopo@jmondi.org>\n\t<20201025160434.25664-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201025160434.25664-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v5 03/14] libcamera: control_ids:\n\tDefine draft controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":13484,"web_url":"https://patchwork.libcamera.org/comment/13484/","msgid":"<20201026085627.hbkuvbgnlckeowhb@uno.localdomain>","date":"2020-10-26T08:56:27","subject":"Re: [libcamera-devel] [PATCH v5 03/14] libcamera: control_ids:\n\tDefine draft controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Oct 26, 2020 at 12:51:40AM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Sun, Oct 25, 2020 at 05:04:23PM +0100, Jacopo Mondi wrote:\n> > libcamera is in the process of defining its own set of controls\n> > to enable applications to control the image capture process and\n> > return information on the captured frames.\n> >\n> > To temporarily close the gap in the Android camera HAL and support all\n> > controls required in the LIMITED hardware level, define a set of Draft\n> > controls whose values are taken from their Android definition, in order\n> > to allow pipeline handlers to support Android.\n> >\n> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n> > ---\n> >  src/libcamera/control_ids.yaml | 257 +++++++++++++++++++++++++++++++++\n> >  1 file changed, 257 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 4c415545dcae..2fca88e36635 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -284,4 +284,261 @@ controls:\n> >          order in an array of 9 floating point values.\n> >\n> >        size: [3x3]\n> > +\n> > +  - AePrecaptureTrigger:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +        Control for AE metering trigger. Currently identical to\n> > +        ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER.\n> > +\n> > +        Whether the camera device will trigger a precapture metering sequence\n> > +        when it processes this request.\n> > +      enum:\n> > +        - name: AePrecaptureTriggerIdle\n> > +          value: 0\n> > +          description: The trigger is idle.\n> > +        - name: AePrecaptureTriggerStart\n> > +          value: 1\n> > +          description: The pre-capture AE metering is started by the camera.\n> > +        - name: AePrecaptureTriggerCancel\n> > +          value: 2\n> > +          description: |\n> > +            The camera will cancel any active or completed metering sequence.\n> > +            The AE algorithm is reset to its initial state.\n> > +\n> > +  - AfTrigger:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control for AF trigger. Currently identical to\n> > +       ANDROID_CONTROL_AF_TRIGGER.\n> > +\n> > +        Whether the camera device will trigger autofocus for this request.\n> > +      enum:\n> > +        - name: AfTriggerIdle\n> > +          value: 0\n> > +          description: The trigger is idle.\n> > +        - name: AfTriggerStart\n> > +          value: 1\n> > +          description: The AF routine is started by the camera.\n> > +        - name: AfTriggerCancel\n> > +          value: 2\n> > +          description: |\n> > +            The camera will cancel any active trigger and the AF routine is\n> > +            reset to its initial state.\n> > +\n> > +  - NoiseReductionMode:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to select the noise reduction algorithm mode. Currently\n> > +       identical to ANDROID_NOISE_REDUCTION_MODE.\n> > +\n> > +        Mode of operation for the noise reduction algorithm.\n> > +      enum:\n> > +        - name: NoiseReductionModeOff\n> > +          value: 0\n> > +          description: No noise reduction is applied\n> > +        - name: NoiseReductionModeFast\n> > +          value: 1\n> > +          description: |\n> > +            Noise reduction is applied without reducing the frame rate.\n> > +        - name: NoiseReductionModeHighQuality\n> > +          value: 2\n> > +          description: |\n> > +            High quality noise reduction at the expense of frame rate.\n> > +        - name: NoiseReductionModeMinimal\n> > +          value: 3\n> > +          description: |\n> > +            Minimal noise reduction is applied without reducing the frame rate.\n> > +        - name: NoiseReductionModeZSL\n> > +          value: 4\n> > +          description: |\n> > +            Noise reduction is applied at different levels to different streams.\n> > +\n> > +  - ColorCorrectionAberrationMode:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to select the color correction aberration mode. Currently\n> > +       identical to ANDROID_COLOR_CORRECTION_ABERRATION_MODE.\n> > +\n> > +        Mode of operation for the chromatic aberration correction algorithm.\n> > +      enum:\n> > +        - name: ColorCorrectionAberrationOff\n> > +          value: 0\n> > +          description: No aberration correction is applied.\n> > +        - name: ColorCorrectionAberrationFast\n> > +          value: 1\n> > +          description: Aberration correction will not slow down the frame rate.\n> > +        - name: ColorCorrectionAberrationHighQuality\n> > +          value: 2\n> > +          description: |\n> > +            High quality aberration correction which might reduce the frame\n> > +            rate.\n> > +\n> > +  - AeState:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the current AE algorithm state. Currently identical to\n> > +       ANDROID_CONTROL_AE_STATE.\n> > +\n> > +        Current state of the AE algorithm.\n> > +      enum:\n> > +        - name: AeStateInactive\n> > +          value: 0\n> > +          description: The AE algorithm is inactive.\n> > +        - name: AeStateSearching\n> > +          value: 1\n> > +          description: The AE algorithm has not converged yet.\n> > +        - name: AeStateConverged\n> > +          value: 2\n> > +          description: The AE algorithm has converged.\n> > +        - name: AeStateLocked\n> > +          value: 3\n> > +          description: The AE algorithm is locked.\n> > +        - name: AeStateFlashRequired\n> > +          value: 4\n> > +          description: The AE algorithm would need a flash for good results\n> > +        - name: AeStatePrecapture\n> > +          value: 5\n> > +          description: |\n> > +            The AE algorithm has started a pre-capture metering session.\n> > +            \\sa AePrecaptureTrigger\n> > +\n> > +  - AfState:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the current AF algorithm state. Currently identical to\n> > +       ANDROID_CONTROL_AF_STATE.\n> > +\n> > +        Current state of the AF algorithm.\n> > +      enum:\n> > +        - name: AfStateInactive\n> > +          value: 0\n> > +          description: The AF algorithm is inactive.\n> > +        - name: AfStatePassiveScan\n> > +          value: 1\n> > +          description: |\n> > +            AF is performing a passive scan of the scene in continuous\n> > +            auto-focus mode.\n> > +        - name: AfStatePassiveFocused\n> > +          value: 2\n> > +          description: |\n> > +            AF believes the scene is in focus, but might restart scanning.\n> > +        - name: AfStateActiveScan\n> > +          value: 3\n> > +          description: |\n> > +            AF is performing a scan triggered by an AF trigger request.\n> > +            \\sa AfTrigger\n> > +        - name: AfStateFocusedLock\n> > +          value: 4\n> > +          description: |\n> > +            AF believes has focused correctly and has locked focus.\n> > +        - name: AfStateNotFocusedLock\n> > +          value: 5\n> > +          description: |\n> > +            AF has not been able to focus and has locked.\n> > +        - name: AfStatePassiveUnfocused\n> > +          value: 6\n> > +          description: |\n> > +            AF has completed a passive scan without finding focus.\n> > +\n> > +  - AwbState:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the current AWB algorithm state. Currently identical\n> > +       to ANDROID_CONTROL_AWB_STATE.\n> > +\n> > +        Current state of the AWB algorithm.\n> > +      enum:\n> > +        - name: AwbStateInactive\n> > +          value: 0\n> > +          description: The AWB algorithm is inactive.\n> > +        - name: AwbStateSearching\n> > +          value: 1\n> > +          description: The AWB algorithm has not converged yet.\n> > +        - name: AwbConverged\n> > +          value: 2\n> > +          description: The AWB algorithm has converged.\n> > +        - name: AwbLocked\n> > +          value: 3\n> > +          description: The AWB algorithm is locked.\n> > +\n> > +  - ScalerCropRegion:\n> > +      type: Rectangle\n> > +      draft: true\n> > +      description: |\n> > +        Control to report the region of the sensor that has been read-out.\n> > +        Currently identical to ANDROID_SCALER_CROP_REGION.\n> > +\n> > +        The area of the sensor that has been read out, defined relatively to\n> > +        the active pixel array size.\n> > +\n> > +        \\sa properties::PixelArrayActiveAreas\n>\n> Just a quick note to mention that the zoom series is almost ready to be\n> merged. Should we drop this control for the meantime ?\n>\n\nWill drop this one.\n\nWe can 1-to-1 map it to the forthcoming libcamera::ScalerCrop\n\n\n> > +\n> > +  - SensorTimestamp:\n> > +      type: int64_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the start of exposure of the first row of the captured\n> > +       image. Currently identical to ANDROID_SENSOR_TIMESTAMP.\n> > +\n> > +  - SensorRollingShutterSkew:\n> > +      type: int64_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the time between the start of exposure of the first\n> > +       row and the start of exposure of the last row. Currently identical to\n> > +       ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n> > +\n> > +  - LensShadingMapMode:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report if the lens shading map is available. Currently\n> > +       identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n> > +      enum:\n> > +        - name: LensShadingMapModeOff\n> > +          value: 0\n> > +          description: No lens shading map mode is available.\n> > +        - name: LensShadingMapModeOn\n> > +          value: 1\n> > +          description: The lens shading map mode is available.\n> > +\n> > +  - SceneFlicker:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +       Control to report the detected scene light frequency. Currently\n> > +       identical to ANDROID_STATISTICS_SCENE_FLICKER.\n> > +      enum:\n> > +        - name: SceneFickerOff\n> > +          value: 0\n> > +          description: No flickering detected.\n> > +        - name: SceneFicker50Hz\n> > +          value: 1\n> > +          description: 50Hz flickering detected.\n> > +        - name: SceneFicker60Hz\n> > +          value: 2\n> > +          description: 60Hz flickering detected.\n> > +\n> > +  - PipelineDepth:\n> > +      type: int32_t\n> > +      draft: true\n> > +      description: |\n> > +        Specifies the number of pipeline stages the frame went through from when\n> > +        it was exposed to when the final completed result was available to the\n> > +        framework. Always less than or equal to PipelineMaxDepth. Currently\n> > +        identical to ANDROID_REQUEST_PIPELINE_DEPTH.\n> > +\n> > +        The typical value for this control is 3 as a frame is first exposed,\n> > +        captured and then processed in a single pass through the ISP. Any\n> > +        additional processing step performed after the ISP pass (in example face\n> > +        detection, additional format conversions etc) count as an additional\n> > +        pipeline stage.\n> >  ...\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD44AC3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Oct 2020 08:56:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6772E61E01;\n\tMon, 26 Oct 2020 09:56:31 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93B506034D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Oct 2020 09:56:29 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id DC460240003;\n\tMon, 26 Oct 2020 08:56:28 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 26 Oct 2020 09:56:27 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20201026085627.hbkuvbgnlckeowhb@uno.localdomain>","References":"<20201025160434.25664-1-jacopo@jmondi.org>\n\t<20201025160434.25664-4-jacopo@jmondi.org>\n\t<20201025225140.GE4283@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201025225140.GE4283@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 03/14] libcamera: control_ids:\n\tDefine draft controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]