[{"id":13460,"web_url":"https://patchwork.libcamera.org/comment/13460/","msgid":"<20201023224858.GM5979@pendragon.ideasonboard.com>","date":"2020-10-23T22:48:58","subject":"Re: [libcamera-devel] [PATCH v5 3/5] libcamera: raspberrypi:\n\tInitialise the SensorCropMaximum property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 11:21:57AM +0100, David Plowman wrote:\n> Initialise it to show we support its use, however, set it to all\n> zeroes to indicate that it's not meaningful yet.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index dd62dfc7..763451a8 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -926,6 +926,13 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n> \t/* Initialize the camera properties. */\n> \tdata->properties_ = data->sensor_->properties();\n> \n> +\t/*\n> +\t * Set a default value for the ScalerCropMaximum property to show\n> +\t * that we support its use, however, initialise it to zero because\n> +\t * it's not meaningful until a camera mode has been chosen.\n> +\t */\n> +\tdata->properties_.set(properties::ScalerCropMaximum, Rectangle{});\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \t/*\n> \t * We cache three things about the sensor in relation to transforms\n> \t * (meaning horizontal and vertical flips).","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACE3FBDB13\n\tfor ;\n\tFri, 23 Oct 2020 22:49:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ADF161B8D;\n\tSat, 24 Oct 2020 00:49:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDFD0615D2\n\tfor ;\n\tSat, 24 Oct 2020 00:49:44 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 534429BF;\n\tSat, 24 Oct 2020 00:49:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ukwT+zfj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603493384;\n\tbh=/LiTvFlSu+luVBMTxYagZEYrl71Nd9GaK5vqFcxdFaM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ukwT+zfjuaahJonL1M6+DxJiCv99QrADRFmd0fn05HFx5dz6I05M9XzbutC1mU3Qj\n\thacUHlT0Es+tlOPabSFdZU1Ltw6FXdfXf2C0eVo/6boQxJkRygo6GMwk6mgKf+l8lN\n\tehW5xEhJVwY+5Xrhr5A26K3R1aw57JpjZ1edWXN4=","Date":"Sat, 24 Oct 2020 01:48:58 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201023224858.GM5979@pendragon.ideasonboard.com>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023102159.26274-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 3/5] libcamera: raspberrypi:\n\tInitialise the SensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]