[{"id":13459,"web_url":"https://patchwork.libcamera.org/comment/13459/","msgid":"<20201023224756.GL5979@pendragon.ideasonboard.com>","date":"2020-10-23T22:47:56","subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 11:21:56AM +0100, David Plowman wrote:\n> The SensorCropMaximum camera property reports the location of that\n> part of the image sensor array that is scaled to produce the output\n\ns/is scaled/can be scaled/ as the SensorCrop control will select which\npart is actually scaled ?\n\n> images, given in native sensor pixels. It will normally change when a\n> new camera mode is selected, and can be used to implement digital\n> zoom.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/property_ids.yaml | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 7261263a..a306a422 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -663,4 +663,18 @@ controls:\n> \\todo Rename this property to ActiveAreas once we will have property\n> categories (i.e. Properties::PixelArray::ActiveAreas)\n> \n> + - ScalerCropMaximum:\n> + type: Rectangle\n> + description: |\n> + The maximum valid rectangle for the controls::ScalerCrop control. This\n> + reflects the minimum mandatory cropping applied in the camera sensor and\n> + the rest of the pipeline.\n> +\n> + This property is valid only after the camera has been successfully\n> + configured and its value changes whenever a new configuration is\n\ns/changes/may change/\n\nReviewed-by: Laurent Pinchart \n\n> + applied.\n> +\n> + \\todo Turn this property into a \"maximum control value\" for the\n> + ScalerCrop control once \"dynamic\" controls have been implemented.\n> +\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 803B2BDB13\n\tfor ;\n\tFri, 23 Oct 2020 22:48:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DFCA161B8D;\n\tSat, 24 Oct 2020 00:48:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66FC4615D2\n\tfor ;\n\tSat, 24 Oct 2020 00:48:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0C529BF;\n\tSat, 24 Oct 2020 00:48:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X9sJOkl/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603493323;\n\tbh=eMdWX49YN5Eb/NMrTF60LSxQb9icnWPt5CopjLL06zE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X9sJOkl/TTToFGHRbNvmu4zMtSRkZ9HawJnmeiFdooNzsb27s/rml6Rr3igXHvPv3\n\t7swHpvDI5K2zGu/xPLz6AH2+NgY9l5g+lBdkgwkT9lyNjwsKHPR9cITqOdP9MMdlRp\n\tRHJzk4gkaZcmSis0tCIWrWV+fMnD7Wr1TMc7ryqM=","Date":"Sat, 24 Oct 2020 01:47:56 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201023224756.GL5979@pendragon.ideasonboard.com>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023102159.26274-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13467,"web_url":"https://patchwork.libcamera.org/comment/13467/","msgid":"<20201024164341.v7yaneoqjn5vka3g@uno.localdomain>","date":"2020-10-24T16:43:41","subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Fri, Oct 23, 2020 at 11:21:56AM +0100, David Plowman wrote:\n> The SensorCropMaximum camera property reports the location of that\n\ns/that/the ?\n\n> part of the image sensor array that is scaled to produce the output\n> images, given in native sensor pixels. It will normally change when a\n> new camera mode is selected, and can be used to implement digital\n> zoom.\n>\n> Signed-off-by: David Plowman \n\nNice work! Thank you and Laurent for pushing this forward!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/property_ids.yaml | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n>\n> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> index 7261263a..a306a422 100644\n> --- a/src/libcamera/property_ids.yaml\n> +++ b/src/libcamera/property_ids.yaml\n> @@ -663,4 +663,18 @@ controls:\n> \\todo Rename this property to ActiveAreas once we will have property\n> categories (i.e. Properties::PixelArray::ActiveAreas)\n>\n> + - ScalerCropMaximum:\n> + type: Rectangle\n> + description: |\n> + The maximum valid rectangle for the controls::ScalerCrop control. This\n> + reflects the minimum mandatory cropping applied in the camera sensor and\n> + the rest of the pipeline.\n> +\n> + This property is valid only after the camera has been successfully\n> + configured and its value changes whenever a new configuration is\n> + applied.\n> +\n> + \\todo Turn this property into a \"maximum control value\" for the\n> + ScalerCrop control once \"dynamic\" controls have been implemented.\n> +\n> ...\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64FC5BDB13\n\tfor ;\n\tSat, 24 Oct 2020 16:43:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06054615D5;\n\tSat, 24 Oct 2020 18:43:46 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 14A2F605BF\n\tfor ;\n\tSat, 24 Oct 2020 18:43:44 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 363C060004;\n\tSat, 24 Oct 2020 16:43:42 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 24 Oct 2020 18:43:41 +0200","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201024164341.v7yaneoqjn5vka3g@uno.localdomain>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023102159.26274-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13470,"web_url":"https://patchwork.libcamera.org/comment/13470/","msgid":"<20201024191715.dn6izcs56sanwrfi@uno.localdomain>","date":"2020-10-24T19:17:15","subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi again,\n\nOn Sat, Oct 24, 2020 at 06:43:44PM +0200, Jacopo Mondi wrote:\n> On Fri, Oct 23, 2020 at 11:21:56AM +0100, David Plowman wrote:\n> > The SensorCropMaximum camera property reports the location of that\n>\n> s/that/the ?\n>\n> > part of the image sensor array that is scaled to produce the output\n> > images, given in native sensor pixels. It will normally change when a\n> > new camera mode is selected, and can be used to implement digital\n> > zoom.\n> >\n> > Signed-off-by: David Plowman \n>\n> Nice work! Thank you and Laurent for pushing this forward!\n>\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > ---\n> > src/libcamera/property_ids.yaml | 14 ++++++++++++++\n> > 1 file changed, 14 insertions(+)\n> >\n> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > index 7261263a..a306a422 100644\n> > --- a/src/libcamera/property_ids.yaml\n> > +++ b/src/libcamera/property_ids.yaml\n> > @@ -663,4 +663,18 @@ controls:\n> > \\todo Rename this property to ActiveAreas once we will have property\n> > categories (i.e. Properties::PixelArray::ActiveAreas)\n> >\n> > + - ScalerCropMaximum:\n> > + type: Rectangle\n> > + description: |\n> > + The maximum valid rectangle for the controls::ScalerCrop control. This\n> > + reflects the minimum mandatory cropping applied in the camera sensor and\n> > + the rest of the pipeline.\n\nLooking at the RPi implementation I had to get back here to check what\nthe reference of the property is and found it only mentioned in the\ncommit message. Should we mention it is relative to the full pixel\narray as it's done for ScalerCrop ?\n\n> > +\n> > + This property is valid only after the camera has been successfully\n> > + configured and its value changes whenever a new configuration is\n> > + applied.\n> > +\n> > + \\todo Turn this property into a \"maximum control value\" for the\n> > + ScalerCrop control once \"dynamic\" controls have been implemented.\n> > +\n> > ...\n> > --\n> > 2.20.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80AC4BDB13\n\tfor ;\n\tSat, 24 Oct 2020 19:17:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07F7261D64;\n\tSat, 24 Oct 2020 21:17:19 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88D05605BF\n\tfor ;\n\tSat, 24 Oct 2020 21:17:17 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 072431C0006;\n\tSat, 24 Oct 2020 19:17:16 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 24 Oct 2020 21:17:15 +0200","From":"Jacopo Mondi ","To":"David Plowman ","Message-ID":"<20201024191715.dn6izcs56sanwrfi@uno.localdomain>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-3-david.plowman@raspberrypi.com>\n\t<20201024164341.v7yaneoqjn5vka3g@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201024164341.v7yaneoqjn5vka3g@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13472,"web_url":"https://patchwork.libcamera.org/comment/13472/","msgid":"<20201024222515.GE3943@pendragon.ideasonboard.com>","date":"2020-10-24T22:25:15","subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\nOn Sat, Oct 24, 2020 at 09:17:15PM +0200, Jacopo Mondi wrote:\n> On Sat, Oct 24, 2020 at 06:43:44PM +0200, Jacopo Mondi wrote:\n> > On Fri, Oct 23, 2020 at 11:21:56AM +0100, David Plowman wrote:\n> > > The SensorCropMaximum camera property reports the location of that\n> >\n> > s/that/the ?\n> >\n> > > part of the image sensor array that is scaled to produce the output\n> > > images, given in native sensor pixels. It will normally change when a\n> > > new camera mode is selected, and can be used to implement digital\n> > > zoom.\n> > >\n> > > Signed-off-by: David Plowman \n> >\n> > Nice work! Thank you and Laurent for pushing this forward!\n> >\n> > Reviewed-by: Jacopo Mondi \n> >\n> > > ---\n> > > src/libcamera/property_ids.yaml | 14 ++++++++++++++\n> > > 1 file changed, 14 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\n> > > index 7261263a..a306a422 100644\n> > > --- a/src/libcamera/property_ids.yaml\n> > > +++ b/src/libcamera/property_ids.yaml\n> > > @@ -663,4 +663,18 @@ controls:\n> > > \\todo Rename this property to ActiveAreas once we will have property\n> > > categories (i.e. Properties::PixelArray::ActiveAreas)\n> > >\n> > > + - ScalerCropMaximum:\n> > > + type: Rectangle\n> > > + description: |\n> > > + The maximum valid rectangle for the controls::ScalerCrop control. This\n> > > + reflects the minimum mandatory cropping applied in the camera sensor and\n> > > + the rest of the pipeline.\n> \n> Looking at the RPi implementation I had to get back here to check what\n> the reference of the property is and found it only mentioned in the\n> commit message. Should we mention it is relative to the full pixel\n> array as it's done for ScalerCrop ?\n\nI think it's important to document it clearly for the ScalerCrop\nproperty. ScalerCropMaximum is then defined based on the ScalerCrop\ndefinition, so I don't consider it necessary to duplicate the\ninformation here. I don't mind much though (and this property is meant\nto be temporary anyway).\n\n> > > +\n> > > + This property is valid only after the camera has been successfully\n> > > + configured and its value changes whenever a new configuration is\n> > > + applied.\n> > > +\n> > > + \\todo Turn this property into a \"maximum control value\" for the\n> > > + ScalerCrop control once \"dynamic\" controls have been implemented.\n> > > +\n> > > ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 258EABDB13\n\tfor ;\n\tSat, 24 Oct 2020 22:26:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 997ED61DD3;\n\tSun, 25 Oct 2020 00:26:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A92AC61CB4\n\tfor ;\n\tSun, 25 Oct 2020 00:26:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 10E72A19;\n\tSun, 25 Oct 2020 00:26:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uuA8+Q0x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603578361;\n\tbh=sl+QWRvoesT+sI4Iw9BKNOtMiKF5weME9aynELx//WE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uuA8+Q0xH4OzUtv9o79AGFtCQOGBLqRH7DAOiXpxi6zgZqXBZm5aDbnxVrGWnM3d4\n\t9bWltwI5gcusVEBWvCGmBOWzzR/k/iLJ7OIM3wz0dsFCV0b6Sb4HgUFgUpWmGyZ0Ez\n\tLEC1javkQo7Hw7q1SgSwmtlIrQjmmkKszF2F72Ao=","Date":"Sun, 25 Oct 2020 01:25:15 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20201024222515.GE3943@pendragon.ideasonboard.com>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-3-david.plowman@raspberrypi.com>\n\t<20201024164341.v7yaneoqjn5vka3g@uno.localdomain>\n\t<20201024191715.dn6izcs56sanwrfi@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201024191715.dn6izcs56sanwrfi@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v5 2/5] libcamera: Add\n\tSensorCropMaximum property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]