[{"id":13458,"web_url":"https://patchwork.libcamera.org/comment/13458/","msgid":"<20201023224356.GK5979@pendragon.ideasonboard.com>","date":"2020-10-23T22:43:56","subject":"Re: [libcamera-devel] [PATCH v5 1/5] libcamera: Add ScalerCrop\n\tcontrol","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 11:21:55AM +0100, David Plowman wrote:\n> The ScalerCrop control selects how much of the sensor's output image\n\nI'd say \"the sensor's active pixel array\" here, as that's how it's\ndefined below.\n\n> will be scaled to form the final output image. It can be used to\n> implement digital zoom.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 13 +++++++++++++\n> 1 file changed, 13 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4c415545..1c1f6699 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -284,4 +284,17 @@ controls:\n> order in an array of 9 floating point values.\n> \n> size: [3x3]\n> +\n> + - ScalerCrop:\n> + type: Rectangle\n> + description: |\n> + Sets the image portion that will be scaled to form the whole of\n> + the final output image. The (x,y) location of this rectangle is\n> + relative to the PixelArrayActiveArea that is being used. The units\n> + remain native sensor pixels, even if the sensor is being used in\n> + a binning or skipping mode.\n> +\n> + This control is only present when the pipeline supports it. Its\n\nMaybe \"when the pipeline supports scaling\" ? The fact that a control is\nonly present when it's supported is a bit of a given :-) Apart from\nthat,\n\nReviewed-by: Laurent Pinchart \n\n> + maximum valid value is given by the properties::ScalerCropMaximum\n> + property, and the two can be used to implement digital zoom.\n> ...","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA248C3D3C\n\tfor ;\n\tFri, 23 Oct 2020 22:44:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F6A261B8D;\n\tSat, 24 Oct 2020 00:44:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3E35615D2\n\tfor ;\n\tSat, 24 Oct 2020 00:44:42 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4DA799BF;\n\tSat, 24 Oct 2020 00:44:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iMThwQCp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603493082;\n\tbh=Q00z1+MjRGpYy4xPjtMVZ9kRCayhdivV2vfn8PMsCmM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iMThwQCpirOX/Ngow3QODeIhzRHLBODczeKLQQry+o6hCrcVOnikbkDugu6T2RrL+\n\tA9+HE2wiSci0NJXLzRD4+/g6bEzQv582JSfsmp1Ac+cor9Q/D6Al2/ujTKUMuuV/Re\n\tCsm/Q5SXJRIIrAYeWNqceLpUgyvxXtPy0/OrLQeU=","Date":"Sat, 24 Oct 2020 01:43:56 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20201023224356.GK5979@pendragon.ideasonboard.com>","References":"<20201023102159.26274-1-david.plowman@raspberrypi.com>\n\t<20201023102159.26274-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023102159.26274-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 1/5] libcamera: Add ScalerCrop\n\tcontrol","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]