[{"id":13464,"web_url":"https://patchwork.libcamera.org/comment/13464/","msgid":"<20201023234426.GP5979@pendragon.ideasonboard.com>","date":"2020-10-23T23:44:26","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: simple: Only\n\tconnect created converters","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 11:11:54AM +0100, Kieran Bingham wrote:\n> If converter_->open() fails, the code deletes the converter_ but then\n> happily goes on, and at the very next lines will use converter_ to\n> connect the bufferReady signal.\n> \n> Ensure the converter is only connected when successfully opened by\n> extending the conditional and connecting in an else scope instead.\n> \n> Reported-by: Tomi Valkeinen \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 0d48e1b6acca..3d2039f3f269 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -774,9 +774,9 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\t\t<< \"Failed to open converter, disabling format conversion\";\n> \t\t\tdelete converter_;\n> \t\t\tconverter_ = nullptr;\n> +\t\t} else {\n> +\t\t\tconverter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);\n> \t\t}\n> -\n> -\t\tconverter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);\n> \t}\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08EA1BDB13\n\tfor ;\n\tFri, 23 Oct 2020 23:45:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8183861D64;\n\tSat, 24 Oct 2020 01:45:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B8ED461C48\n\tfor ;\n\tSat, 24 Oct 2020 01:45:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 314B39BF;\n\tSat, 24 Oct 2020 01:45:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bjS36QfY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603496713;\n\tbh=MOiXvS02ovRg9/2qAJmqxOlU1rJ6ApRmwpwTgLwy+xk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bjS36QfYFi2iUXzOo9LPuY82JQKhWn03HlxEaNg4n0MxrQYjpDWBxAZI1x1r/uVNL\n\tpql4EKGDe6PXP/r6HS5SPZ8seKgq3LZjHeP0SfnJRzgyCTkQ9t1RxNgGkEbPpYsjFN\n\tcBG36XEIK2m6enu+TaCC/x/I8dSRYyyIyK/wlF4Y=","Date":"Sat, 24 Oct 2020 02:44:26 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201023234426.GP5979@pendragon.ideasonboard.com>","References":"<20201023101154.673143-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023101154.673143-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: pipeline: simple: Only\n\tconnect created converters","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]