[{"id":13430,"web_url":"https://patchwork.libcamera.org/comment/13430/","msgid":"<20201023051636.GJ4113@pendragon.ideasonboard.com>","date":"2020-10-23T05:16:36","subject":"Re: [libcamera-devel] [PATCH 2/2] android: jpeg: encoder: Use\n\tpass-by-value for Exif parameter","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 10:44:11AM +0530, Umang Jain wrote:\n> Following the reasoning of pass-by-value for libcamera::Span\n> parameters from 90c193f2a700(\"android: Modify Encoder interface\") i.e.\n> they are easy to copy/move/construct, align the Exif parameter passing\n> to the encoder interface in this consistent way.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n> src/android/jpeg/encoder_libjpeg.h | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index 270ea60..94b3340 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -19,7 +19,7 @@ public:\n> \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> \tvirtual int encode(const libcamera::FrameBuffer &source,\n> \t\t\t libcamera::Span destination,\n> -\t\t\t const libcamera::Span &exifData) = 0;\n> +\t\t\t libcamera::Span exifData) = 0;\n> };\n> \n> #endif /* __ANDROID_JPEG_ENCODER_H__ */\n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 4bea10c..cfa5332 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -180,7 +180,7 @@ void EncoderLibJpeg::compressNV(const MappedBuffer *frame)\n> }\n> \n> int EncoderLibJpeg::encode(const FrameBuffer &source, Span dest,\n> -\t\t\t const Span &exifData)\n> +\t\t\t Span exifData)\n> {\n> \tMappedFrameBuffer frame(&source, PROT_READ);\n> \tif (!frame.isValid()) {\n> diff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h\n> index 391a53c..40505dd 100644\n> --- a/src/android/jpeg/encoder_libjpeg.h\n> +++ b/src/android/jpeg/encoder_libjpeg.h\n> @@ -23,7 +23,7 @@ public:\n> \tint configure(const libcamera::StreamConfiguration &cfg) override;\n> \tint encode(const libcamera::FrameBuffer &source,\n> \t\t libcamera::Span destination,\n> -\t\t const libcamera::Span &exifData) override;\n> +\t\t libcamera::Span exifData) override;\n> \n> private:\n> \tvoid compressRGB(const libcamera::MappedBuffer *frame);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED917C3D3C\n\tfor ;\n\tFri, 23 Oct 2020 05:17:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB7E66034E;\n\tFri, 23 Oct 2020 07:17:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31FBE6034E\n\tfor ;\n\tFri, 23 Oct 2020 07:17:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C598DB26;\n\tFri, 23 Oct 2020 07:17:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RXqze+67\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603430242;\n\tbh=xb/q2B/lvxoIEIjb5Yq7uE4QbRijmz6KJDG82FjV0zc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RXqze+67npcg6T8wymIEp26B9a9jl9UDyBHa1Ivcdki/JuAyNzMKm+1mFKeceZ9JM\n\tDivIBX9mNY0Lp9JOtA5nO4sLDOf0dPZLZY33DJwnmtE4H5lY/AdqD/xP8HXUgR3U2U\n\tu06BpRmhMcdIinnkdqrNOFEg3tcHEK1BTbedSNrU=","Date":"Fri, 23 Oct 2020 08:16:36 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20201023051636.GJ4113@pendragon.ideasonboard.com>","References":"<20201023051411.81515-1-email@uajain.com>\n\t<20201023051411.81515-2-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023051411.81515-2-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: jpeg: encoder: Use\n\tpass-by-value for Exif parameter","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]