[{"id":13429,"web_url":"https://patchwork.libcamera.org/comment/13429/","msgid":"<20201023051557.GI4113@pendragon.ideasonboard.com>","date":"2020-10-23T05:15:57","subject":"Re: [libcamera-devel] [PATCH 1/2] android: jpeg: Drop \"libcamera::\"\n\tnamespace from functions' arguments","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Oct 23, 2020 at 10:44:10AM +0530, Umang Jain wrote:\n> Drop \"libcamera::\" from functions' arguments for *.cpp files as they are\n> already declared via the function signatures in their respective header\n> files.\n\nThis isn't the reason they can be dropped, it's because the .cpp files\nhas a\n\nusing namespace libcamera;\n\ndirective at the beginning.\n\n> Signed-off-by: Umang Jain \n> ---\n> src/android/jpeg/encoder_libjpeg.cpp | 9 ++++-----\n> src/android/jpeg/post_processor_jpeg.cpp | 4 ++--\n> 2 files changed, 6 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n> index 5a2f88f..4bea10c 100644\n> --- a/src/android/jpeg/encoder_libjpeg.cpp\n> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n> @@ -104,7 +104,7 @@ int EncoderLibJpeg::configure(const StreamConfiguration &cfg)\n> \treturn 0;\n> }\n> \n> -void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n> +void EncoderLibJpeg::compressRGB(const MappedBuffer *frame)\n> {\n> \tunsigned char *src = static_cast(frame->maps()[0].data());\n> \t/* \\todo Stride information should come from buffer configuration. */\n> @@ -122,7 +122,7 @@ void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n> * Compress the incoming buffer from a supported NV format.\n> * This naively unpacks the semi-planar NV12 to a YUV888 format for libjpeg.\n> */\n> -void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n> +void EncoderLibJpeg::compressNV(const MappedBuffer *frame)\n> {\n> \tuint8_t tmprowbuf[compress_.image_width * 3];\n> \n> @@ -179,9 +179,8 @@ void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n> \t}\n> }\n> \n> -int EncoderLibJpeg::encode(const FrameBuffer &source,\n> -\t\t\t libcamera::Span dest,\n> -\t\t\t const libcamera::Span &exifData)\n> +int EncoderLibJpeg::encode(const FrameBuffer &source, Span dest,\n> +\t\t\t const Span &exifData)\n> {\n> \tMappedFrameBuffer frame(&source, PROT_READ);\n> \tif (!frame.isValid()) {\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index fd1c7be..93acfe5 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const StreamConfiguration &inCfg,\n> \treturn encoder_->configure(inCfg);\n> }\n> \n> -int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n> -\t\t\t libcamera::Span destination,\n> +int PostProcessorJpeg::process(const FrameBuffer &source,\n> +\t\t\t Span destination,\n> \t\t\t CameraMetadata *metadata)\n> {\n> \tif (!encoder_)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6CD0C3D3C\n\tfor ;\n\tFri, 23 Oct 2020 05:16:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64DDB615D2;\n\tFri, 23 Oct 2020 07:16:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F031A6034E\n\tfor ;\n\tFri, 23 Oct 2020 07:16:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C5A4B26;\n\tFri, 23 Oct 2020 07:16:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C4XYwRqx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603430203;\n\tbh=Rh6zCT1zadcUkIg/q4QWcAzxrmUjQRmYGiJ+/MA9xNo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C4XYwRqxwjeLe4FUUXpuafB9+tm/xV8pdzlGThL6s6ZaTzDr3Hi8BTF8qCyugEbKL\n\tUV24zF3jR4523oHAvxsAq57aoLhLEvp5ZyAYUu/kQ5MMOb6WE8Y4fzPCgDEdvKd7gG\n\tXevxGHcpxOivy7+0ybALGPO8c5B19V/tyHptFEO4=","Date":"Fri, 23 Oct 2020 08:15:57 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Message-ID":"<20201023051557.GI4113@pendragon.ideasonboard.com>","References":"<20201023051411.81515-1-email@uajain.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023051411.81515-1-email@uajain.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: jpeg: Drop \"libcamera::\"\n\tnamespace from functions' arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13431,"web_url":"https://patchwork.libcamera.org/comment/13431/","msgid":"<86c82b9d-3133-a392-1868-5748651a93f7@uajain.com>","date":"2020-10-23T05:20:35","subject":"Re: [libcamera-devel] [PATCH 1/2] android: jpeg: Drop \"libcamera::\"\n\tnamespace from functions' arguments","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nOn 10/23/20 10:45 AM, Laurent Pinchart wrote:\n> Hi Umang,\n>\n> Thank you for the patch.\n>\n> On Fri, Oct 23, 2020 at 10:44:10AM +0530, Umang Jain wrote:\n>> Drop \"libcamera::\" from functions' arguments for *.cpp files as they are\n>> already declared via the function signatures in their respective header\n>> files.\n> This isn't the reason they can be dropped, it's because the .cpp files\n> has a\n>\n> using namespace libcamera;\n>\n> directive at the beginning.\nIndeed, I missed to notice that.\n>> Signed-off-by: Umang Jain \n>> ---\n>> src/android/jpeg/encoder_libjpeg.cpp | 9 ++++-----\n>> src/android/jpeg/post_processor_jpeg.cpp | 4 ++--\n>> 2 files changed, 6 insertions(+), 7 deletions(-)\n>>\n>> diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\n>> index 5a2f88f..4bea10c 100644\n>> --- a/src/android/jpeg/encoder_libjpeg.cpp\n>> +++ b/src/android/jpeg/encoder_libjpeg.cpp\n>> @@ -104,7 +104,7 @@ int EncoderLibJpeg::configure(const StreamConfiguration &cfg)\n>> \treturn 0;\n>> }\n>> \n>> -void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n>> +void EncoderLibJpeg::compressRGB(const MappedBuffer *frame)\n>> {\n>> \tunsigned char *src = static_cast(frame->maps()[0].data());\n>> \t/* \\todo Stride information should come from buffer configuration. */\n>> @@ -122,7 +122,7 @@ void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n>> * Compress the incoming buffer from a supported NV format.\n>> * This naively unpacks the semi-planar NV12 to a YUV888 format for libjpeg.\n>> */\n>> -void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n>> +void EncoderLibJpeg::compressNV(const MappedBuffer *frame)\n>> {\n>> \tuint8_t tmprowbuf[compress_.image_width * 3];\n>> \n>> @@ -179,9 +179,8 @@ void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n>> \t}\n>> }\n>> \n>> -int EncoderLibJpeg::encode(const FrameBuffer &source,\n>> -\t\t\t libcamera::Span dest,\n>> -\t\t\t const libcamera::Span &exifData)\n>> +int EncoderLibJpeg::encode(const FrameBuffer &source, Span dest,\n>> +\t\t\t const Span &exifData)\n>> {\n>> \tMappedFrameBuffer frame(&source, PROT_READ);\n>> \tif (!frame.isValid()) {\n>> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n>> index fd1c7be..93acfe5 100644\n>> --- a/src/android/jpeg/post_processor_jpeg.cpp\n>> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n>> @@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const StreamConfiguration &inCfg,\n>> \treturn encoder_->configure(inCfg);\n>> }\n>> \n>> -int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n>> -\t\t\t libcamera::Span destination,\n>> +int PostProcessorJpeg::process(const FrameBuffer &source,\n>> +\t\t\t Span destination,\n>> \t\t\t CameraMetadata *metadata)\n>> {\n>> \tif (!encoder_)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3BBFBDB13\n\tfor ;\n\tFri, 23 Oct 2020 05:20:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7677F615D4;\n\tFri, 23 Oct 2020 07:20:40 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD7046034E\n\tfor ;\n\tFri, 23 Oct 2020 07:20:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"t96KyAZr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603430439; bh=8o8ubCFrqcfcZL1NpkB+gKHk73ZZyjlJ8m3GxyGcP4Q=;\n\th=Subject:To:Cc:References:From:In-Reply-To;\n\tb=t96KyAZrBnk97q+eK7P9BzXQnhCDx6vsDFSPoUTguXSdjAcQqXzqmL+0Njd51rrY8\n\tJ+VNSpMVekn9YKJOLHDLSoC+MM01rhJzI0CfMI8x5UhbzkyZq4HtBkz5n4yrncWOM1\n\t3UCxNBLgVVWFy6Oc54IChx0ucrBmr2gpTj77mtbL0Og2MzWT1gdfRjQm/I8WOqXOca\n\tnLB5Wib7fnXwyttIxdHcOXlHVBVMHYT8clwRFUYgrfr65tRPankCGWnQwTzYSb7Vh/\n\tTsLM/3OZezuTkGzmoUjnDwfxD/h9AK62OYfAvPeGW1ovZUy7BLO2dgf1YXwO3jkyyI\n\tz6rG7G1H9LWnw==","To":"Laurent Pinchart ","References":"<20201023051411.81515-1-email@uajain.com>\n\t<20201023051557.GI4113@pendragon.ideasonboard.com>","From":"Umang Jain ","Message-ID":"<86c82b9d-3133-a392-1868-5748651a93f7@uajain.com>","Date":"Fri, 23 Oct 2020 10:50:35 +0530","Mime-Version":"1.0","In-Reply-To":"<20201023051557.GI4113@pendragon.ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/2] android: jpeg: Drop \"libcamera::\"\n\tnamespace from functions' arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]