[{"id":13434,"web_url":"https://patchwork.libcamera.org/comment/13434/","msgid":"","date":"2020-10-23T05:30:42","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nOn 10/23/20 10:40 AM, Laurent Pinchart wrote:\n> The base class of polymorphic classes is required to declare a\n> destructor. Several of these are empty, and can thus be declared as\n> defaulted.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> include/libcamera/bound_method.h | 4 ++--\n> include/libcamera/internal/control_validator.h | 2 +-\n> include/libcamera/internal/ipa_proxy.h | 2 +-\n> include/libcamera/internal/media_object.h | 2 +-\n> include/libcamera/internal/pipeline_handler.h | 4 ++--\n> include/libcamera/ipa/ipa_interface.h | 2 +-\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/post_processor.h | 2 +-\n> src/cam/options.h | 2 +-\n> src/libcamera/pipeline/rkisp1/timeline.h | 4 ++--\n> src/qcam/viewfinder.h | 2 +-\n> 11 files changed, 14 insertions(+), 14 deletions(-)\n>\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index d1e4448304a9..95a956530877 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -26,7 +26,7 @@ enum ConnectionType {\n> class BoundMethodPackBase\n> {\n> public:\n> -\tvirtual ~BoundMethodPackBase() {}\n> +\tvirtual ~BoundMethodPackBase() = default;\n> };\n> \n> template\n> @@ -61,7 +61,7 @@ public:\n> \t\t: obj_(obj), object_(object), connectionType_(type)\n> \t{\n> \t}\n> -\tvirtual ~BoundMethodBase() {}\n> +\tvirtual ~BoundMethodBase() = default;\n> \n> \ttemplate::value> * = nullptr>\n> \tbool match(T *obj) { return obj == obj_; }\n> diff --git a/include/libcamera/internal/control_validator.h b/include/libcamera/internal/control_validator.h\n> index 4a00b9b7f686..206006954cd9 100644\n> --- a/include/libcamera/internal/control_validator.h\n> +++ b/include/libcamera/internal/control_validator.h\n> @@ -16,7 +16,7 @@ class ControlId;\n> class ControlValidator\n> {\n> public:\n> -\tvirtual ~ControlValidator() {}\n> +\tvirtual ~ControlValidator() = default;\n> \n> \tvirtual const std::string &name() const = 0;\n> \tvirtual bool validate(unsigned int id) const = 0;\n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index b429ce5a68a3..49399f4eb856 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -42,7 +42,7 @@ class IPAProxyFactory\n> {\n> public:\n> \tIPAProxyFactory(const char *name);\n> -\tvirtual ~IPAProxyFactory() {}\n> +\tvirtual ~IPAProxyFactory() = default;\n> \n> \tvirtual std::unique_ptr create(IPAModule *ipam) = 0;\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index 54311c14895b..43a35bef8f35 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -31,7 +31,7 @@ protected:\n> \t\t: dev_(dev), id_(id)\n> \t{\n> \t}\n> -\tvirtual ~MediaObject() {}\n> +\tvirtual ~MediaObject() = default;\n> \n> \tMediaDevice *dev_;\n> \tunsigned int id_;\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b529c461..c12c8904858e 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -40,7 +40,7 @@ public:\n> \t\t: pipe_(pipe)\n> \t{\n> \t}\n> -\tvirtual ~CameraData() {}\n> +\tvirtual ~CameraData() = default;\n> \n> \tCamera *camera_;\n> \tPipelineHandler *pipe_;\n> @@ -118,7 +118,7 @@ class PipelineHandlerFactory\n> {\n> public:\n> \tPipelineHandlerFactory(const char *name);\n> -\tvirtual ~PipelineHandlerFactory() {}\n> +\tvirtual ~PipelineHandlerFactory() = default;\n> \n> \tstd::shared_ptr create(CameraManager *manager);\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 5016ec25ea9c..322b7079070e 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -150,7 +150,7 @@ struct CameraSensorInfo;\n> class IPAInterface\n> {\n> public:\n> -\tvirtual ~IPAInterface() {}\n> +\tvirtual ~IPAInterface() = default;\n> \n> \tvirtual int init(const IPASettings &settings) = 0;\n> \tvirtual int start() = 0;\n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index 270ea6091798..0ca2ba38c528 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -14,7 +14,7 @@\n> class Encoder\n> {\n> public:\n> -\tvirtual ~Encoder() {}\n> +\tvirtual ~Encoder() = default;\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> \tvirtual int encode(const libcamera::FrameBuffer &source,\n> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> index 5f87a5d1bc30..e0f91880f0bf 100644\n> --- a/src/android/post_processor.h\n> +++ b/src/android/post_processor.h\n> @@ -16,7 +16,7 @@ class CameraMetadata;\n> class PostProcessor\n> {\n> public:\n> -\tvirtual ~PostProcessor() {}\n> +\tvirtual ~PostProcessor() = default;\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n> \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 184866195eef..f02eeca2eef9 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -73,7 +73,7 @@ public:\n> \t{\n> \t};\n> \n> -\tvirtual ~KeyValueParser() {}\n> +\tvirtual ~KeyValueParser() = default;\n> \n> \tbool addOption(const char *name, OptionType type, const char *help,\n> \t\t OptionArgument argument = ArgumentNone);\n> diff --git a/src/libcamera/pipeline/rkisp1/timeline.h b/src/libcamera/pipeline/rkisp1/timeline.h\n> index 88f99329873d..0c37b06fa6df 100644\n> --- a/src/libcamera/pipeline/rkisp1/timeline.h\n> +++ b/src/libcamera/pipeline/rkisp1/timeline.h\n> @@ -22,7 +22,7 @@ public:\n> \tFrameAction(unsigned int frame, unsigned int type)\n> \t\t: frame_(frame), type_(type) {}\n> \n> -\tvirtual ~FrameAction() {}\n> +\tvirtual ~FrameAction() = default;\n> \n> \tunsigned int frame() const { return frame_; }\n> \tunsigned int type() const { return type_; }\n> @@ -38,7 +38,7 @@ class Timeline\n> {\n> public:\n> \tTimeline();\n> -\tvirtual ~Timeline() {}\n> +\tvirtual ~Timeline() = default;\n> \n> \tvirtual void reset();\n> \tvirtual void scheduleAction(std::unique_ptr action);\n> diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> index 67da1df26a0c..e33dc4525224 100644\n> --- a/src/qcam/viewfinder.h\n> +++ b/src/qcam/viewfinder.h\n> @@ -22,7 +22,7 @@ struct MappedBuffer {\n> class ViewFinder\n> {\n> public:\n> -\tvirtual ~ViewFinder() {}\n> +\tvirtual ~ViewFinder() = default;\n> \n> \tvirtual const QList &nativeFormats() const = 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5144BDB13\n\tfor ;\n\tFri, 23 Oct 2020 05:30:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CD47615D6;\n\tFri, 23 Oct 2020 07:30:48 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 314F46034E\n\tfor ;\n\tFri, 23 Oct 2020 07:30:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"YK24X21k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603431046; bh=CbBf2XqQnhyp1BwUsszp0q8Ys9Cw9+RBPLGuAGTygYQ=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=YK24X21kLZg0kAVGR44IzXvZx1dplDMREnjytjqjTc3gicrZVyKhWVv38f8RMz9We\n\tUJKzIoz3KtBDXID0hJr9xPziU/XRVu0rPurzwRajWVAvv08kdvtaFS/Go800CevVw8\n\tsdLu93/UiTInAMvBtgqT9JLKWCDGVjzhATpPtBNirwnTC13ytNMduL1JLT6vk1uym2\n\tLQ3xm5neQ2t6rm4/xl7oGbXXppb2NVivxEOX6SUR+YtCJ73FMTgSpDaf2CnTDdVYEh\n\tWrllkQrdxfvcUkCoiNGLwVpCQXs1BepYxvzny/EpHldq4JtB3O97qBij+X5afHO1y9\n\te9Ok4T+I2ucOw==","To":"libcamera-devel@lists.libcamera.org","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"","Date":"Fri, 23 Oct 2020 11:00:42 +0530","Mime-Version":"1.0","In-Reply-To":"<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13442,"web_url":"https://patchwork.libcamera.org/comment/13442/","msgid":"<5b636a47-8082-711f-3e57-a7ca83c27d3f@ideasonboard.com>","date":"2020-10-23T08:53:19","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/10/2020 06:10, Laurent Pinchart wrote:\n> The base class of polymorphic classes is required to declare a\n> destructor. Several of these are empty, and can thus be declared as\n> defaulted.\n> \n> Signed-off-by: Laurent Pinchart \n\nWhat about these?:\n\nsrc/ipa/raspberrypi/controller/algorithm.hpp: virtual ~Algorithm() {}\nsrc/ipa/raspberrypi/md_parser.hpp: virtual ~MdParser() {}\n\n\nIf you've intentionally left those out, or with those fixed:\n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> include/libcamera/bound_method.h | 4 ++--\n> include/libcamera/internal/control_validator.h | 2 +-\n> include/libcamera/internal/ipa_proxy.h | 2 +-\n> include/libcamera/internal/media_object.h | 2 +-\n> include/libcamera/internal/pipeline_handler.h | 4 ++--\n> include/libcamera/ipa/ipa_interface.h | 2 +-\n> src/android/jpeg/encoder.h | 2 +-\n> src/android/post_processor.h | 2 +-\n> src/cam/options.h | 2 +-\n> src/libcamera/pipeline/rkisp1/timeline.h | 4 ++--\n> src/qcam/viewfinder.h | 2 +-\n> 11 files changed, 14 insertions(+), 14 deletions(-)\n\n\n> diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> index d1e4448304a9..95a956530877 100644\n> --- a/include/libcamera/bound_method.h\n> +++ b/include/libcamera/bound_method.h\n> @@ -26,7 +26,7 @@ enum ConnectionType {\n> class BoundMethodPackBase\n> {\n> public:\n> -\tvirtual ~BoundMethodPackBase() {}\n> +\tvirtual ~BoundMethodPackBase() = default;\n> };\n> \n> template\n> @@ -61,7 +61,7 @@ public:\n> \t\t: obj_(obj), object_(object), connectionType_(type)\n> \t{\n> \t}\n> -\tvirtual ~BoundMethodBase() {}\n> +\tvirtual ~BoundMethodBase() = default;\n> \n> \ttemplate::value> * = nullptr>\n> \tbool match(T *obj) { return obj == obj_; }\n> diff --git a/include/libcamera/internal/control_validator.h b/include/libcamera/internal/control_validator.h\n> index 4a00b9b7f686..206006954cd9 100644\n> --- a/include/libcamera/internal/control_validator.h\n> +++ b/include/libcamera/internal/control_validator.h\n> @@ -16,7 +16,7 @@ class ControlId;\n> class ControlValidator\n> {\n> public:\n> -\tvirtual ~ControlValidator() {}\n> +\tvirtual ~ControlValidator() = default;\n> \n> \tvirtual const std::string &name() const = 0;\n> \tvirtual bool validate(unsigned int id) const = 0;\n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index b429ce5a68a3..49399f4eb856 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -42,7 +42,7 @@ class IPAProxyFactory\n> {\n> public:\n> \tIPAProxyFactory(const char *name);\n> -\tvirtual ~IPAProxyFactory() {}\n> +\tvirtual ~IPAProxyFactory() = default;\n> \n> \tvirtual std::unique_ptr create(IPAModule *ipam) = 0;\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index 54311c14895b..43a35bef8f35 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -31,7 +31,7 @@ protected:\n> \t\t: dev_(dev), id_(id)\n> \t{\n> \t}\n> -\tvirtual ~MediaObject() {}\n> +\tvirtual ~MediaObject() = default;\n> \n> \tMediaDevice *dev_;\n> \tunsigned int id_;\n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index a4e1b529c461..c12c8904858e 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -40,7 +40,7 @@ public:\n> \t\t: pipe_(pipe)\n> \t{\n> \t}\n> -\tvirtual ~CameraData() {}\n> +\tvirtual ~CameraData() = default;\n> \n> \tCamera *camera_;\n> \tPipelineHandler *pipe_;\n> @@ -118,7 +118,7 @@ class PipelineHandlerFactory\n> {\n> public:\n> \tPipelineHandlerFactory(const char *name);\n> -\tvirtual ~PipelineHandlerFactory() {}\n> +\tvirtual ~PipelineHandlerFactory() = default;\n> \n> \tstd::shared_ptr create(CameraManager *manager);\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 5016ec25ea9c..322b7079070e 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -150,7 +150,7 @@ struct CameraSensorInfo;\n> class IPAInterface\n> {\n> public:\n> -\tvirtual ~IPAInterface() {}\n> +\tvirtual ~IPAInterface() = default;\n> \n> \tvirtual int init(const IPASettings &settings) = 0;\n> \tvirtual int start() = 0;\n> diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> index 270ea6091798..0ca2ba38c528 100644\n> --- a/src/android/jpeg/encoder.h\n> +++ b/src/android/jpeg/encoder.h\n> @@ -14,7 +14,7 @@\n> class Encoder\n> {\n> public:\n> -\tvirtual ~Encoder() {}\n> +\tvirtual ~Encoder() = default;\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> \tvirtual int encode(const libcamera::FrameBuffer &source,\n> diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> index 5f87a5d1bc30..e0f91880f0bf 100644\n> --- a/src/android/post_processor.h\n> +++ b/src/android/post_processor.h\n> @@ -16,7 +16,7 @@ class CameraMetadata;\n> class PostProcessor\n> {\n> public:\n> -\tvirtual ~PostProcessor() {}\n> +\tvirtual ~PostProcessor() = default;\n> \n> \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n> \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\n> diff --git a/src/cam/options.h b/src/cam/options.h\n> index 184866195eef..f02eeca2eef9 100644\n> --- a/src/cam/options.h\n> +++ b/src/cam/options.h\n> @@ -73,7 +73,7 @@ public:\n> \t{\n> \t};\n> \n> -\tvirtual ~KeyValueParser() {}\n> +\tvirtual ~KeyValueParser() = default;\n> \n> \tbool addOption(const char *name, OptionType type, const char *help,\n> \t\t OptionArgument argument = ArgumentNone);\n> diff --git a/src/libcamera/pipeline/rkisp1/timeline.h b/src/libcamera/pipeline/rkisp1/timeline.h\n> index 88f99329873d..0c37b06fa6df 100644\n> --- a/src/libcamera/pipeline/rkisp1/timeline.h\n> +++ b/src/libcamera/pipeline/rkisp1/timeline.h\n> @@ -22,7 +22,7 @@ public:\n> \tFrameAction(unsigned int frame, unsigned int type)\n> \t\t: frame_(frame), type_(type) {}\n> \n> -\tvirtual ~FrameAction() {}\n> +\tvirtual ~FrameAction() = default;\n> \n> \tunsigned int frame() const { return frame_; }\n> \tunsigned int type() const { return type_; }\n> @@ -38,7 +38,7 @@ class Timeline\n> {\n> public:\n> \tTimeline();\n> -\tvirtual ~Timeline() {}\n> +\tvirtual ~Timeline() = default;\n> \n> \tvirtual void reset();\n> \tvirtual void scheduleAction(std::unique_ptr action);\n> diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> index 67da1df26a0c..e33dc4525224 100644\n> --- a/src/qcam/viewfinder.h\n> +++ b/src/qcam/viewfinder.h\n> @@ -22,7 +22,7 @@ struct MappedBuffer {\n> class ViewFinder\n> {\n> public:\n> -\tvirtual ~ViewFinder() {}\n> +\tvirtual ~ViewFinder() = default;\n> \n> \tvirtual const QList &nativeFormats() const = 0;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 94C77BDB13\n\tfor ;\n\tFri, 23 Oct 2020 08:53:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 08486615D5;\n\tFri, 23 Oct 2020 10:53:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C12A60350\n\tfor ;\n\tFri, 23 Oct 2020 10:53:23 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84F79B26;\n\tFri, 23 Oct 2020 10:53:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oGrCFaAC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603443202;\n\tbh=ezsSvI071D5YovR1KWhRVBtiyfPT1eUxJW5d7ZM79Mc=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=oGrCFaACrfybuD2re8Rz7Rso+7dBUI0ZcLOfCUChy1E7OlRmesIggBl3KPMIByqPE\n\tCtx3zHGiuyM4iNg542ECcJwhsdIm6OanaDYkRVxadpWmz7T8M/CBlGElNNWjiDf5tp\n\tl1Pobtyub4oyvWXj2+0GIGghSGSf/LIlT9U9zPFg=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5b636a47-8082-711f-3e57-a7ca83c27d3f@ideasonboard.com>","Date":"Fri, 23 Oct 2020 09:53:19 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13450,"web_url":"https://patchwork.libcamera.org/comment/13450/","msgid":"<20201023195223.GA5979@pendragon.ideasonboard.com>","date":"2020-10-23T19:52:23","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Oct 23, 2020 at 09:53:19AM +0100, Kieran Bingham wrote:\n> On 23/10/2020 06:10, Laurent Pinchart wrote:\n> > The base class of polymorphic classes is required to declare a\n> > destructor. Several of these are empty, and can thus be declared as\n> > defaulted.\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> What about these?:\n> \n> src/ipa/raspberrypi/controller/algorithm.hpp: virtual ~Algorithm() {}\n> src/ipa/raspberrypi/md_parser.hpp: virtual ~MdParser() {}\n> \n> If you've intentionally left those out, or with those fixed:\n\nThat was intentional indeed as I was thinking about going through the\nRPi IPA in the future to propose aligning it better with the coding\nstyle, but now that you make me think about it, I don't see a good\nreason not to address these two locations already. I'll thus fix it.\n\n> Reviewed-by: Kieran Bingham \n> \n> > ---\n> > include/libcamera/bound_method.h | 4 ++--\n> > include/libcamera/internal/control_validator.h | 2 +-\n> > include/libcamera/internal/ipa_proxy.h | 2 +-\n> > include/libcamera/internal/media_object.h | 2 +-\n> > include/libcamera/internal/pipeline_handler.h | 4 ++--\n> > include/libcamera/ipa/ipa_interface.h | 2 +-\n> > src/android/jpeg/encoder.h | 2 +-\n> > src/android/post_processor.h | 2 +-\n> > src/cam/options.h | 2 +-\n> > src/libcamera/pipeline/rkisp1/timeline.h | 4 ++--\n> > src/qcam/viewfinder.h | 2 +-\n> > 11 files changed, 14 insertions(+), 14 deletions(-)\n> >\n> > diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\n> > index d1e4448304a9..95a956530877 100644\n> > --- a/include/libcamera/bound_method.h\n> > +++ b/include/libcamera/bound_method.h\n> > @@ -26,7 +26,7 @@ enum ConnectionType {\n> > class BoundMethodPackBase\n> > {\n> > public:\n> > -\tvirtual ~BoundMethodPackBase() {}\n> > +\tvirtual ~BoundMethodPackBase() = default;\n> > };\n> > \n> > template\n> > @@ -61,7 +61,7 @@ public:\n> > \t\t: obj_(obj), object_(object), connectionType_(type)\n> > \t{\n> > \t}\n> > -\tvirtual ~BoundMethodBase() {}\n> > +\tvirtual ~BoundMethodBase() = default;\n> > \n> > \ttemplate::value> * = nullptr>\n> > \tbool match(T *obj) { return obj == obj_; }\n> > diff --git a/include/libcamera/internal/control_validator.h b/include/libcamera/internal/control_validator.h\n> > index 4a00b9b7f686..206006954cd9 100644\n> > --- a/include/libcamera/internal/control_validator.h\n> > +++ b/include/libcamera/internal/control_validator.h\n> > @@ -16,7 +16,7 @@ class ControlId;\n> > class ControlValidator\n> > {\n> > public:\n> > -\tvirtual ~ControlValidator() {}\n> > +\tvirtual ~ControlValidator() = default;\n> > \n> > \tvirtual const std::string &name() const = 0;\n> > \tvirtual bool validate(unsigned int id) const = 0;\n> > diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> > index b429ce5a68a3..49399f4eb856 100644\n> > --- a/include/libcamera/internal/ipa_proxy.h\n> > +++ b/include/libcamera/internal/ipa_proxy.h\n> > @@ -42,7 +42,7 @@ class IPAProxyFactory\n> > {\n> > public:\n> > \tIPAProxyFactory(const char *name);\n> > -\tvirtual ~IPAProxyFactory() {}\n> > +\tvirtual ~IPAProxyFactory() = default;\n> > \n> > \tvirtual std::unique_ptr create(IPAModule *ipam) = 0;\n> > \n> > diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> > index 54311c14895b..43a35bef8f35 100644\n> > --- a/include/libcamera/internal/media_object.h\n> > +++ b/include/libcamera/internal/media_object.h\n> > @@ -31,7 +31,7 @@ protected:\n> > \t\t: dev_(dev), id_(id)\n> > \t{\n> > \t}\n> > -\tvirtual ~MediaObject() {}\n> > +\tvirtual ~MediaObject() = default;\n> > \n> > \tMediaDevice *dev_;\n> > \tunsigned int id_;\n> > diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> > index a4e1b529c461..c12c8904858e 100644\n> > --- a/include/libcamera/internal/pipeline_handler.h\n> > +++ b/include/libcamera/internal/pipeline_handler.h\n> > @@ -40,7 +40,7 @@ public:\n> > \t\t: pipe_(pipe)\n> > \t{\n> > \t}\n> > -\tvirtual ~CameraData() {}\n> > +\tvirtual ~CameraData() = default;\n> > \n> > \tCamera *camera_;\n> > \tPipelineHandler *pipe_;\n> > @@ -118,7 +118,7 @@ class PipelineHandlerFactory\n> > {\n> > public:\n> > \tPipelineHandlerFactory(const char *name);\n> > -\tvirtual ~PipelineHandlerFactory() {}\n> > +\tvirtual ~PipelineHandlerFactory() = default;\n> > \n> > \tstd::shared_ptr create(CameraManager *manager);\n> > \n> > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > index 5016ec25ea9c..322b7079070e 100644\n> > --- a/include/libcamera/ipa/ipa_interface.h\n> > +++ b/include/libcamera/ipa/ipa_interface.h\n> > @@ -150,7 +150,7 @@ struct CameraSensorInfo;\n> > class IPAInterface\n> > {\n> > public:\n> > -\tvirtual ~IPAInterface() {}\n> > +\tvirtual ~IPAInterface() = default;\n> > \n> > \tvirtual int init(const IPASettings &settings) = 0;\n> > \tvirtual int start() = 0;\n> > diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\n> > index 270ea6091798..0ca2ba38c528 100644\n> > --- a/src/android/jpeg/encoder.h\n> > +++ b/src/android/jpeg/encoder.h\n> > @@ -14,7 +14,7 @@\n> > class Encoder\n> > {\n> > public:\n> > -\tvirtual ~Encoder() {}\n> > +\tvirtual ~Encoder() = default;\n> > \n> > \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n> > \tvirtual int encode(const libcamera::FrameBuffer &source,\n> > diff --git a/src/android/post_processor.h b/src/android/post_processor.h\n> > index 5f87a5d1bc30..e0f91880f0bf 100644\n> > --- a/src/android/post_processor.h\n> > +++ b/src/android/post_processor.h\n> > @@ -16,7 +16,7 @@ class CameraMetadata;\n> > class PostProcessor\n> > {\n> > public:\n> > -\tvirtual ~PostProcessor() {}\n> > +\tvirtual ~PostProcessor() = default;\n> > \n> > \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n> > \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\n> > diff --git a/src/cam/options.h b/src/cam/options.h\n> > index 184866195eef..f02eeca2eef9 100644\n> > --- a/src/cam/options.h\n> > +++ b/src/cam/options.h\n> > @@ -73,7 +73,7 @@ public:\n> > \t{\n> > \t};\n> > \n> > -\tvirtual ~KeyValueParser() {}\n> > +\tvirtual ~KeyValueParser() = default;\n> > \n> > \tbool addOption(const char *name, OptionType type, const char *help,\n> > \t\t OptionArgument argument = ArgumentNone);\n> > diff --git a/src/libcamera/pipeline/rkisp1/timeline.h b/src/libcamera/pipeline/rkisp1/timeline.h\n> > index 88f99329873d..0c37b06fa6df 100644\n> > --- a/src/libcamera/pipeline/rkisp1/timeline.h\n> > +++ b/src/libcamera/pipeline/rkisp1/timeline.h\n> > @@ -22,7 +22,7 @@ public:\n> > \tFrameAction(unsigned int frame, unsigned int type)\n> > \t\t: frame_(frame), type_(type) {}\n> > \n> > -\tvirtual ~FrameAction() {}\n> > +\tvirtual ~FrameAction() = default;\n> > \n> > \tunsigned int frame() const { return frame_; }\n> > \tunsigned int type() const { return type_; }\n> > @@ -38,7 +38,7 @@ class Timeline\n> > {\n> > public:\n> > \tTimeline();\n> > -\tvirtual ~Timeline() {}\n> > +\tvirtual ~Timeline() = default;\n> > \n> > \tvirtual void reset();\n> > \tvirtual void scheduleAction(std::unique_ptr action);\n> > diff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\n> > index 67da1df26a0c..e33dc4525224 100644\n> > --- a/src/qcam/viewfinder.h\n> > +++ b/src/qcam/viewfinder.h\n> > @@ -22,7 +22,7 @@ struct MappedBuffer {\n> > class ViewFinder\n> > {\n> > public:\n> > -\tvirtual ~ViewFinder() {}\n> > +\tvirtual ~ViewFinder() = default;\n> > \n> > \tvirtual const QList &nativeFormats() const = 0;\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93FFDC3D3C\n\tfor ;\n\tFri, 23 Oct 2020 19:53:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0320615D3;\n\tFri, 23 Oct 2020 21:53:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17C9860350\n\tfor ;\n\tFri, 23 Oct 2020 21:53:10 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9686CB26;\n\tFri, 23 Oct 2020 21:53:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TmJk6dfY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603482789;\n\tbh=S5pQtB6IK/n1g0wGyiB7evUPgALGuuH2R2ZwgCyvPbQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TmJk6dfYMb1bOWna+PKvh/t6BASGPpa1Fhf2VAuB0H0gwXFalaxT2vkrRS0qhAThZ\n\tnMCyun3MPqqT3VXgeoOdNQirBBvJPPy9nfCfSxbHM92cmQbwT2wlqWixpUqKtFijKn\n\tD7qFl9uKTk//R+Hfe1XF9Q3eRKOk4hcbqsONghno=","Date":"Fri, 23 Oct 2020 22:52:23 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201023195223.GA5979@pendragon.ideasonboard.com>","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>\n\t<5b636a47-8082-711f-3e57-a7ca83c27d3f@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5b636a47-8082-711f-3e57-a7ca83c27d3f@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]