{"id":10206,"url":"https://patchwork.libcamera.org/api/patches/10206/?format=json","web_url":"https://patchwork.libcamera.org/patch/10206/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201023051021.16389-3-laurent.pinchart@ideasonboard.com>","date":"2020-10-23T05:10:20","name":"[libcamera-devel,2/3] libcamera: Drop unneeded empty default constructors and destructors","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"caa0d536665c33542ddf44af2d53d720158a0319","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10206/mbox/","series":[{"id":1405,"url":"https://patchwork.libcamera.org/api/series/1405/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1405","date":"2020-10-23T05:10:18","name":"libcamera: Miscellaneous constructors and destructors cleanups","version":1,"mbox":"https://patchwork.libcamera.org/series/1405/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10206/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10206/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDE18BDB13\n\tfor ;\n\tFri, 23 Oct 2020 05:11:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8962A615D4;\n\tFri, 23 Oct 2020 07:11:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 58FC26034E\n\tfor ;\n\tFri, 23 Oct 2020 07:11:12 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04B69B26\n\tfor ;\n\tFri, 23 Oct 2020 07:11:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eYQiW6GV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603429872;\n\tbh=uvPvY/k7QQs6iSvqiGzvcP6YNky6TFcUjNVR/JS+190=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=eYQiW6GVZ00H3lZ3tZjsCQgxjflW1kMK/QL7xQ6yIbIWDjswKvszv33j8l79mpYH/\n\tXPiuano1arg/LslHZcdxiU5PYqkCCXQdGATUUhtA1Q650tJYtLDcRabLfFpXN1XYXU\n\t4qyZ82aOayRjWYaZrrJ5Su7pMsN8cf6Zzu8WXHWA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Oct 2020 08:10:20 +0300","Message-Id":"<20201023051021.16389-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/3] libcamera: Drop unneeded empty\n\tdefault constructors and destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A few default constructors and destructors are needlessly defined as\nempty. Drop them.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/signal.h | 1 -\n test/media_device/media_device_print_test.cpp | 4 ----\n 2 files changed, 5 deletions(-)","diff":"diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex accb797e911c..5bcd7a77c5f1 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -38,7 +38,6 @@ template\n class Signal : public SignalBase\n {\n public:\n-\tSignal() {}\n \t~Signal()\n \t{\n \t\tdisconnect();\ndiff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\nindex 436d4e8af614..cdec5b8da3ec 100644\n--- a/test/media_device/media_device_print_test.cpp\n+++ b/test/media_device/media_device_print_test.cpp\n@@ -25,10 +25,6 @@ using namespace std;\n */\n class MediaDevicePrintTest : public Test\n {\n-public:\n-\tMediaDevicePrintTest() {}\n-\t~MediaDevicePrintTest() {}\n-\n protected:\n \tint init() { return 0; }\n \tint run();\n","prefixes":["libcamera-devel","2/3"]}