[{"id":13432,"web_url":"https://patchwork.libcamera.org/comment/13432/","msgid":"<0db8cef1-54ba-4c12-cfc3-d0e2dbb6e342@uajain.com>","date":"2020-10-23T05:21:58","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/people/1/","name":"Umang Jain","email":"email@uajain.com"},"content":"Hi Laurent,\n\nThank you for the patch.\n\nOn 10/23/20 10:40 AM, Laurent Pinchart wrote:\n> The MediaEntity, MediaLink and MediaPad classes don't need custom\n> destructors. For MediaEntity and MediaPad, the destructors clear a\n> vector embedded in the classes, which will be done by the default\n> destructor. For MediaLink, the destructor is already empty. Remove them.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Umang Jain \n> ---\n> include/libcamera/internal/media_object.h | 3 ---\n> src/libcamera/media_object.cpp | 18 ------------------\n> 2 files changed, 21 deletions(-)\n>\n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index be6fb8961349..54311c14895b 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -51,7 +51,6 @@ private:\n> \tMediaLink(const struct media_v2_link *link,\n> \t\t MediaPad *source, MediaPad *sink);\n> \tMediaLink(const MediaLink &) = delete;\n> -\t~MediaLink() {}\n> \n> \tMediaPad *source_;\n> \tMediaPad *sink_;\n> @@ -73,7 +72,6 @@ private:\n> \n> \tMediaPad(const struct media_v2_pad *pad, MediaEntity *entity);\n> \tMediaPad(const MediaPad &) = delete;\n> -\t~MediaPad();\n> \n> \tunsigned int index_;\n> \tMediaEntity *entity_;\n> @@ -105,7 +103,6 @@ private:\n> \tMediaEntity(MediaDevice *dev, const struct media_v2_entity *entity,\n> \t\t unsigned int major = 0, unsigned int minor = 0);\n> \tMediaEntity(const MediaEntity &) = delete;\n> -\t~MediaEntity();\n> \n> \tvoid addPad(MediaPad *pad);\n> \n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index b7bf048c985d..056036635902 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -191,15 +191,6 @@ MediaPad::MediaPad(const struct media_v2_pad *pad, MediaEntity *entity)\n> {\n> }\n> \n> -MediaPad::~MediaPad()\n> -{\n> -\t/*\n> -\t * Don't delete the links as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tlinks_.clear();\n> -}\n> -\n> /**\n> * \\fn MediaPad::index()\n> * \\brief Retrieve the pad index\n> @@ -371,15 +362,6 @@ MediaEntity::MediaEntity(MediaDevice *dev,\n> {\n> }\n> \n> -MediaEntity::~MediaEntity()\n> -{\n> -\t/*\n> -\t * Don't delete the pads as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tpads_.clear();\n> -}\n> -\n> /**\n> * \\brief Add \\a pad to the entity's list of pads\n> * \\param[in] pad The pad to add to the list","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1952EBDB13\n\tfor ;\n\tFri, 23 Oct 2020 05:22:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DECB8615D4;\n\tFri, 23 Oct 2020 07:22:02 +0200 (CEST)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28A526034E\n\tfor ;\n\tFri, 23 Oct 2020 07:22:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"EV+GxcOX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603430520; bh=IhpdwFgGYI4DKvcEudyQMswsPA0tP1Cdl1Jy+2ywuR8=;\n\th=Subject:To:References:From:In-Reply-To;\n\tb=EV+GxcOXBxp/8g3HWYq250dLEws+xTsbBhHdEnIm55qgBJgJ0SkbnDWG/VjtRe6s0\n\tBkIw+XO3USh64wl2Cohs5aAZ1/L3TO2Oe/0W+sn78EMXIPrwZL6OQOu6jX1uJipCP8\n\tNe8o0Z5IdiSydWpEJiYnqJg1IN4fiPwdtNsuZ8ltZkluG7x+/bAjcywgBlKZYsQDE4\n\tw7euX7E5tuFLiurNDRTZALVxZJ8kSwjYMujHw1mOIb9OcGbPD6qLWsm5YW/dVhJDEe\n\tM0IEObY2Zw/vuKMo5pulMmbph/Ffaf9rEcRVaB9UKWwJEhCkJ6AJYTJCbQRvS2t3/b\n\tv41YMMTNqnXEA==","To":"libcamera-devel@lists.libcamera.org","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","Message-ID":"<0db8cef1-54ba-4c12-cfc3-d0e2dbb6e342@uajain.com>","Date":"Fri, 23 Oct 2020 10:51:58 +0530","Mime-Version":"1.0","In-Reply-To":"<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13440,"web_url":"https://patchwork.libcamera.org/comment/13440/","msgid":"<4ef49c7f-cfcf-7275-f7dd-4c1be5ddc9db@ideasonboard.com>","date":"2020-10-23T08:45:43","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 23/10/2020 06:10, Laurent Pinchart wrote:\n> The MediaEntity, MediaLink and MediaPad classes don't need custom\n> destructors. For MediaEntity and MediaPad, the destructors clear a\n> vector embedded in the classes, which will be done by the default\n> destructor. For MediaLink, the destructor is already empty. Remove them.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/media_object.h | 3 ---\n> src/libcamera/media_object.cpp | 18 ------------------\n> 2 files changed, 21 deletions(-)\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index be6fb8961349..54311c14895b 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -51,7 +51,6 @@ private:\n> \tMediaLink(const struct media_v2_link *link,\n> \t\t MediaPad *source, MediaPad *sink);\n> \tMediaLink(const MediaLink &) = delete;\n> -\t~MediaLink() {}\n> \n> \tMediaPad *source_;\n> \tMediaPad *sink_;\n> @@ -73,7 +72,6 @@ private:\n> \n> \tMediaPad(const struct media_v2_pad *pad, MediaEntity *entity);\n> \tMediaPad(const MediaPad &) = delete;\n> -\t~MediaPad();\n> \n> \tunsigned int index_;\n> \tMediaEntity *entity_;\n> @@ -105,7 +103,6 @@ private:\n> \tMediaEntity(MediaDevice *dev, const struct media_v2_entity *entity,\n> \t\t unsigned int major = 0, unsigned int minor = 0);\n> \tMediaEntity(const MediaEntity &) = delete;\n> -\t~MediaEntity();\n> \n> \tvoid addPad(MediaPad *pad);\n> \n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index b7bf048c985d..056036635902 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -191,15 +191,6 @@ MediaPad::MediaPad(const struct media_v2_pad *pad, MediaEntity *entity)\n> {\n> }\n> \n> -MediaPad::~MediaPad()\n> -{\n> -\t/*\n> -\t * Don't delete the links as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tlinks_.clear();\n> -}\n> -\n> /**\n> * \\fn MediaPad::index()\n> * \\brief Retrieve the pad index\n> @@ -371,15 +362,6 @@ MediaEntity::MediaEntity(MediaDevice *dev,\n> {\n> }\n> \n> -MediaEntity::~MediaEntity()\n> -{\n> -\t/*\n> -\t * Don't delete the pads as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tpads_.clear();\n> -}\n> -\n> /**\n> * \\brief Add \\a pad to the entity's list of pads\n> * \\param[in] pad The pad to add to the list\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2785AC3D3C\n\tfor ;\n\tFri, 23 Oct 2020 08:45:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACBA7615D5;\n\tFri, 23 Oct 2020 10:45:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C20C860350\n\tfor ;\n\tFri, 23 Oct 2020 10:45:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B49E4B26;\n\tFri, 23 Oct 2020 10:45:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bVqaZ0RK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603442745;\n\tbh=i+gqk3pVxVozLwodJrZibvCkFvrM/cCHvHM4SDKXDE4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=bVqaZ0RKjokdVaIJyzEDUuVf00B20QIvyo9WbVLncvkWY9pzA8r1FMJmKcj/Om7cC\n\tG+c+Mw1wDNQQlaFsAljqyVGti/pmh2XKyiBaGnMEV3toIGkFvOhL6lnRyZi7iJcE3I\n\tNUxv0vhW0N4ahRejLcpqnZK01eUdHtSuZmExgwSA=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4ef49c7f-cfcf-7275-f7dd-4c1be5ddc9db@ideasonboard.com>","Date":"Fri, 23 Oct 2020 09:45:43 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13466,"web_url":"https://patchwork.libcamera.org/comment/13466/","msgid":"<20201024163632.5oosl5nosdeq6c6d@uno.localdomain>","date":"2020-10-24T16:36:32","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Oct 23, 2020 at 08:10:19AM +0300, Laurent Pinchart wrote:\n> The MediaEntity, MediaLink and MediaPad classes don't need custom\n> destructors. For MediaEntity and MediaPad, the destructors clear a\n> vector embedded in the classes, which will be done by the default\n> destructor. For MediaLink, the destructor is already empty. Remove them.\n>\n> Signed-off-by: Laurent Pinchart \n\nYouth mistakes ;)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> include/libcamera/internal/media_object.h | 3 ---\n> src/libcamera/media_object.cpp | 18 ------------------\n> 2 files changed, 21 deletions(-)\n>\n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index be6fb8961349..54311c14895b 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -51,7 +51,6 @@ private:\n> \tMediaLink(const struct media_v2_link *link,\n> \t\t MediaPad *source, MediaPad *sink);\n> \tMediaLink(const MediaLink &) = delete;\n> -\t~MediaLink() {}\n>\n> \tMediaPad *source_;\n> \tMediaPad *sink_;\n> @@ -73,7 +72,6 @@ private:\n>\n> \tMediaPad(const struct media_v2_pad *pad, MediaEntity *entity);\n> \tMediaPad(const MediaPad &) = delete;\n> -\t~MediaPad();\n>\n> \tunsigned int index_;\n> \tMediaEntity *entity_;\n> @@ -105,7 +103,6 @@ private:\n> \tMediaEntity(MediaDevice *dev, const struct media_v2_entity *entity,\n> \t\t unsigned int major = 0, unsigned int minor = 0);\n> \tMediaEntity(const MediaEntity &) = delete;\n> -\t~MediaEntity();\n>\n> \tvoid addPad(MediaPad *pad);\n>\n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index b7bf048c985d..056036635902 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -191,15 +191,6 @@ MediaPad::MediaPad(const struct media_v2_pad *pad, MediaEntity *entity)\n> {\n> }\n>\n> -MediaPad::~MediaPad()\n> -{\n> -\t/*\n> -\t * Don't delete the links as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tlinks_.clear();\n> -}\n> -\n> /**\n> * \\fn MediaPad::index()\n> * \\brief Retrieve the pad index\n> @@ -371,15 +362,6 @@ MediaEntity::MediaEntity(MediaDevice *dev,\n> {\n> }\n>\n> -MediaEntity::~MediaEntity()\n> -{\n> -\t/*\n> -\t * Don't delete the pads as we only borrow the reference owned by\n> -\t * MediaDevice.\n> -\t */\n> -\tpads_.clear();\n> -}\n> -\n> /**\n> * \\brief Add \\a pad to the entity's list of pads\n> * \\param[in] pad The pad to add to the list\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A7A4C3B5C\n\tfor ;\n\tSat, 24 Oct 2020 16:36:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBE9E61D64;\n\tSat, 24 Oct 2020 18:36:35 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46D68605BF\n\tfor ;\n\tSat, 24 Oct 2020 18:36:34 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 6A848C0008;\n\tSat, 24 Oct 2020 16:36:33 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 24 Oct 2020 18:36:32 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20201024163632.5oosl5nosdeq6c6d@uno.localdomain>","References":"<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>\n\t<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201023051021.16389-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: media_object: Remove\n\tunneeded destructors","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]