[{"id":127,"web_url":"https://patchwork.libcamera.org/comment/127/","msgid":"<20181230101734.2ei2vlpoqcfvwgva@uno.localdomain>","date":"2018-12-30T10:17:34","subject":"Re: [libcamera-devel] [PATCH v2 07/12] libcamera:\n\tdevice_enumerator: add factory for DeviceEnumerators","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sat, Dec 29, 2018 at 04:28:50AM +0100, Niklas Söderlund wrote:\n> Provide a factory for DeviceEnumerator objects. Depending on which\n> libraries are available there will be different ways to enumerate\n> information in the system. This factory hides this from the rest of the\n> library.\n>\n> Currently udev enumeration is the only supported implementation, a sysfs\n> implementation is another method that surely will be added in the\n> future.\n>\n\nReviewed-by; Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/libcamera/device_enumerator.cpp | 19 +++++++++++++++++++\n> src/libcamera/include/device_enumerator.h | 2 ++\n> 2 files changed, 21 insertions(+)\n>\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 3cafd0d3703dac99..26a3e68fcf39e43a 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -121,6 +121,25 @@ bool DeviceMatch::match(const DeviceInfo *info) const\n> * Enumerator Base\n> */\n>\n> +DeviceEnumerator *DeviceEnumerator::create()\n> +{\n> +\tDeviceEnumerator *enumerator;\n> +\n> +\t/* TODO: add compile time checks to only try udev enumerator if libudev is available */\n> +\tenumerator = new DeviceEnumeratorUdev();\n> +\tif (!enumerator->init())\n> +\t\treturn enumerator;\n> +\n> +\t/*\n> +\t * NOTE: Either udev is not available or initialization of it\n> +\t * failed, use/fallback on sysfs enumerator\n> +\t */\n> +\n> +\t/* TODO: add a sysfs based enumerator */\n> +\n> +\treturn nullptr;\n> +}\n> +\n> DeviceEnumerator::~DeviceEnumerator()\n> {\n> \tfor (DeviceInfo *dev : devices_) {\n> diff --git a/src/libcamera/include/device_enumerator.h b/src/libcamera/include/device_enumerator.h\n> index 5348e6cf583dbd15..24bca0e3fc32c377 100644\n> --- a/src/libcamera/include/device_enumerator.h\n> +++ b/src/libcamera/include/device_enumerator.h\n> @@ -56,6 +56,8 @@ private:\n> class DeviceEnumerator\n> {\n> public:\n> +\tstatic DeviceEnumerator *create();\n> +\n> \tvirtual ~DeviceEnumerator();\n>\n> \tvirtual int init() = 0;\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BB3360B31\n\tfor ;\n\tSun, 30 Dec 2018 11:17:32 +0100 (CET)","from uno.localdomain (unknown [37.176.180.32])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D84E340002;\n\tSun, 30 Dec 2018 10:17:31 +0000 (UTC)"],"X-Originating-IP":"37.176.180.32","Date":"Sun, 30 Dec 2018 11:17:34 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20181230101734.2ei2vlpoqcfvwgva@uno.localdomain>","References":"<20181229032855.26249-1-niklas.soderlund@ragnatech.se>\n\t<20181229032855.26249-8-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"prmkaev6q2bwmrk3\"","Content-Disposition":"inline","In-Reply-To":"<20181229032855.26249-8-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 07/12] libcamera:\n\tdevice_enumerator: add factory for DeviceEnumerators","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 30 Dec 2018 10:17:32 -0000"}}]