[{"id":13406,"web_url":"https://patchwork.libcamera.org/comment/13406/","msgid":"","date":"2020-10-22T08:38:09","subject":"Re: [libcamera-devel] [PATCH 2/4] pipeline: raspberrypi: return an\n\terror if setFormat() fails","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Tomi,\n\nThank you for your patch.\n\nOn Thu, 22 Oct 2020 at 09:17, Tomi Valkeinen wrote:\n\n> The method calls setFormat(), stores the return value, but then does not\n> do anything with the return value. I presume it is meant to fail and\n> return the error.\n>\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index dd62dfc7..aa8d9340 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -586,6 +586,8 @@ int PipelineHandlerRPi::configure(Camera *camera,\n> CameraConfiguration *config)\n> * because of flips in the sensor.\n> */\n> ret = data->isp_[Isp::Input].dev()->setFormat(&sensorFormat);\n> + if (ret)\n> + return ret;\n>\n\nLooks good to me.\nReviewed-by: Naushir Patuck \n\n\n>\n> /*\n> * See which streams are requested, and route the user\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 735D1C3D3C\n\tfor ;\n\tThu, 22 Oct 2020 08:38:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F35A761417;\n\tThu, 22 Oct 2020 10:38:27 +0200 (CEST)","from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5033560351\n\tfor ;\n\tThu, 22 Oct 2020 10:38:26 +0200 (CEST)","by mail-lf1-x141.google.com with SMTP id b1so1195966lfp.11\n\tfor ;\n\tThu, 22 Oct 2020 01:38:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KGi8kFkx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=lFj0pRZK9zwusl5/EibIWKD1vG3CZV0aXFbl3X5+xs8=;\n\tb=KGi8kFkxKW68h8Wxehij0boPd3GGQiSl3cpxaiGuGuiydSWtEMiX2YFCgmBK5kPC44\n\tvWwg/MPsgAHXUavA0B6O3knTB5uAVvEhlM+pM7oGHNL4LyyPgxig0jUzm3RzhXSxvicg\n\t6ADKskiLoWxwSD/ItgF/QaQhuENHEUFATa8uT9M7nl82Tzo0ujxRwAeiVLQaVRcO5H3p\n\tCDoRqZXxOzOr7NgJIiGlMlDZh9miW/ky5JInRviSdtVTmnD9b5tcNWPJVkB3yurgvYq3\n\tQ0mC5f0S1b3UzjeJeTEpj4Q1HOmVEoGtOyJpsDv73agKtFjAf96wp4eB3YQSiYRzNfcQ\n\t+Zig==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=lFj0pRZK9zwusl5/EibIWKD1vG3CZV0aXFbl3X5+xs8=;\n\tb=nci/v+2C4vdPBjySLTxLonUq1s9U0B9SQJUi9n9tf6wiw7piruGnXC3lf8eQEr6ymo\n\tMdGocQvYaxXAAT03PxyqZyfx0kdVtJBfmPIzmsGJUtcr8p2fmce/6hS73AxyVP+Dk5aK\n\tRW0+xgVZAwsXCsEtM/xeqEZ/PA8alD29ixR2pWPvOhvuHTvWAOUC9rIBU0lPSzDTqv21\n\tNHYwidZI5tjiZirFHBbXZBGabL0j8gjpdiGoG4ka26bFqU1bi1LwzDQAppPMNDLZXQZt\n\tY/Ewfe46JcSUzzYBysk7DjmCHPFk9doXgj8EmA2lVqhcnsUBMM6VOdOvLr5thTocolY9\n\t9mfg==","X-Gm-Message-State":"AOAM5334pWsypZz+yDu3OGODEz85riA65MFjk5I9bIIj1H4ugS2Jf1mK\n\telnWoJ3ksnD4YpqQFXftuh0rWfWsIXnqizsTeeBKTw==","X-Google-Smtp-Source":"ABdhPJyU3nmjX2UN5l2I13wnMkuLa+v46LzFNUMJDL+BshiYPqE9Ore6dpuTax4QJSSsgRqmZaIvQlAWgdfRNOhvxJ8=","X-Received":"by 2002:ac2:550c:: with SMTP id j12mr419531lfk.488.1603355905749;\n\tThu, 22 Oct 2020 01:38:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>\n\t<20201022081731.36217-2-tomi.valkeinen@iki.fi>","In-Reply-To":"<20201022081731.36217-2-tomi.valkeinen@iki.fi>","From":"Naushir Patuck ","Date":"Thu, 22 Oct 2020 09:38:09 +0100","Message-ID":"","To":"Tomi Valkeinen ","Subject":"Re: [libcamera-devel] [PATCH 2/4] pipeline: raspberrypi: return an\n\terror if setFormat() fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============1584685409151843216==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13408,"web_url":"https://patchwork.libcamera.org/comment/13408/","msgid":"<25267fef-1d84-3dde-dba6-9f317b45aae6@ideasonboard.com>","date":"2020-10-22T09:49:57","subject":"Re: [libcamera-devel] [PATCH 2/4] pipeline: raspberrypi: return an\n\terror if setFormat() fails","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 22/10/2020 09:17, Tomi Valkeinen wrote:\n> The method calls setFormat(), stores the return value, but then does not\n> do anything with the return value. I presume it is meant to fail and\n> return the error.\n> \n> Signed-off-by: Tomi Valkeinen \n\nIndeed, it looks that way to me.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index dd62dfc7..aa8d9340 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -586,6 +586,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t * because of flips in the sensor.\n> \t */\n> \tret = data->isp_[Isp::Input].dev()->setFormat(&sensorFormat);\n> +\tif (ret)\n> +\t\treturn ret;\n> \n> \t/*\n> \t * See which streams are requested, and route the user\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2D3FBDB13\n\tfor ;\n\tThu, 22 Oct 2020 09:50:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4774561439;\n\tThu, 22 Oct 2020 11:50:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E962560351\n\tfor ;\n\tThu, 22 Oct 2020 11:50:00 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C09A53;\n\tThu, 22 Oct 2020 11:50:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mc1uAF66\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603360200;\n\tbh=HH81rx6rfs93RMEAbO5nWsoxhxTmNKuDjEK2pRg75c4=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=mc1uAF66IoAtOsF71O4Ub3iP8nsXOWLVasE8HoVT82No3+TmKr36TOh/Q3ZaqFTIv\n\tF3brUAMH4qEZ2ie0wnAKoSRMWJsea6ZTuoYq9LsyzY/9o/yiZptOEbIyLkxX9NJ8Hp\n\tmRBGFvxhZcEpAxDowk/c4BbVnI4hRi26DB8VjauU=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>\n\t<20201022081731.36217-2-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<25267fef-1d84-3dde-dba6-9f317b45aae6@ideasonboard.com>","Date":"Thu, 22 Oct 2020 10:49:57 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201022081731.36217-2-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] pipeline: raspberrypi: return an\n\terror if setFormat() fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]