{"id":10194,"url":"https://patchwork.libcamera.org/api/patches/10194/?format=json","web_url":"https://patchwork.libcamera.org/patch/10194/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>","date":"2020-10-22T08:17:28","name":"[libcamera-devel,1/4] Add .clang-tidy","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"702f9c7ca2736a063127f245251339330663e62b","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10194/mbox/","series":[{"id":1403,"url":"https://patchwork.libcamera.org/api/series/1403/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1403","date":"2020-10-22T08:17:28","name":"[libcamera-devel,1/4] Add .clang-tidy","version":1,"mbox":"https://patchwork.libcamera.org/series/1403/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10194/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10194/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9786C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Oct 2020 08:17:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 596546113E;\n\tThu, 22 Oct 2020 10:17:51 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF6D960351\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 10:17:49 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id p15so972252ljj.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 01:17:49 -0700 (PDT)","from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tl3sm187007lji.36.2020.10.22.01.17.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 Oct 2020 01:17:48 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ozTGpoZ0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=WjvKOLmQorb3MNvkiZVJZv9BXLmYWqgQG8yB7vySHuY=;\n\tb=ozTGpoZ0nYGMMSVElGiXpBVW+9IG5+S5ciPhY5kaopN+dzT49wFPkQ2rNi7FWtUiPq\n\tyZoCLzjkMrrs5K7zVqhjNMvs3hT/ou5NHyDkB+yJogADaG5GBjQ4dr9LGcYoke9bhGDR\n\tLaN42kR2TpgjoNMEu98iC59dRq1nUY23dJTme5WQvNQXD4oxtyL/2dV9jDMT7kGIiJms\n\tLTwoCsRNDx5uY7zBWYO0YeA5tW1mQBVp46vJXyDlkcbDx72foNBXH3BlhWd5+z0tho+c\n\tBHXSWocmece03IqNfsV/mI95WRw13ibHTO8sTktuh67k4VSXGioIE7wVLXKrqd3/SlVf\n\t6SuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=WjvKOLmQorb3MNvkiZVJZv9BXLmYWqgQG8yB7vySHuY=;\n\tb=k+lP0rIY4WUgN+FP+72otUowrq0fSi1TQjHUbzTxLb41DzaF36BRXGxXUurMJ0M1pG\n\tpzs5RNXqhg9imk8ei7meiHP/5nk/eVKEklCw+TYrnXXjiVZJGJuJLdw10KqLXtxqPJXq\n\tbb/4+n9Lz7njIQDChhKVnTzsNSUozwxGUHKBycZLW9iLZ74s0zNaXk803ENRtpvVUVbO\n\tq+Tc5uAI8FWuhygtuzXMuNgAasJuJg552WR+D2nIrr4a2B8qQhTihYqIiTX3dLzxrPg+\n\tp13jI4pvIeYFJU+D+vEXTP4E+Xf3shIAD4HMU8KHsKKBNewrNW9FTCJEGETQsHmeQQxN\n\tIcGQ==","X-Gm-Message-State":"AOAM530SxpHWM3hfombV/AImdHw9r08QaCZyBYBxft46ykJCBIp1wuco\n\tRyDPaDqEQb5cz57ok4UBYoK9FI624swMTw==","X-Google-Smtp-Source":"ABdhPJzXnXLz3fJLORN9dNIEJ87mr1YMWoUNLPG+Dti01erZv5kBNbi8i0akkRjeSl9lXBO0RGXXKg==","X-Received":"by 2002:a05:651c:97:: with SMTP id\n\t23mr516177ljq.376.1603354669059; \n\tThu, 22 Oct 2020 01:17:49 -0700 (PDT)","From":"Tomi Valkeinen <tomi.valkeinen@iki.fi>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Oct 2020 11:17:28 +0300","Message-Id":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/4] Add .clang-tidy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"Tomi Valkeinen <tomi.valkeinen@iki.fi>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Having .clang-tidy file will give us a 'clang-tidy' meson build target,\nso doing a full clang-tidy run can be done just by:\n\nninja -C build clang-tidy\n\nI did not look at if more checks should be enabled or not. I disabled\nclang-diagnostic-c99-designator as that feature was used in the code,\nand I see no harm with the feature.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n .clang-tidy | 3 +++\n 1 file changed, 3 insertions(+)\n create mode 100644 .clang-tidy","diff":"diff --git a/.clang-tidy b/.clang-tidy\nnew file mode 100644\nindex 00000000..4c47fa8c\n--- /dev/null\n+++ b/.clang-tidy\n@@ -0,0 +1,3 @@\n+Checks:\t\t-clang-diagnostic-c99-designator\n+FormatStyle:\tfile\n+\n","prefixes":["libcamera-devel","1/4"]}