{"id":10187,"url":"https://patchwork.libcamera.org/api/patches/10187/?format=json","web_url":"https://patchwork.libcamera.org/patch/10187/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021154148.511505-11-kieran.bingham@ideasonboard.com>","date":"2020-10-21T15:41:43","name":"[libcamera-devel,v4,10/15] android: metadata: Disable -Wshadow","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dae17d3c6697a759b81fd649925efb52b59a09b0","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10187/mbox/","series":[{"id":1401,"url":"https://patchwork.libcamera.org/api/series/1401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1401","date":"2020-10-21T15:41:33","name":"Shadowed Variables","version":4,"mbox":"https://patchwork.libcamera.org/series/1401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10187/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10187/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3740BDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:42:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF6B060C14;\n\tWed, 21 Oct 2020 17:42:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C004E60D5A\n\tfor ;\n\tWed, 21 Oct 2020 17:41:56 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 47AD5116B;\n\tWed, 21 Oct 2020 17:41:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qBL6NOIA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294916;\n\tbh=4cG1mI7Pb2IcTyAjAnQorh4uWiwngvevHCB9h10I83A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qBL6NOIANVPhEV5Q2n7+W4wzceWqcOcvcx6M5jjyt6tiVI7texkIOdB3GTRanyhKd\n\tBcT7wTQ99RO90UQGMmI1ZhCIZUcdSEnUbT1gx42W/82G7y4luI/bntLiykdBh3HW7k\n\tIq3PVXQiwlRT1GBgAgTcVTIMFJ4yKwW2AXGnfT3g=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 21 Oct 2020 16:41:43 +0100","Message-Id":"<20201021154148.511505-11-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","References":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 10/15] android: metadata: Disable\n\t-Wshadow","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Do not warn on shadowed variables inside the metadata library,\nwhich is directly imported without modifications.\n\nSuggested-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/android/meson.build | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/android/meson.build b/src/android/meson.build\nindex 5a01bea374c3..f72376a09497 100644\n--- a/src/android/meson.build\n+++ b/src/android/meson.build\n@@ -33,4 +33,5 @@ android_camera_metadata_sources = files([\n \n android_camera_metadata = static_library('camera_metadata',\n android_camera_metadata_sources,\n+ c_args : '-Wno-shadow',\n include_directories : android_includes)\n","prefixes":["libcamera-devel","v4","10/15"]}