[{"id":13363,"web_url":"https://patchwork.libcamera.org/comment/13363/","msgid":"<20201021154836.GB3942@pendragon.ideasonboard.com>","date":"2020-10-21T15:48:36","subject":"Re: [libcamera-devel] [PATCH v4 07/15] android: camera_device: Use\n\texisting variable definitions","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Oct 21, 2020 at 04:41:40PM +0100, Kieran Bingham wrote:\n> Prevent variable shadowing by removing the redeclaration of variables\n> with the same name (and type) where the existing variable can be reused.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index e9404c2f3004..5272b9ecded7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1316,7 +1316,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t * the Android camera3_stream_t.\n> \t */\n> \tfor (CameraStream &cameraStream : streams_) {\n> -\t\tint ret = cameraStream.configure();\n> +\t\tret = cameraStream.configure();\n> \t\tif (ret) {\n> \t\t\tLOG(HAL, Error) << \"Failed to configure camera stream\";\n> \t\t\treturn ret;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CE7FBDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:49:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B666960BE7;\n\tWed, 21 Oct 2020 17:49:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55CE2603F9\n\tfor ;\n\tWed, 21 Oct 2020 17:49:22 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B824992;\n\tWed, 21 Oct 2020 17:49:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fOkVEurr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603295361;\n\tbh=ES+xPjjdQiV4jEko0Eof6xw+4ZpdMoCIYtqlKujRUOo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fOkVEurruY6nwsQPdZy1SOiboSGOyxgUEeBV2R579VBpNSVjw3Agjfe2/KRye6ruz\n\tL5hZjbCKnT2WeQ7iOkufNDlY48Gg6ALgcrQVFVbFVk+oTFNKu+dofcrxcePjXsnSdb\n\tld5+IOJUFVTTCFIaVEVhjTZbKpWHdweXZoUBk8p0=","Date":"Wed, 21 Oct 2020 18:48:36 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201021154836.GB3942@pendragon.ideasonboard.com>","References":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>\n\t<20201021154148.511505-8-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201021154148.511505-8-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 07/15] android: camera_device: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]