{"id":10184,"url":"https://patchwork.libcamera.org/api/patches/10184/?format=json","web_url":"https://patchwork.libcamera.org/patch/10184/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021154148.511505-8-kieran.bingham@ideasonboard.com>","date":"2020-10-21T15:41:40","name":"[libcamera-devel,v4,07/15] android: camera_device: Use existing variable definitions","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1bfe09eb643bd52be31ea29b5780c03bb818a409","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10184/mbox/","series":[{"id":1401,"url":"https://patchwork.libcamera.org/api/series/1401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1401","date":"2020-10-21T15:41:33","name":"Shadowed Variables","version":4,"mbox":"https://patchwork.libcamera.org/series/1401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10184/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10184/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86853BDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:42:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 418B960DF8;\n\tWed, 21 Oct 2020 17:42:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C306660C1F\n\tfor ;\n\tWed, 21 Oct 2020 17:41:55 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5781BAEE;\n\tWed, 21 Oct 2020 17:41:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ma8hpaY1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294915;\n\tbh=h8VyB8DvYvnofHdPfx6LBGktwsB0kHLx9SkL1idm+a0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ma8hpaY1xsperzdIYJ819d8qS3+UoKFhyR7fYYpbcgR67USkv0lAOQBZjb4QkxsXz\n\tI88ug2FXazAYyN8S/BaE/sgXB+QNkHfP3vJGsT6QTu0jwrTpVJuxTC3mIDjd7Wwkhq\n\tJTgzIYxhoNt1TjdFJJTEj5DKEhDldI8cV5lCk/gg=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 21 Oct 2020 16:41:40 +0100","Message-Id":"<20201021154148.511505-8-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","References":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 07/15] android: camera_device: Use\n\texisting variable definitions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Prevent variable shadowing by removing the redeclaration of variables\nwith the same name (and type) where the existing variable can be reused.\n\nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex e9404c2f3004..5272b9ecded7 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1316,7 +1316,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t * the Android camera3_stream_t.\n \t */\n \tfor (CameraStream &cameraStream : streams_) {\n-\t\tint ret = cameraStream.configure();\n+\t\tret = cameraStream.configure();\n \t\tif (ret) {\n \t\t\tLOG(HAL, Error) << \"Failed to configure camera stream\";\n \t\t\treturn ret;\n","prefixes":["libcamera-devel","v4","07/15"]}