{"id":10170,"url":"https://patchwork.libcamera.org/api/patches/10170/?format=json","web_url":"https://patchwork.libcamera.org/patch/10170/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021143635.22846-10-jacopo@jmondi.org>","date":"2020-10-21T14:36:30","name":"[libcamera-devel,v3,09/14] libcamera: ipu3: Register camera controls","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f913422b25616f7ca458d88f044978463fd11f0a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10170/mbox/","series":[{"id":1399,"url":"https://patchwork.libcamera.org/api/series/1399/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1399","date":"2020-10-21T14:36:21","name":"libcamera: Introduce draft controls","version":3,"mbox":"https://patchwork.libcamera.org/series/1399/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10170/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10170/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D3B7BDB13\n\tfor ;\n\tWed, 21 Oct 2020 14:36:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 588E161E6F;\n\tWed, 21 Oct 2020 16:36:55 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D766261E5A\n\tfor ;\n\tWed, 21 Oct 2020 16:36:49 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4AE75C0007;\n\tWed, 21 Oct 2020 14:36:49 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Oct 2020 16:36:30 +0200","Message-Id":"<20201021143635.22846-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201021143635.22846-1-jacopo@jmondi.org>","References":"<20201021143635.22846-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 09/14] libcamera: ipu3: Register camera\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register controls for the IPU3 pipeline handler. The only supported\nCamera control is currently the pipeline depth control.\n\nReport the minimum and maximum values the pipeline handler supports\nfor the pipeline processing stages.\n\nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex af47739d8d4f..a90683ea523a 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -12,6 +12,7 @@\n #include \n \n #include \n+#include \n #include \n #include \n #include \n@@ -40,6 +41,10 @@ static constexpr unsigned int IMGU_OUTPUT_HEIGHT_ALIGN = 4;\n static constexpr unsigned int IMGU_OUTPUT_WIDTH_MARGIN = 64;\n static constexpr unsigned int IMGU_OUTPUT_HEIGHT_MARGIN = 32;\n \n+static const ControlInfoMap IPU3Controls = {\n+\t{ &controls::draft::PipelineDepth, ControlInfo(2, 3) },\n+};\n+\n class IPU3CameraData : public CameraData\n {\n public:\n@@ -771,6 +776,9 @@ int PipelineHandlerIPU3::registerCameras()\n \t\t/* Initialize the camera properties. */\n \t\tdata->properties_ = cio2->sensor()->properties();\n \n+\t\t/* Initialze the camera controls. */\n+\t\tdata->controlInfo_ = IPU3Controls;\n+\n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n \t\t * stream and camera; as of now, limit support to two cameras\n","prefixes":["libcamera-devel","v3","09/14"]}