[{"id":13389,"web_url":"https://patchwork.libcamera.org/comment/13389/","msgid":"<20201022024829.GA3942@pendragon.ideasonboard.com>","date":"2020-10-22T02:48:29","subject":"Re: [libcamera-devel] [PATCH v3 08/14] libcamera: control_ids:\n\tRemove max values in enumerations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Oct 21, 2020 at 04:36:29PM +0200, Jacopo Mondi wrote:\n> The libcamera control definition schema includes a placeholder\n> maximum value for each enumeration of supported values.\n> \n> As it is now possible to create ControlInfo from the list of enumerated\n> values, it is not necessary to generate the placeholder value anymore.\n\nVery nice :-)\n\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids.yaml | 12 ------------\n> 1 file changed, 12 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 2fca88e36635..637fbace152e 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -48,9 +48,6 @@ controls:\n> - name: MeteringCustom\n> value: 3\n> description: Custom metering mode.\n> - - name: MeteringModeMax\n> - value: 3\n> - description: Maximum allowed value (place any new values above here).\n> \n> # AeConstraintMode needs further attention:\n> # - Auto-generate max enum value.\n> @@ -85,9 +82,6 @@ controls:\n> - name: ConstraintCustom\n> value: 3\n> description: Custom constraint mode.\n> - - name: ConstraintModeMax\n> - value: 3\n> - description: Maximum allowed value (place any new values above here).\n> \n> # AeExposureMode needs further attention:\n> # - Auto-generate max enum value.\n> @@ -112,9 +106,6 @@ controls:\n> - name: ExposureCustom\n> value: 3\n> description: Custom exposure mode.\n> - - name: ExposureModeMax\n> - value: 3\n> - description: Maximum allowed value (place any new values above here).\n> \n> - ExposureValue:\n> type: float\n> @@ -204,9 +195,6 @@ controls:\n> - name: AwbCustom\n> value: 7\n> description: Custom AWB mode.\n> - - name: AwbModeMax\n> - value: 7\n> - description: Maximum allowed value (place any new values above here).\n> \n> - AwbLocked:\n> type: bool","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CC71C3D3C\n\tfor ;\n\tThu, 22 Oct 2020 02:49:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BDB560530;\n\tThu, 22 Oct 2020 04:49:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE8FE6034F\n\tfor ;\n\tThu, 22 Oct 2020 04:49:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 654F853;\n\tThu, 22 Oct 2020 04:49:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"az1we5hh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603334955;\n\tbh=w8wDIwQZK+5ulpHPbe8WqAgCHxio19WMhv1lzcGeZ6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=az1we5hhNvdUSzyiZH0Rg80NAIOJ3fnM9y7XWGxD/oCflRL/7xsifzwp6Hj1W9jXA\n\tc1NRv+BDJpX6YPBGFxlah7eLfpCW2flC2zdkiLdspxC0/VGIoqJEgaY/frRnZELx2K\n\t5AmyvGYFazgpWifTefVJSr8hv1rylTw/GkCi3JdI=","Date":"Thu, 22 Oct 2020 05:48:29 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20201022024829.GA3942@pendragon.ideasonboard.com>","References":"<20201021143635.22846-1-jacopo@jmondi.org>\n\t<20201021143635.22846-9-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201021143635.22846-9-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 08/14] libcamera: control_ids:\n\tRemove max values in enumerations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]